From 03540b2fbb375e872606341335398d7b37365a99 Mon Sep 17 00:00:00 2001
From: Wing-Kam Wong <wingkwong.code@gmail.com>
Date: Thu, 6 Apr 2023 13:25:23 +0800
Subject: [PATCH] feat(nocodb): include data change set in audit desc

---
 .../sql-data-mapper/lib/sql/BaseModelSqlv2.ts | 26 ++++++++++++++-----
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts b/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts
index aa698dcb67..2890fd3508 100644
--- a/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts
+++ b/packages/nocodb/src/lib/db/sql-data-mapper/lib/sql/BaseModelSqlv2.ts
@@ -1864,7 +1864,7 @@ class BaseModelSqlv2 {
       await this.execAndParse(query);
 
       const newData = await this.readByPk(id);
-      await this.afterUpdate(prevData, newData, trx, cookie);
+      await this.afterUpdate(prevData, newData, trx, cookie, updateObj);
       return newData;
     } catch (e) {
       console.log(e);
@@ -2393,18 +2393,32 @@ class BaseModelSqlv2 {
     prevData: any,
     newData: any,
     _trx: any,
-    req
+    req,
+    updateObj?: Record<string, any>
   ): Promise<void> {
     const id = this._extractPksValues(newData);
-
+    let desc = `Record with ID ${id} has been updated in Table ${this.model.title}.`;
+    if (updateObj) {
+      updateObj = await this.model.mapColumnToAlias(updateObj);
+      for (const k of Object.keys(updateObj)) {
+        const prevValue =
+          typeof prevData[k] === 'object'
+            ? JSON.stringify(prevData[k])
+            : prevData[k];
+        const newValue =
+          typeof newData[k] === 'object'
+            ? JSON.stringify(newData[k])
+            : newData[k];
+        desc += `\n`;
+        desc += `Column "${k}" got changed from "${prevValue}" to "${newValue}"`;
+      }
+    }
     await Audit.insert({
       fk_model_id: this.model.id,
       row_id: id,
       op_type: AuditOperationTypes.DATA,
       op_sub_type: AuditOperationSubTypes.UPDATE,
-      description: DOMPurify.sanitize(
-        `Record with ID ${id} has been updated in Table ${this.model.title}`
-      ),
+      description: DOMPurify.sanitize(desc),
       // details: JSON.stringify(data),
       ip: req?.clientIp,
       user: req?.user?.email,