From 03017f31abb7112f1ebb7e17db8c829372a20c5a Mon Sep 17 00:00:00 2001 From: Pranav C Date: Fri, 14 Jun 2024 08:35:58 +0000 Subject: [PATCH] refactor: handle if lookuprelation not found --- packages/nc-gui/composables/useViewFilters.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/nc-gui/composables/useViewFilters.ts b/packages/nc-gui/composables/useViewFilters.ts index f4d3c302bb..5b834476d8 100644 --- a/packages/nc-gui/composables/useViewFilters.ts +++ b/packages/nc-gui/composables/useViewFilters.ts @@ -418,8 +418,7 @@ export function useViewFilters( status: undefined, } } else { - console.log(parentId.value) - const savedFilter = await $api.dbTableFilter.create(view.value.id!, { + const savedFilter = await $api.dbTableFilter.create(view.value!.id!, { ...filter, fk_parent_id: parentId.value, }) @@ -455,7 +454,7 @@ export function useViewFilters( // Recursively delete child filter of child filter childFilters.forEach((childFilter) => { if (childFilter.is_group) { - deleteFilterGroupFromAllFilters(childFilter) + deleteFilterGroupFromAllFilters(childFilter as ColumnFilterType) } }) @@ -598,6 +597,12 @@ export function useViewFilters( const lookupRelation = (await getMeta(nextCol.fk_model_id!))?.columns?.find( (c) => c.id === (nextCol!.colOptions as LookupType).fk_relation_column_id, ) + + // this is less likely to happen but if relation column is not found then break the loop + if (!lookupRelation) { + break + } + const relatedTableMeta = await getMeta((lookupRelation?.colOptions as LinkToAnotherRecordType).fk_related_model_id!) nextCol = relatedTableMeta?.columns?.find((c) => c.id === (nextCol!.colOptions as LookupType).fk_lookup_column_id)