From 02854a9e41584e2990553a130fd0a04ad67e8f5f Mon Sep 17 00:00:00 2001
From: Pranav C <pranavxc@gmail.com>
Date: Thu, 19 Jan 2023 10:49:50 +0530
Subject: [PATCH] fix(api): mssql - alter column query correction

Signed-off-by: Pranav C <pranavxc@gmail.com>
---
 .../nocodb/src/lib/db/sql-client/lib/mssql/MssqlClient.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/nocodb/src/lib/db/sql-client/lib/mssql/MssqlClient.ts b/packages/nocodb/src/lib/db/sql-client/lib/mssql/MssqlClient.ts
index 27feafb56b..962ae5eca8 100644
--- a/packages/nocodb/src/lib/db/sql-client/lib/mssql/MssqlClient.ts
+++ b/packages/nocodb/src/lib/db/sql-client/lib/mssql/MssqlClient.ts
@@ -2631,7 +2631,7 @@ class MssqlClient extends KnexClient {
 
       if (n.dtxp !== o.dtxp && !['text'].includes(n.dt)) {
         query += this.genQuery(
-          `\nALTER TABLE ?? ALTER COLUMN ?? ${n.dt}(${n.dtxp});\n`,
+          `\nALTER TABLE ?? ALTER COLUMN ?? ${n.dt}${!getDefaultLengthIsDisabled(n.dt) && n.dtxp ? `(${n.dtxp})` : ''};\n`,
           [this.getTnPath(t), n.cn],
           shouldSanitize
         );
@@ -2797,9 +2797,6 @@ function getDefaultLengthIsDisabled(type) {
     // case 'sysname':
     case 'bigint':
     case 'bit':
-    case 'date':
-    case 'datetime':
-    case 'datetime2':
     case 'datetimeoffset':
     case 'decimal':
     case 'float':
@@ -2824,6 +2821,9 @@ function getDefaultLengthIsDisabled(type) {
       return true;
       break;
     default:
+    case 'date':
+    case 'datetime':
+    case 'datetime2':
     case 'varchar':
       return false;
       break;