From 85aaabe2ccae8b7387f40bbab9d655aa55657f28 Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Wed, 6 Sep 2023 17:24:12 +0300
Subject: [PATCH 1/4] chore(nc-gui): lint error and warnings

Signed-off-by: mertmit <mertmit99@gmail.com>
---
 .../components/cell/attachment/Carousel.vue   |  2 +-
 .../components/cell/attachment/utils.ts       |  3 +-
 .../components/dashboard/Sidebar/Header.vue   |  2 -
 .../dashboard/Sidebar/TopSection/Header.vue   |  2 +-
 .../dashboard/TreeView/BaseOptions.vue        |  5 +--
 .../dashboard/TreeView/ProjectNode.vue        |  4 --
 .../settings/data-sources/CreateBase.vue      | 39 +------------------
 .../settings/data-sources/EditBase.vue        | 37 ------------------
 .../nc-gui/components/dlg/AirtableImport.vue  |  1 -
 .../nc-gui/components/dlg/ProjectDelete.vue   |  4 --
 .../nc-gui/components/dlg/TableCreate.vue     |  3 +-
 .../dlg/share-and-collaborate/SharePage.vue   |  3 +-
 .../dlg/share-and-collaborate/View.vue        |  2 -
 .../nc-gui/components/general/DeleteModal.vue |  2 +
 .../nc-gui/components/general/UserIcon.vue    |  2 -
 .../components/project/AccessSettings.vue     |  2 -
 .../project/InviteProjectCollabSection.vue    |  6 +--
 packages/nc-gui/components/project/View.vue   |  2 +
 .../nc-gui/components/smartsheet/Gallery.vue  |  1 -
 .../components/smartsheet/Pagination.vue      |  4 --
 .../nc-gui/components/smartsheet/Toolbar.vue  |  2 +-
 .../nc-gui/components/smartsheet/Topbar.vue   |  6 +--
 .../smartsheet/toolbar/ColumnFilterMenu.vue   |  6 +--
 .../smartsheet/toolbar/FieldsMenu.vue         |  2 +-
 .../smartsheet/toolbar/SortListMenu.vue       |  2 -
 .../nc-gui/components/tabs/Smartsheet.vue     |  3 --
 .../workspace/CollaboratorsList.vue           |  1 -
 .../components/workspace/CreateProjectDlg.vue |  2 +-
 .../components/workspace/ProjectList.vue      |  4 ++
 packages/nc-gui/components/workspace/View.vue |  2 -
 .../[typeOrId]/[projectId]/index/index.vue    |  4 --
 .../[viewId]/[[viewTitle]]/[...slugs].vue     |  2 +-
 packages/nc-gui/utils/iconUtils.ts            |  7 ----
 33 files changed, 25 insertions(+), 144 deletions(-)

diff --git a/packages/nc-gui/components/cell/attachment/Carousel.vue b/packages/nc-gui/components/cell/attachment/Carousel.vue
index e0408693c4..55c4f8a48e 100644
--- a/packages/nc-gui/components/cell/attachment/Carousel.vue
+++ b/packages/nc-gui/components/cell/attachment/Carousel.vue
@@ -1,7 +1,7 @@
 <script lang="ts" setup>
 import { onKeyDown } from '@vueuse/core'
 import { useAttachmentCell } from './utils'
-import { computed, iconMap, isImage, onClickOutside, ref, useAttachment, useEventListener } from '#imports'
+import { computed, iconMap, isImage, ref, useAttachment, useEventListener } from '#imports'
 
 const { selectedImage, visibleItems, downloadFile } = useAttachmentCell()!
 
diff --git a/packages/nc-gui/components/cell/attachment/utils.ts b/packages/nc-gui/components/cell/attachment/utils.ts
index 6e243b3004..7938e256b6 100644
--- a/packages/nc-gui/components/cell/attachment/utils.ts
+++ b/packages/nc-gui/components/cell/attachment/utils.ts
@@ -1,5 +1,4 @@
 import type { AttachmentType } from 'nocodb-sdk'
-import { readonly } from '@vue/reactivity'
 import RenameFile from './RenameFile.vue'
 import {
   ColumnInj,
@@ -34,7 +33,7 @@ export const [useProvideAttachmentCell, useAttachmentCell] = useInjectionState(
   (updateModelValue: (data: string | Record<string, any>[]) => void) => {
     const isReadonly = inject(ReadonlyInj, ref(false))
 
-    const isLockedMode = inject(IsLockedInj, ref(false))
+    // const isLockedMode = inject(IsLockedInj, ref(false))
 
     const isPublic = inject(IsPublicInj, ref(false))
 
diff --git a/packages/nc-gui/components/dashboard/Sidebar/Header.vue b/packages/nc-gui/components/dashboard/Sidebar/Header.vue
index 9e73d8fbd3..f6ff58e904 100644
--- a/packages/nc-gui/components/dashboard/Sidebar/Header.vue
+++ b/packages/nc-gui/components/dashboard/Sidebar/Header.vue
@@ -1,10 +1,8 @@
 <script setup lang="ts">
 const workspaceStore = useWorkspace()
-const projectStore = useProject()
 
 const { isLeftSidebarOpen } = storeToRefs(useSidebarStore())
 
-const { isSharedBase } = storeToRefs(projectStore)
 const { activeWorkspace, isWorkspaceLoading } = storeToRefs(workspaceStore)
 </script>
 
diff --git a/packages/nc-gui/components/dashboard/Sidebar/TopSection/Header.vue b/packages/nc-gui/components/dashboard/Sidebar/TopSection/Header.vue
index cc340bc4c9..34bc188cf7 100644
--- a/packages/nc-gui/components/dashboard/Sidebar/TopSection/Header.vue
+++ b/packages/nc-gui/components/dashboard/Sidebar/TopSection/Header.vue
@@ -1 +1 @@
-<template></template>
+<template><span /></template>
diff --git a/packages/nc-gui/components/dashboard/TreeView/BaseOptions.vue b/packages/nc-gui/components/dashboard/TreeView/BaseOptions.vue
index 1d0346177f..4991507861 100644
--- a/packages/nc-gui/components/dashboard/TreeView/BaseOptions.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/BaseOptions.vue
@@ -115,10 +115,9 @@ function openQuickImportDialog(type: string) {
     </a-menu-item>
   </a-sub-menu>
 
-  <a-menu-divider v-if="false" class="my-0" />
-
   <!-- Connect to new datasource -->
-  <!-- <a-sub-menu>
+  <!-- <a-menu-divider v-if="false" class="my-0" />
+  <a-sub-menu>
     <template #title>
       <div class="nc-project-menu-item group">
         <GeneralIcon icon="datasource" class="group-hover:text-black" />
diff --git a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
index 91c699e9f9..34859e8ad6 100644
--- a/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/ProjectNode.vue
@@ -472,8 +472,6 @@ const DlgProjectDuplicateOnOk = async (jobData: { id: string; project_id: string
                     </div>
                   </a-menu-item>
 
-                  <a-menu-divider v-if="false" />
-
                   <!-- ERD View -->
                   <a-menu-item key="erd" @click="openProjectErdView(project)">
                     <div class="nc-project-menu-item group">
@@ -513,8 +511,6 @@ const DlgProjectDuplicateOnOk = async (jobData: { id: string; project_id: string
                   <a-menu-divider />
                 </template>
 
-                <a-menu-divider v-if="false" />
-
                 <a-menu-item v-if="isUIAllowed('projectDelete', false, projectRole)" @click="isProjectDeleteDialogVisible = true">
                   <div class="nc-project-menu-item group text-red-500">
                     <GeneralIcon icon="delete" />
diff --git a/packages/nc-gui/components/dashboard/settings/data-sources/CreateBase.vue b/packages/nc-gui/components/dashboard/settings/data-sources/CreateBase.vue
index e47167d3b2..33ac0a8208 100644
--- a/packages/nc-gui/components/dashboard/settings/data-sources/CreateBase.vue
+++ b/packages/nc-gui/components/dashboard/settings/data-sources/CreateBase.vue
@@ -1,5 +1,5 @@
 <script lang="ts" setup>
-import { Form, Modal, message } from 'ant-design-vue'
+import { Form, message } from 'ant-design-vue'
 import type { SelectHandler } from 'ant-design-vue/es/vc-select/Select'
 import type { DefaultConnection, ProjectCreateForm, SQLiteConnection } from '#imports'
 import {
@@ -423,43 +423,6 @@ watch(
           <a-input v-model:value="(formState.dataSource.connection as SQLiteConnection).connection.filename" />
         </a-form-item>
 
-        <template v-else-if="formState.dataSource.client === ClientType.SNOWFLAKE && false">
-          <!-- Account -->
-          <a-form-item label="Account" v-bind="validateInfos['dataSource.connection.account']">
-            <a-input v-model:value="formState.dataSource.connection.account" class="nc-extdb-account" />
-          </a-form-item>
-
-          <!-- Username -->
-          <a-form-item :label="$t('labels.username')" v-bind="validateInfos['dataSource.connection.username']">
-            <a-input v-model:value="formState.dataSource.connection.username" class="nc-extdb-host-user" />
-          </a-form-item>
-
-          <!-- Password -->
-          <a-form-item :label="$t('labels.password')" v-bind="validateInfos['dataSource.connection.password']">
-            <a-input-password v-model:value="formState.dataSource.connection.password" class="nc-extdb-host-password" />
-          </a-form-item>
-
-          <!-- Warehouse -->
-          <a-form-item label="Warehouse" v-bind="validateInfos['dataSource.connection.warehouse']">
-            <a-input v-model:value="formState.dataSource.connection.warehouse" />
-          </a-form-item>
-
-          <!-- Database -->
-          <a-form-item :label="$t('labels.database')" v-bind="validateInfos['dataSource.connection.database']">
-            <!-- Database : create if not exists -->
-            <a-input
-              v-model:value="formState.dataSource.connection.database"
-              :placeholder="$t('labels.dbCreateIfNotExists')"
-              class="nc-extdb-host-database"
-            />
-          </a-form-item>
-
-          <!-- Schema name -->
-          <a-form-item :label="$t('labels.schemaName')" v-bind="validateInfos['dataSource.connection.schema']">
-            <a-input v-model:value="formState.dataSource.connection.schema" />
-          </a-form-item>
-        </template>
-
         <template v-else>
           <!-- Host Address -->
           <a-form-item :label="$t('labels.hostAddress')" v-bind="validateInfos['dataSource.connection.host']">
diff --git a/packages/nc-gui/components/dashboard/settings/data-sources/EditBase.vue b/packages/nc-gui/components/dashboard/settings/data-sources/EditBase.vue
index cd92f90081..de9746ae25 100644
--- a/packages/nc-gui/components/dashboard/settings/data-sources/EditBase.vue
+++ b/packages/nc-gui/components/dashboard/settings/data-sources/EditBase.vue
@@ -380,43 +380,6 @@ onMounted(async () => {
           <a-input v-model:value="(formState.dataSource.connection as SQLiteConnection).connection.filename" />
         </a-form-item>
 
-        <template v-else-if="formState.dataSource.client === ClientType.SNOWFLAKE && false">
-          <!-- Account -->
-          <a-form-item label="Account" v-bind="validateInfos['dataSource.connection.account']">
-            <a-input v-model:value="formState.dataSource.connection.account" class="nc-extdb-account" />
-          </a-form-item>
-
-          <!-- Username -->
-          <a-form-item :label="$t('labels.username')" v-bind="validateInfos['dataSource.connection.username']">
-            <a-input v-model:value="formState.dataSource.connection.username" class="nc-extdb-host-user" />
-          </a-form-item>
-
-          <!-- Password -->
-          <a-form-item :label="$t('labels.password')" v-bind="validateInfos['dataSource.connection.password']">
-            <a-input-password v-model:value="formState.dataSource.connection.password" class="nc-extdb-host-password" />
-          </a-form-item>
-
-          <!-- Warehouse -->
-          <a-form-item label="Warehouse" v-bind="validateInfos['dataSource.connection.warehouse']">
-            <a-input v-model:value="formState.dataSource.connection.warehouse" />
-          </a-form-item>
-
-          <!-- Database -->
-          <a-form-item :label="$t('labels.database')" v-bind="validateInfos['dataSource.connection.database']">
-            <!-- Database : create if not exists -->
-            <a-input
-              v-model:value="formState.dataSource.connection.database"
-              :placeholder="$t('labels.dbCreateIfNotExists')"
-              class="nc-extdb-host-database"
-            />
-          </a-form-item>
-
-          <!-- Schema name -->
-          <a-form-item :label="$t('labels.schemaName')" v-bind="validateInfos['dataSource.connection.schema']">
-            <a-input v-model:value="formState.dataSource.connection.schema" />
-          </a-form-item>
-        </template>
-
         <template v-else>
           <!-- Host Address -->
           <a-form-item :label="$t('labels.hostAddress')" v-bind="validateInfos['dataSource.connection.host']">
diff --git a/packages/nc-gui/components/dlg/AirtableImport.vue b/packages/nc-gui/components/dlg/AirtableImport.vue
index 136b6bc096..08b2fe21db 100644
--- a/packages/nc-gui/components/dlg/AirtableImport.vue
+++ b/packages/nc-gui/components/dlg/AirtableImport.vue
@@ -12,7 +12,6 @@ import {
   onMounted,
   ref,
   storeToRefs,
-  useGlobal,
   useNuxtApp,
   useProject,
   watch,
diff --git a/packages/nc-gui/components/dlg/ProjectDelete.vue b/packages/nc-gui/components/dlg/ProjectDelete.vue
index ae729f2a9e..fc65218da4 100644
--- a/packages/nc-gui/components/dlg/ProjectDelete.vue
+++ b/packages/nc-gui/components/dlg/ProjectDelete.vue
@@ -1,6 +1,4 @@
 <script lang="ts" setup>
-import { navigateTo } from '#app'
-
 const props = defineProps<{
   visible: boolean
   projectId: string
@@ -22,8 +20,6 @@ const project = computed(() => projects.value.get(props.projectId))
 
 const isLoading = ref(false)
 
-const { projectsList } = storeToRefs(projectsStore)
-
 const onDelete = async () => {
   if (!project.value) return
 
diff --git a/packages/nc-gui/components/dlg/TableCreate.vue b/packages/nc-gui/components/dlg/TableCreate.vue
index 69a93ec796..45011775fa 100644
--- a/packages/nc-gui/components/dlg/TableCreate.vue
+++ b/packages/nc-gui/components/dlg/TableCreate.vue
@@ -3,7 +3,6 @@ import {
   Form,
   TabType,
   computed,
-  iconMap,
   nextTick,
   onMounted,
   ref,
@@ -153,6 +152,7 @@ onMounted(() => {
             :placeholder="$t('msg.info.enterTableName')"
           />
         </a-form-item>
+        <!--
         <div v-if="false" class="flex justify-end items-center">
           <div
             class="pointer flex flex-row items-center gap-x-1 cursor-pointer"
@@ -164,6 +164,7 @@ onMounted(() => {
             <component :is="iconMap.plusCircle" v-else class="text-gray-500" />
           </div>
         </div>
+        -->
         <div class="nc-table-advanced-options" :class="{ active: isAdvanceOptVisible }">
           <!-- hint="Table name as saved in database" -->
           <!-- <div v-if="!project.prefix" class="mb-2">{{ $t('msg.info.tableNameInDb') }}</div>
diff --git a/packages/nc-gui/components/dlg/share-and-collaborate/SharePage.vue b/packages/nc-gui/components/dlg/share-and-collaborate/SharePage.vue
index e288297d49..20d436595e 100644
--- a/packages/nc-gui/components/dlg/share-and-collaborate/SharePage.vue
+++ b/packages/nc-gui/components/dlg/share-and-collaborate/SharePage.vue
@@ -2,8 +2,7 @@
 import type { ColumnType, KanbanType, ViewType } from 'nocodb-sdk'
 import { ViewTypes } from 'nocodb-sdk'
 import tinycolor from 'tinycolor2'
-import { useTablesStore } from '~/store/tables'
-import { useMetas } from '~/composables/useMetas'
+import { useMetas } from '#imports'
 
 const { view: _view, $api } = useSmartsheetStoreOrThrow()
 const { $e } = useNuxtApp()
diff --git a/packages/nc-gui/components/dlg/share-and-collaborate/View.vue b/packages/nc-gui/components/dlg/share-and-collaborate/View.vue
index ba5426fb79..c0eaec9ee5 100644
--- a/packages/nc-gui/components/dlg/share-and-collaborate/View.vue
+++ b/packages/nc-gui/components/dlg/share-and-collaborate/View.vue
@@ -6,8 +6,6 @@ import { useViewsStore } from '~/store/views'
 const { isViewToolbar } = defineProps<{
   isViewToolbar?: boolean
 }>()
-const router = useRouter()
-const route = router.currentRoute
 
 const { copy } = useCopy()
 const { dashboardUrl } = useDashboard()
diff --git a/packages/nc-gui/components/general/DeleteModal.vue b/packages/nc-gui/components/general/DeleteModal.vue
index 1e79a75899..62de49a4e2 100644
--- a/packages/nc-gui/components/general/DeleteModal.vue
+++ b/packages/nc-gui/components/general/DeleteModal.vue
@@ -52,10 +52,12 @@ onKeyStroke('Enter', () => {
 
       <slot name="entity-preview"></slot>
 
+      <!--
       <div v-if="false" class="flex flex-row items-center py-2 px-3 border-1 border-gray-100 rounded-lg text-gray-700">
         <GeneralIcon icon="warning" class="text-orange-500"></GeneralIcon>
         <div class="pl-2.5 text-gray-500">This action cannot be undone</div>
       </div>
+      -->
 
       <div class="flex flex-row gap-x-2 mt-2.5 pt-2.5 justify-end">
         <NcButton type="secondary" @click="visible = false">
diff --git a/packages/nc-gui/components/general/UserIcon.vue b/packages/nc-gui/components/general/UserIcon.vue
index e0428d02bf..32c8bdda4f 100644
--- a/packages/nc-gui/components/general/UserIcon.vue
+++ b/packages/nc-gui/components/general/UserIcon.vue
@@ -1,6 +1,4 @@
 <script lang="ts" setup>
-import type { UserType } from 'nocodb-sdk'
-
 const props = defineProps<{
   hideLabel?: boolean
   size?: 'small' | 'medium'
diff --git a/packages/nc-gui/components/project/AccessSettings.vue b/packages/nc-gui/components/project/AccessSettings.vue
index 94975a96b1..d90955c85f 100644
--- a/packages/nc-gui/components/project/AccessSettings.vue
+++ b/packages/nc-gui/components/project/AccessSettings.vue
@@ -111,8 +111,6 @@ watchDebounced(
   },
 )
 
-const modal = ref(true)
-
 const reloadCollabs = async () => {
   currentPage.value = 0
   collaborators.value = []
diff --git a/packages/nc-gui/components/project/InviteProjectCollabSection.vue b/packages/nc-gui/components/project/InviteProjectCollabSection.vue
index 0f658f7767..7155fbec43 100644
--- a/packages/nc-gui/components/project/InviteProjectCollabSection.vue
+++ b/packages/nc-gui/components/project/InviteProjectCollabSection.vue
@@ -1,6 +1,6 @@
 <script lang="ts" setup>
-import { ProjectRoles, WorkspaceUserRoles } from 'nocodb-sdk'
-import { extractSdkResponseErrorMsg, useDashboard, useManageUsers, useProject, useWorkspace } from '#imports'
+import { ProjectRoles } from 'nocodb-sdk'
+import { extractSdkResponseErrorMsg, useDashboard, useManageUsers } from '#imports'
 
 const emit = defineEmits(['invited'])
 
@@ -9,8 +9,6 @@ const inviteData = reactive({
   roles: ProjectRoles.VIEWER,
 })
 
-const projectStore = useProject()
-
 const { dashboardUrl } = useDashboard()
 
 const { inviteUser } = useManageUsers()
diff --git a/packages/nc-gui/components/project/View.vue b/packages/nc-gui/components/project/View.vue
index c26f8fda4f..c32e2694a9 100644
--- a/packages/nc-gui/components/project/View.vue
+++ b/packages/nc-gui/components/project/View.vue
@@ -115,6 +115,7 @@ watch(
           </template>
           <DashboardSettingsDataSources v-model:state="baseSettingsState" />
         </a-tab-pane>
+        <!--
         <a-tab-pane v-if="false && isUIAllowed('acl')" key="ui-acl">
           <template #tab>
             <div class="tab-title" data-testid="proj-view-tab__ui-acl">
@@ -124,6 +125,7 @@ watch(
           </template>
           <DashboardSettingsUIAclTabs class="mt-6" />
         </a-tab-pane>
+        -->
       </a-tabs>
     </div>
   </div>
diff --git a/packages/nc-gui/components/smartsheet/Gallery.vue b/packages/nc-gui/components/smartsheet/Gallery.vue
index 43b4703e23..29df87fa68 100644
--- a/packages/nc-gui/components/smartsheet/Gallery.vue
+++ b/packages/nc-gui/components/smartsheet/Gallery.vue
@@ -17,7 +17,6 @@ import {
   computed,
   createEventHook,
   extractPkFromRow,
-  iconMap,
   inject,
   isImage,
   isLTAR,
diff --git a/packages/nc-gui/components/smartsheet/Pagination.vue b/packages/nc-gui/components/smartsheet/Pagination.vue
index c3f1ef99dd..42bf0e7404 100644
--- a/packages/nc-gui/components/smartsheet/Pagination.vue
+++ b/packages/nc-gui/components/smartsheet/Pagination.vue
@@ -28,12 +28,8 @@ const fixedSize = toRef(props, 'fixedSize')
 
 const extraStyle = toRef(props, 'extraStyle')
 
-const isPublic = inject(IsPublicInj, ref(false))
-
 const isGroupBy = inject(IsGroupByInj, ref(false))
 
-const { isLeftSidebarOpen, isRightSidebarOpen } = storeToRefs(useSidebarStore())
-
 const { isPaginationLoading } = storeToRefs(useViewsStore())
 
 const count = computed(() => vPaginationData.value?.totalRows ?? Infinity)
diff --git a/packages/nc-gui/components/smartsheet/Toolbar.vue b/packages/nc-gui/components/smartsheet/Toolbar.vue
index 92fbb1741b..90fa6b49a6 100644
--- a/packages/nc-gui/components/smartsheet/Toolbar.vue
+++ b/packages/nc-gui/components/smartsheet/Toolbar.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { IsPublicInj, inject, ref, useSharedView, useSmartsheetStoreOrThrow, useUIPermission, useViewsStore } from '#imports'
 
-const { isGrid, isForm, isGallery, isKanban, isMap } = useSmartsheetStoreOrThrow()
+const { isGrid, isGallery, isKanban, isMap } = useSmartsheetStoreOrThrow()
 
 const isPublic = inject(IsPublicInj, ref(false))
 
diff --git a/packages/nc-gui/components/smartsheet/Topbar.vue b/packages/nc-gui/components/smartsheet/Topbar.vue
index cf502f9fb4..012d0576dc 100644
--- a/packages/nc-gui/components/smartsheet/Topbar.vue
+++ b/packages/nc-gui/components/smartsheet/Topbar.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { IsPublicInj, inject, ref, useSharedView, useSmartsheetStoreOrThrow, useUIPermission, useViewsStore } from '#imports'
+import { IsPublicInj, inject, ref, useSmartsheetStoreOrThrow, useViewsStore } from '#imports'
 
 const { isGrid, isForm, isGallery, isKanban, isMap } = useSmartsheetStoreOrThrow()
 
@@ -12,10 +12,6 @@ const { isViewsLoading } = storeToRefs(useViewsStore())
 
 const { isMobileMode } = useGlobal()
 
-const { isUIAllowed } = useUIPermission()
-
-const { allowCSVDownload } = useSharedView()
-
 const isSharedBase = computed(() => route.value.params.typeOrId === 'base')
 </script>
 
diff --git a/packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
index 0d0a569411..16368b3395 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
@@ -3,13 +3,11 @@ import type ColumnFilter from './ColumnFilter.vue'
 import {
   ActiveViewInj,
   IsLockedInj,
-  IsPublicInj,
   computed,
   inject,
   ref,
   useGlobal,
   useMenuCloseOnEsc,
-  useNuxtApp,
   useSmartsheetStoreOrThrow,
   useViewFilters,
   watch,
@@ -21,14 +19,12 @@ const isLocked = inject(IsLockedInj, ref(false))
 
 const activeView = inject(ActiveViewInj, ref())
 
-const isPublic = inject(IsPublicInj, ref(false))
+// const isPublic = inject(IsPublicInj, ref(false))
 
 const { filterAutoSave, isMobileMode } = useGlobal()
 
 const filterComp = ref<typeof ColumnFilter>()
 
-const { $e } = useNuxtApp()
-
 const { nestedFilters } = useSmartsheetStoreOrThrow()
 
 // todo: avoid duplicate api call by keeping a filter store
diff --git a/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
index 5e82426ca9..6008b7fe98 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
@@ -350,7 +350,7 @@ useMenuCloseOnEsc(open)
               No fields found
             </div>
             <Draggable v-model="fields" item-key="id" @change="onMove($event)">
-              <template #item="{ element: field, index: index }">
+              <template #item="{ element: field }">
                 <div
                   v-if="
                     filteredFieldList
diff --git a/packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue
index 5d4bde68e1..08886d0919 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/SortListMenu.vue
@@ -30,8 +30,6 @@ const { sorts, saveOrUpdate, loadSorts, addSort: _addSort, deleteSort } = useVie
 
 const { showSystemFields, metaColumnById } = useViewColumns(view, meta)
 
-const removeIcon = ref<HTMLElement>()
-
 const showCreateSort = ref(false)
 
 const { isMobileMode } = useGlobal()
diff --git a/packages/nc-gui/components/tabs/Smartsheet.vue b/packages/nc-gui/components/tabs/Smartsheet.vue
index d3cb2cdffc..407336aa0d 100644
--- a/packages/nc-gui/components/tabs/Smartsheet.vue
+++ b/packages/nc-gui/components/tabs/Smartsheet.vue
@@ -54,9 +54,6 @@ const { isGallery, isGrid, isForm, isKanban, isLocked, isMap } = useProvideSmart
 
 useSqlEditor()
 
-const { openedProject } = storeToRefs(useProjects())
-const { activeTable } = storeToRefs(useTablesStore())
-
 const reloadEventHook = createEventHook<void | boolean>()
 
 const reloadViewMetaEventHook = createEventHook<void | boolean>()
diff --git a/packages/nc-gui/components/workspace/CollaboratorsList.vue b/packages/nc-gui/components/workspace/CollaboratorsList.vue
index ba442379e0..7ef1d1da25 100644
--- a/packages/nc-gui/components/workspace/CollaboratorsList.vue
+++ b/packages/nc-gui/components/workspace/CollaboratorsList.vue
@@ -1,6 +1,5 @@
 <script lang="ts" setup>
 import { OrderedWorkspaceRoles, RoleColors, RoleLabels, WorkspaceUserRoles } from 'nocodb-sdk'
-import { Empty } from 'ant-design-vue'
 import { storeToRefs, stringToColour, timeAgo, useWorkspace } from '#imports'
 
 const { user } = useGlobal()
diff --git a/packages/nc-gui/components/workspace/CreateProjectDlg.vue b/packages/nc-gui/components/workspace/CreateProjectDlg.vue
index 70ef37e4fd..bc11b1c02a 100644
--- a/packages/nc-gui/components/workspace/CreateProjectDlg.vue
+++ b/packages/nc-gui/components/workspace/CreateProjectDlg.vue
@@ -15,7 +15,7 @@ const emit = defineEmits(['update:modelValue'])
 const dialogShow = useVModel(props, 'modelValue', emit)
 
 const projectsStore = useProjects()
-const { loadProjects, createProject: _createProject } = projectsStore
+const { createProject: _createProject } = projectsStore
 
 const { navigateToProject } = useGlobal()
 
diff --git a/packages/nc-gui/components/workspace/ProjectList.vue b/packages/nc-gui/components/workspace/ProjectList.vue
index fe89af466d..ff2b4a8ac5 100644
--- a/packages/nc-gui/components/workspace/ProjectList.vue
+++ b/packages/nc-gui/components/workspace/ProjectList.vue
@@ -139,10 +139,12 @@ const workspaceMoveProjectOnSuccess = async (workspaceId: string) => {
   })
 }
 
+/*
 const moveProject = (project: ProjectType) => {
   selectedProjectToMove.value = project
   isMoveDlgOpen.value = true
 }
+*/
 
 const isDuplicateDlgOpen = ref(false)
 const selectedProjectToDuplicate = ref()
@@ -360,6 +362,7 @@ const setIcon = async (icon: string, project: ProjectType) => {
                     {{ $t('general.duplicate') }} {{ $t('objects.project') }}
                   </div>
                 </a-menu-item>
+                <!--
                 <a-menu-item
                   v-if="false && isUIAllowed('moveProject', true, [record.workspace_role, record.project_role].join())"
                   @click="moveProject(record)"
@@ -369,6 +372,7 @@ const setIcon = async (icon: string, project: ProjectType) => {
                     {{ $t('general.move') }} {{ $t('objects.project') }}
                   </div>
                 </a-menu-item>
+                -->
                 <a-menu-item
                   v-if="isUIAllowed('projectDelete', true, [record.workspace_role, record.project_role].join())"
                   @click="deleteProject(record)"
diff --git a/packages/nc-gui/components/workspace/View.vue b/packages/nc-gui/components/workspace/View.vue
index 930c133757..63c6c59048 100644
--- a/packages/nc-gui/components/workspace/View.vue
+++ b/packages/nc-gui/components/workspace/View.vue
@@ -10,8 +10,6 @@ const workspaceStore = useWorkspace()
 const { isWorkspaceOwnerOrCreator, isWorkspaceOwner, activeWorkspace, workspaces } = storeToRefs(workspaceStore)
 const { loadCollaborators } = workspaceStore
 
-const { appInfo } = useGlobal()
-
 const tab = computed({
   get() {
     return route.value.query?.tab ?? 'collaborators'
diff --git a/packages/nc-gui/pages/index/[typeOrId]/[projectId]/index/index.vue b/packages/nc-gui/pages/index/[typeOrId]/[projectId]/index/index.vue
index cc4701d95e..9ef8968e87 100644
--- a/packages/nc-gui/pages/index/[typeOrId]/[projectId]/index/index.vue
+++ b/packages/nc-gui/pages/index/[typeOrId]/[projectId]/index/index.vue
@@ -9,10 +9,6 @@ useProjectsShortcuts()
 provide(TabMetaInj, activeTab)
 
 useSidebar('nc-left-sidebar')
-
-const router = useRouter()
-
-const route = router.currentRoute
 </script>
 
 <template>
diff --git a/packages/nc-gui/pages/index/[typeOrId]/[projectId]/index/index/[viewId]/[[viewTitle]]/[...slugs].vue b/packages/nc-gui/pages/index/[typeOrId]/[projectId]/index/index/[viewId]/[[viewTitle]]/[...slugs].vue
index cc340bc4c9..34bc188cf7 100644
--- a/packages/nc-gui/pages/index/[typeOrId]/[projectId]/index/index/[viewId]/[[viewTitle]]/[...slugs].vue
+++ b/packages/nc-gui/pages/index/[typeOrId]/[projectId]/index/index/[viewId]/[[viewTitle]]/[...slugs].vue
@@ -1 +1 @@
-<template></template>
+<template><span /></template>
diff --git a/packages/nc-gui/utils/iconUtils.ts b/packages/nc-gui/utils/iconUtils.ts
index 447e9b8fcb..8360e8c836 100644
--- a/packages/nc-gui/utils/iconUtils.ts
+++ b/packages/nc-gui/utils/iconUtils.ts
@@ -32,25 +32,19 @@ import MaterialSymbolsWarningOutlineRounded from '~icons/material-symbols/warnin
 import MaterialSymbolsDragIndicator from '~icons/ri/draggable'
 import NcSearch from '~icons/nc-icons/search'
 import NcCreditCard from '~icons/nc-icons/credit-card'
-
 import NcLayers from '~icons/nc-icons/layers'
 import NcUsers from '~icons/nc-icons/users'
 import NcCheck from '~icons/nc-icons/check'
 import PlusSquare from '~icons/nc-icons/plus-square'
-
 import PhLayout from '~icons/ph/layout'
-import Copy from '~icons/material-symbols/content-copy-outline'
 import Delete from '~icons/material-symbols/delete-outline-rounded'
 import CiFilter from '~icons/mdi/filter-outline'
-import Plus from '~icons/material-symbols/add-rounded'
 import Minus from '~icons/material-symbols/remove-rounded'
 import Code from '~icons/material-symbols/code-rounded'
 import Palette from '~icons/material-symbols/palette-outline'
-import Erd from '~icons/material-symbols/account-tree-outline-rounded'
 import MsSync from '~icons/material-symbols/sync-rounded'
 import MdiRefresh from '~icons/mdi/refresh'
 import ApiSnippet from '~icons/material-symbols/settings-ethernet-rounded'
-import MdiSettings from '~icons/mdi/cog-outline'
 import Phishing from '~icons/material-symbols/phishing-outline-rounded'
 import MdiAccountGroup from '~icons/mdi/account-group'
 import MdiDotsVertical from '~icons/mdi/dots-vertical'
@@ -70,7 +64,6 @@ import NcIconsRowHeightExtraTall from '~icons/nc-icons/row-height-extra-tall'
 import MsInfo from '~icons/material-symbols/info-outline-rounded'
 import PhSparkleFill from '~icons/ph/sparkle-fill'
 import NcArticle from '~icons/nc-icons/article'
-
 import MsDatabase from '~icons/mdi/database-outline'
 import MdiDatabaseSearch from '~icons/mdi/database-search'
 import MdiMagicStaff from '~icons/mdi/magic-staff'

From 7bdbc7975462b784c06cf6b667d0d607e75ab9dc Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Wed, 6 Sep 2023 17:26:12 +0300
Subject: [PATCH 2/4] chore(nocodb): lint error and warnings

Signed-off-by: mertmit <mertmit99@gmail.com>
---
 packages/nocodb/src/Noco.ts                | 2 --
 packages/nocodb/src/db/BaseModelSqlv2.ts   | 2 +-
 packages/nocodb/src/interface/XcMetaMgr.ts | 1 +
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/packages/nocodb/src/Noco.ts b/packages/nocodb/src/Noco.ts
index 7d91334bc6..a1cf38c6f9 100644
--- a/packages/nocodb/src/Noco.ts
+++ b/packages/nocodb/src/Noco.ts
@@ -18,8 +18,6 @@ import type { Express } from 'express';
 
 import type http from 'http';
 import { MetaTable } from '~/utils/globals';
-import Store from '~/models/Store';
-import { NC_LICENSE_KEY } from '~/constants';
 import { AppModule } from '~/app.module';
 import { isEE } from '~/utils';
 
diff --git a/packages/nocodb/src/db/BaseModelSqlv2.ts b/packages/nocodb/src/db/BaseModelSqlv2.ts
index b8c5350c7d..eff4594b6f 100644
--- a/packages/nocodb/src/db/BaseModelSqlv2.ts
+++ b/packages/nocodb/src/db/BaseModelSqlv2.ts
@@ -2176,7 +2176,7 @@ class BaseModelSqlv2 {
     return res;
   }
 
-  async updateByPk(id, data, trx?, cookie?, disableOptimization = false) {
+  async updateByPk(id, data, trx?, cookie?, _disableOptimization = false) {
     try {
       const updateObj = await this.model.mapAliasToColumn(
         data,
diff --git a/packages/nocodb/src/interface/XcMetaMgr.ts b/packages/nocodb/src/interface/XcMetaMgr.ts
index 1a2f847f80..94d938a5a8 100644
--- a/packages/nocodb/src/interface/XcMetaMgr.ts
+++ b/packages/nocodb/src/interface/XcMetaMgr.ts
@@ -1 +1,2 @@
+// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export default interface XcMetaMgr {}

From ad920891a1184d4de8e405f3b41f168357ef7a48 Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Wed, 6 Sep 2023 17:50:57 +0300
Subject: [PATCH 3/4] chore: get rid of unused parts without explanation

Signed-off-by: mertmit <mertmit99@gmail.com>
---
 .../components/cell/attachment/utils.ts       |  2 -
 .../dashboard/TreeView/BaseOptions.vue        | 61 -------------------
 .../nc-gui/components/dlg/TableCreate.vue     | 20 ------
 .../nc-gui/components/general/DeleteModal.vue |  7 ---
 packages/nc-gui/components/project/View.vue   | 11 ----
 .../smartsheet/toolbar/ColumnFilterMenu.vue   |  2 -
 .../smartsheet/toolbar/GroupByMenu.vue        | 14 ++++-
 .../components/workspace/ProjectList.vue      |  7 ---
 8 files changed, 13 insertions(+), 111 deletions(-)

diff --git a/packages/nc-gui/components/cell/attachment/utils.ts b/packages/nc-gui/components/cell/attachment/utils.ts
index 7938e256b6..2cfceac17c 100644
--- a/packages/nc-gui/components/cell/attachment/utils.ts
+++ b/packages/nc-gui/components/cell/attachment/utils.ts
@@ -33,8 +33,6 @@ export const [useProvideAttachmentCell, useAttachmentCell] = useInjectionState(
   (updateModelValue: (data: string | Record<string, any>[]) => void) => {
     const isReadonly = inject(ReadonlyInj, ref(false))
 
-    // const isLockedMode = inject(IsLockedInj, ref(false))
-
     const isPublic = inject(IsPublicInj, ref(false))
 
     const isForm = inject(IsFormInj, ref(false))
diff --git a/packages/nc-gui/components/dashboard/TreeView/BaseOptions.vue b/packages/nc-gui/components/dashboard/TreeView/BaseOptions.vue
index 4991507861..0dc681a9de 100644
--- a/packages/nc-gui/components/dashboard/TreeView/BaseOptions.vue
+++ b/packages/nc-gui/components/dashboard/TreeView/BaseOptions.vue
@@ -114,65 +114,4 @@ function openQuickImportDialog(type: string) {
       </div>
     </a-menu-item>
   </a-sub-menu>
-
-  <!-- Connect to new datasource -->
-  <!-- <a-menu-divider v-if="false" class="my-0" />
-  <a-sub-menu>
-    <template #title>
-      <div class="nc-project-menu-item group">
-        <GeneralIcon icon="datasource" class="group-hover:text-black" />
-        Connect to new datasource
-        <div class="flex-1" />
-
-        <MaterialSymbolsChevronRightRounded class="transform group-hover:(scale-115 text-accent) text-xl text-gray-400" />
-      </div>
-    </template>
-
-    <template #expandIcon></template>
-    <a-menu-item key="connect-new-source" @click="toggleDialog(true, 'dataSources', ClientType.MYSQL, project.id)">
-      <div class="color-transition nc-project-menu-item group">
-        <LogosMysqlIcon class="group-hover:text-black" />
-        MySQL
-      </div>
-    </a-menu-item>
-    <a-menu-item key="connect-new-source" @click="toggleDialog(true, 'dataSources', ClientType.PG, project.id)">
-      <div class="color-transition nc-project-menu-item group">
-        <LogosPostgresql class="group-hover:text-black" />
-        Postgres
-      </div>
-    </a-menu-item>
-    <a-menu-item key="connect-new-source" @click="toggleDialog(true, 'dataSources', ClientType.SQLITE, project.id)">
-      <div class="color-transition nc-project-menu-item group">
-        <VscodeIconsFileTypeSqlite class="group-hover:text-black" />
-        SQLite
-      </div>
-    </a-menu-item>
-    <a-menu-item key="connect-new-source" @click="toggleDialog(true, 'dataSources', ClientType.MSSQL, project.id)">
-      <div class="color-transition nc-project-menu-item group">
-        <SimpleIconsMicrosoftsqlserver class="group-hover:text-black" />
-        MSSQL
-      </div>
-    </a-menu-item>
-    <a-menu-item
-      v-if="appInfo.ee"
-      key="connect-new-source"
-      @click="toggleDialog(true, 'dataSources', ClientType.SNOWFLAKE, project.id)"
-    >
-      <div class="color-transition nc-project-menu-item group">
-        <LogosSnowflakeIcon class="group-hover:text-black" />
-        Snowflake
-      </div>
-    </a-menu-item>
-    <a-menu-item v-if="isUIAllowed('importRequest', false, projectRole)" key="add-new-table" class="py-1 rounded-b">
-      <a
-        v-e="['e:datasource:import-request']"
-        href="https://github.com/nocodb/nocodb/issues/2052"
-        target="_blank"
-        class="prose-sm hover:(!text-primary !opacity-100) color-transition nc-project-menu-item group after:(!rounded-b)"
-      >
-        <GeneralIcon icon="openInNew" class="group-hover:text-black" />
-        {{ $t('labels.requestDataSource') }}
-      </a>
-    </a-menu-item>
-  </a-sub-menu> -->
 </template>
diff --git a/packages/nc-gui/components/dlg/TableCreate.vue b/packages/nc-gui/components/dlg/TableCreate.vue
index 45011775fa..0c69aadd0c 100644
--- a/packages/nc-gui/components/dlg/TableCreate.vue
+++ b/packages/nc-gui/components/dlg/TableCreate.vue
@@ -152,27 +152,7 @@ onMounted(() => {
             :placeholder="$t('msg.info.enterTableName')"
           />
         </a-form-item>
-        <!--
-        <div v-if="false" class="flex justify-end items-center">
-          <div
-            class="pointer flex flex-row items-center gap-x-1 cursor-pointer"
-            @click="isAdvanceOptVisible = !isAdvanceOptVisible"
-          >
-            {{ isAdvanceOptVisible ? $t('general.hideAll') : $t('general.showMore') }}
-
-            <component :is="iconMap.minusCircle" v-if="isAdvanceOptVisible" class="text-gray-500" />
-            <component :is="iconMap.plusCircle" v-else class="text-gray-500" />
-          </div>
-        </div>
-        -->
         <div class="nc-table-advanced-options" :class="{ active: isAdvanceOptVisible }">
-          <!-- hint="Table name as saved in database" -->
-          <!-- <div v-if="!project.prefix" class="mb-2">{{ $t('msg.info.tableNameInDb') }}</div>
-
-          <a-form-item v-if="!project.prefix" v-bind="validateInfos.table_name">
-            <a-input v-model:value="table.table_name" size="large" hide-details :placeholder="$t('msg.info.tableNameInDb')" />
-          </a-form-item> -->
-
           <div>
             <div class="mb-1">
               <!-- Add Default Columns -->
diff --git a/packages/nc-gui/components/general/DeleteModal.vue b/packages/nc-gui/components/general/DeleteModal.vue
index 62de49a4e2..61eaed3145 100644
--- a/packages/nc-gui/components/general/DeleteModal.vue
+++ b/packages/nc-gui/components/general/DeleteModal.vue
@@ -52,13 +52,6 @@ onKeyStroke('Enter', () => {
 
       <slot name="entity-preview"></slot>
 
-      <!--
-      <div v-if="false" class="flex flex-row items-center py-2 px-3 border-1 border-gray-100 rounded-lg text-gray-700">
-        <GeneralIcon icon="warning" class="text-orange-500"></GeneralIcon>
-        <div class="pl-2.5 text-gray-500">This action cannot be undone</div>
-      </div>
-      -->
-
       <div class="flex flex-row gap-x-2 mt-2.5 pt-2.5 justify-end">
         <NcButton type="secondary" @click="visible = false">
           {{ $t('general.cancel') }}
diff --git a/packages/nc-gui/components/project/View.vue b/packages/nc-gui/components/project/View.vue
index c32e2694a9..2542871b55 100644
--- a/packages/nc-gui/components/project/View.vue
+++ b/packages/nc-gui/components/project/View.vue
@@ -115,17 +115,6 @@ watch(
           </template>
           <DashboardSettingsDataSources v-model:state="baseSettingsState" />
         </a-tab-pane>
-        <!--
-        <a-tab-pane v-if="false && isUIAllowed('acl')" key="ui-acl">
-          <template #tab>
-            <div class="tab-title" data-testid="proj-view-tab__ui-acl">
-              <GeneralIcon icon="acl" />
-              <div>{{ $t('title.uiACL') }}</div>
-            </div>
-          </template>
-          <DashboardSettingsUIAclTabs class="mt-6" />
-        </a-tab-pane>
-        -->
       </a-tabs>
     </div>
   </div>
diff --git a/packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
index 16368b3395..16f19617c3 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/ColumnFilterMenu.vue
@@ -19,8 +19,6 @@ const isLocked = inject(IsLockedInj, ref(false))
 
 const activeView = inject(ActiveViewInj, ref())
 
-// const isPublic = inject(IsPublicInj, ref(false))
-
 const { filterAutoSave, isMobileMode } = useGlobal()
 
 const filterComp = ref<typeof ColumnFilter>()
diff --git a/packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue
index 73cd5b9ea6..be838bfe15 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/GroupByMenu.vue
@@ -10,6 +10,7 @@ import {
   inject,
   ref,
   useMenuCloseOnEsc,
+  useNuxtApp,
   useSmartsheetStoreOrThrow,
 } from '#imports'
 
@@ -28,6 +29,8 @@ const isLocked = inject(IsLockedInj, ref(false))
 
 const { gridViewCols, updateGridViewColumn } = useGridViewColumnOrThrow()
 
+const { $e } = useNuxtApp()
+
 const _groupBy = ref<{ fk_column_id?: string; sort: string; order: number }[]>([])
 
 const groupBy = computed<{ fk_column_id?: string; sort: string; order: number }[]>(() => {
@@ -106,6 +109,8 @@ const saveGroupBy = async () => {
         }
       }
 
+      $e('a:group-by:update', { groupBy: groupBy.value })
+
       eventBus.emit(SmartsheetStoreEvents.GROUP_BY_RELOAD)
     } catch (e) {
       message.error('There was an error while updating view!')
@@ -200,7 +205,13 @@ watch(open, () => {
             </NcSelect>
 
             <a-tooltip placement="right" title="Remove">
-              <NcButton class="nc-group-by-item-remove-btn" size="small" type="text" @click.stop="removeFieldFromGroupBy(i)">
+              <NcButton
+                v-e="['c:group-by:remove']"
+                class="nc-group-by-item-remove-btn"
+                size="small"
+                type="text"
+                @click.stop="removeFieldFromGroupBy(i)"
+              >
                 <GeneralIcon icon="delete" class="" />
               </NcButton>
             </a-tooltip>
@@ -208,6 +219,7 @@ watch(open, () => {
         </div>
         <NcButton
           v-if="fieldsToGroupBy.length > _groupBy.length && _groupBy.length < 3"
+          v-e="['c:group-by:add']"
           class="nc-add-group-btn"
           style="width: fit-content"
           size="small"
diff --git a/packages/nc-gui/components/workspace/ProjectList.vue b/packages/nc-gui/components/workspace/ProjectList.vue
index ff2b4a8ac5..68fc35090a 100644
--- a/packages/nc-gui/components/workspace/ProjectList.vue
+++ b/packages/nc-gui/components/workspace/ProjectList.vue
@@ -139,13 +139,6 @@ const workspaceMoveProjectOnSuccess = async (workspaceId: string) => {
   })
 }
 
-/*
-const moveProject = (project: ProjectType) => {
-  selectedProjectToMove.value = project
-  isMoveDlgOpen.value = true
-}
-*/
-
 const isDuplicateDlgOpen = ref(false)
 const selectedProjectToDuplicate = ref()
 

From a6a27d73e23ff8fdb38f2cb135f799924114d52e Mon Sep 17 00:00:00 2001
From: mertmit <mertmit99@gmail.com>
Date: Tue, 12 Sep 2023 15:31:43 +0300
Subject: [PATCH 4/4] chore: lint errors

Signed-off-by: mertmit <mertmit99@gmail.com>
---
 packages/nc-gui/components/cell/TextArea.vue       | 14 +++++++-------
 .../components/smartsheet/toolbar/FieldsMenu.vue   |  2 +-
 .../src/db/formulav2/formulaQueryBuilderv2.ts      |  2 +-
 packages/nocodb/src/interface/XcMetaMgr.ts         |  1 -
 packages/nocodb/src/plugins/discord/Discord.ts     |  2 +-
 .../nocodb/src/plugins/mattermost/Mattermost.ts    |  2 +-
 packages/nocodb/src/plugins/slack/Slack.ts         |  2 +-
 packages/nocodb/src/plugins/teams/Teams.ts         |  2 +-
 packages/nocodb/src/plugins/twilio/Twilio.ts       |  2 +-
 .../src/plugins/twilioWhatsapp/TwilioWhatsapp.ts   |  2 +-
 .../services/api-docs/swagger/templates/params.ts  |  2 +-
 .../services/api-docs/swagger/templates/paths.ts   |  2 +-
 packages/nocodb/src/services/tables.service.ts     |  8 +++++++-
 13 files changed, 24 insertions(+), 19 deletions(-)

diff --git a/packages/nc-gui/components/cell/TextArea.vue b/packages/nc-gui/components/cell/TextArea.vue
index 0e9ed08bc6..5661aa09a4 100644
--- a/packages/nc-gui/components/cell/TextArea.vue
+++ b/packages/nc-gui/components/cell/TextArea.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import type { VNodeRef } from '@vue/runtime-core'
-import { EditModeInj, IsExpandedFormOpenInj, RowHeightInj, inject, useVModel, iconMap, ActiveCellInj } from '#imports'
+import { ActiveCellInj, EditModeInj, IsExpandedFormOpenInj, RowHeightInj, iconMap, inject, useVModel } from '#imports'
 
 const props = defineProps<{
   modelValue?: string | number
@@ -91,16 +91,16 @@ onClickOutside(inputWrapperRef, (e) => {
       <div
         v-if="active"
         class="!absolute right-0 bottom-0 h-6 w-5 group cursor-pointer flex justify-end gap-1 items-center active:(ring ring-accent ring-opacity-100) rounded border-none p-1 hover:(bg-primary bg-opacity-10) dark:(!bg-slate-500)"
-        :class="{'right-2 bottom-2':editEnabled}"
+        :class="{ 'right-2 bottom-2': editEnabled }"
         data-testid="attachment-cell-file-picker-button"
         @click.stop="isVisible = !isVisible"
       >
         <NcTooltip placement="bottom">
-            <template #title>Expand</template>
-            <component
-              :is="iconMap.expand"
-              class="transform dark:(!text-white) group-hover:(!text-grey-800 scale-120) text-gray-500 text-xs"
-            />
+          <template #title>Expand</template>
+          <component
+            :is="iconMap.expand"
+            class="transform dark:(!text-white) group-hover:(!text-grey-800 scale-120) text-gray-500 text-xs"
+          />
         </NcTooltip>
       </div>
     </div>
diff --git a/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue b/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
index 6008b7fe98..811cd95de1 100644
--- a/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
+++ b/packages/nc-gui/components/smartsheet/toolbar/FieldsMenu.vue
@@ -378,7 +378,7 @@ useMenuCloseOnEsc(open)
                       <span class="mt-0.65">{{ field.title }}</span>
                     </div>
 
-                    <NcSwitch :checked="field.show" v-e="['a:fields:show-hide']" :disabled="field.isViewEssentialField" />
+                    <NcSwitch v-e="['a:fields:show-hide']" :checked="field.show" :disabled="field.isViewEssentialField" />
                   </div>
 
                   <div class="flex-1" />
diff --git a/packages/nocodb/src/db/formulav2/formulaQueryBuilderv2.ts b/packages/nocodb/src/db/formulav2/formulaQueryBuilderv2.ts
index e53fd4b929..8057345b48 100644
--- a/packages/nocodb/src/db/formulav2/formulaQueryBuilderv2.ts
+++ b/packages/nocodb/src/db/formulav2/formulaQueryBuilderv2.ts
@@ -768,7 +768,7 @@ async function _formulaQueryBuilder(
     } else if (pt.type === 'Literal') {
       return { builder: knex.raw(`?${colAlias}`, [pt.value]) };
     } else if (pt.type === 'Identifier') {
-      const { builder } = await aliasToColumn?.[pt.name]?.();
+      const { builder } = (await aliasToColumn?.[pt.name]?.()) || {};
       if (typeof builder === 'function') {
         return { builder: knex.raw(`??${colAlias}`, builder(pt.fnName)) };
       }
diff --git a/packages/nocodb/src/interface/XcMetaMgr.ts b/packages/nocodb/src/interface/XcMetaMgr.ts
index 94d938a5a8..1a2f847f80 100644
--- a/packages/nocodb/src/interface/XcMetaMgr.ts
+++ b/packages/nocodb/src/interface/XcMetaMgr.ts
@@ -1,2 +1 @@
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export default interface XcMetaMgr {}
diff --git a/packages/nocodb/src/plugins/discord/Discord.ts b/packages/nocodb/src/plugins/discord/Discord.ts
index a83f522503..69bb697982 100644
--- a/packages/nocodb/src/plugins/discord/Discord.ts
+++ b/packages/nocodb/src/plugins/discord/Discord.ts
@@ -7,7 +7,7 @@ export default class Discord implements IWebhookNotificationAdapter {
   }
 
   public async sendMessage(content: string, payload: any): Promise<any> {
-    for (const { webhook_url } of payload?.channels) {
+    for (const { webhook_url } of payload?.channels || []) {
       try {
         return await axios.post(webhook_url, {
           content,
diff --git a/packages/nocodb/src/plugins/mattermost/Mattermost.ts b/packages/nocodb/src/plugins/mattermost/Mattermost.ts
index 65bfa902b7..a52eed44a7 100644
--- a/packages/nocodb/src/plugins/mattermost/Mattermost.ts
+++ b/packages/nocodb/src/plugins/mattermost/Mattermost.ts
@@ -7,7 +7,7 @@ export default class Mattermost implements IWebhookNotificationAdapter {
   }
 
   public async sendMessage(text: string, payload: any): Promise<any> {
-    for (const { webhook_url } of payload?.channels) {
+    for (const { webhook_url } of payload?.channels || []) {
       try {
         return await axios.post(webhook_url, {
           text,
diff --git a/packages/nocodb/src/plugins/slack/Slack.ts b/packages/nocodb/src/plugins/slack/Slack.ts
index 2e2ebcf0dc..e9f6f0ba71 100644
--- a/packages/nocodb/src/plugins/slack/Slack.ts
+++ b/packages/nocodb/src/plugins/slack/Slack.ts
@@ -7,7 +7,7 @@ export default class Slack implements IWebhookNotificationAdapter {
   }
 
   public async sendMessage(text: string, payload: any): Promise<any> {
-    for (const { webhook_url } of payload?.channels) {
+    for (const { webhook_url } of payload?.channels || []) {
       try {
         return await axios.post(webhook_url, {
           text,
diff --git a/packages/nocodb/src/plugins/teams/Teams.ts b/packages/nocodb/src/plugins/teams/Teams.ts
index 868d7d5aa2..64940393c2 100644
--- a/packages/nocodb/src/plugins/teams/Teams.ts
+++ b/packages/nocodb/src/plugins/teams/Teams.ts
@@ -7,7 +7,7 @@ export default class Teams implements IWebhookNotificationAdapter {
   }
 
   public async sendMessage(Text: string, payload: any): Promise<any> {
-    for (const { webhook_url } of payload?.channels) {
+    for (const { webhook_url } of payload?.channels || []) {
       try {
         return await axios.post(webhook_url, {
           Text,
diff --git a/packages/nocodb/src/plugins/twilio/Twilio.ts b/packages/nocodb/src/plugins/twilio/Twilio.ts
index fcbbbc7dcd..07dbfc2471 100644
--- a/packages/nocodb/src/plugins/twilio/Twilio.ts
+++ b/packages/nocodb/src/plugins/twilio/Twilio.ts
@@ -14,7 +14,7 @@ export default class Twilio implements IWebhookNotificationAdapter {
   }
 
   public async sendMessage(content: string, payload: any): Promise<any> {
-    for (const num of payload?.to?.split(/\s*?,\s*?/)) {
+    for (const num of payload?.to?.split(/\s*?,\s*?/) || []) {
       try {
         await this.client.messages.create({
           body: content,
diff --git a/packages/nocodb/src/plugins/twilioWhatsapp/TwilioWhatsapp.ts b/packages/nocodb/src/plugins/twilioWhatsapp/TwilioWhatsapp.ts
index be5290580f..028dfd9172 100644
--- a/packages/nocodb/src/plugins/twilioWhatsapp/TwilioWhatsapp.ts
+++ b/packages/nocodb/src/plugins/twilioWhatsapp/TwilioWhatsapp.ts
@@ -14,7 +14,7 @@ export default class TwilioWhatsapp implements IWebhookNotificationAdapter {
   }
 
   public async sendMessage(content: string, payload: any): Promise<any> {
-    for (const num of payload?.to?.split(/\s*?,\s*?/)) {
+    for (const num of payload?.to?.split(/\s*?,\s*?/) || []) {
       try {
         await this.client.messages.create({
           body: content,
diff --git a/packages/nocodb/src/services/api-docs/swagger/templates/params.ts b/packages/nocodb/src/services/api-docs/swagger/templates/params.ts
index b0d980b1f7..80701928fe 100644
--- a/packages/nocodb/src/services/api-docs/swagger/templates/params.ts
+++ b/packages/nocodb/src/services/api-docs/swagger/templates/params.ts
@@ -1,4 +1,4 @@
-import { isLinksOrLTAR, RelationTypes, UITypes } from 'nocodb-sdk'
+import { isLinksOrLTAR, RelationTypes, UITypes } from 'nocodb-sdk';
 import type { LinkToAnotherRecordColumn } from '~/models';
 import type { SwaggerColumn } from '../getSwaggerColumnMetas';
 
diff --git a/packages/nocodb/src/services/api-docs/swagger/templates/paths.ts b/packages/nocodb/src/services/api-docs/swagger/templates/paths.ts
index 9d68bf01bb..cbd7162fa1 100644
--- a/packages/nocodb/src/services/api-docs/swagger/templates/paths.ts
+++ b/packages/nocodb/src/services/api-docs/swagger/templates/paths.ts
@@ -1,4 +1,4 @@
-import { isLinksOrLTAR, ModelTypes, UITypes } from 'nocodb-sdk';
+import { isLinksOrLTAR, ModelTypes } from 'nocodb-sdk';
 import {
   columnNameParam,
   columnNameQueryParam,
diff --git a/packages/nocodb/src/services/tables.service.ts b/packages/nocodb/src/services/tables.service.ts
index f4a5250edd..e0a02df51b 100644
--- a/packages/nocodb/src/services/tables.service.ts
+++ b/packages/nocodb/src/services/tables.service.ts
@@ -1,6 +1,12 @@
 import { Injectable } from '@nestjs/common';
 import DOMPurify from 'isomorphic-dompurify';
-import { isLinksOrLTAR, isVirtualCol, ModelTypes, ProjectRoles, UITypes } from 'nocodb-sdk'
+import {
+  isLinksOrLTAR,
+  isVirtualCol,
+  ModelTypes,
+  ProjectRoles,
+  UITypes,
+} from 'nocodb-sdk';
 import { AppEvents } from 'nocodb-sdk';
 import { MetaDiffsService } from './meta-diffs.service';
 import { ColumnsService } from './columns.service';