Browse Source

refactor: coderabbit review comments

pull/9499/head
Pranav C 2 months ago
parent
commit
0195549af1
  1. 2
      packages/nc-secret-mgr/src/core/SecretManager.ts
  2. 3
      packages/noco-docs/docs/100.data-sources/050.updating-secret.md

2
packages/nc-secret-mgr/src/core/SecretManager.ts

@ -130,7 +130,7 @@ export class SecretManager {
await transaction.commit();
} catch (e) {
console.log(e);
logger.error('Failed to decrypt integration configuration: ' + e.message);
await transaction.rollback();
throw e;
}

3
packages/noco-docs/docs/100.data-sources/050.updating-secret.md

@ -49,7 +49,8 @@ Alternatively, you can use the `nc-secret-mgr` executable to update secrets.
3. After running the command, the secret will be updated in NocoDB.
Note: All environment variables are supported, including `NC_DB`, `NC_DB_JSON`, `NC_DB_JSON_FILE`, `DATABASE_URL`, and `DATABASE_URL_FILE`. You can use any of these variables to specify your database connection. Alternately you can use following equivalent parameters.
Note: All environment variables are supported, including `NC_DB`, `NC_DB_JSON`, `NC_DB_JSON_FILE`, `DATABASE_URL`, and `DATABASE_URL_FILE`. You can use any of these variables to specify your database connection. Alternatively, you can use the following equivalent parameters.
| Environment Variable | CLI Parameter |
| --------------------- | -------------- |

Loading…
Cancel
Save