41baa7a791
Partially revert c0ad77d8 "Enhance Eclipse save actions"
...
Do not automatically organize imports using a save action since this
seems to be buggy and removed some annotations org.eclipse.jgit.pgm
needs to use args4j.
Change-Id: I5a91292c3b9241ce2dde3e4ecce14ad460097129
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
9906f09868
Partially revert c0ad77d8 "Enhance Eclipse save actions"
...
Revert the following save actions which were introduced in c0ad77d8:
- always use braces around blocks
- remove unused imports
Other than I expected save actions are run globally on edited files -
and not only on edited code lines only.
Hence revert the save action "Convert control statement bodies to
blocks" which would affect a large number of code lines not affected by
the change editing some small part of a class. This would generate a
large number of changes which may lead to many unnecessary conflicts.
Total number of affected lines across jgit would be around 10k lines.
Also revert "Remove unused imports" since it erroneously removes imports
of some annotations needed by pgm classes using args4j.
Change-Id: I879a47f68e664129e6124cf25c1ae1f6a2d7a5aa
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
c0ad77d84c
Enhance Eclipse save actions
...
Add the following Eclipse save actions executed when saving modified
lines. This should help to reduce manual work needed to maintain a clean
and consistent code style:
- organize imports
- always use braces around blocks
- add missing annotations
- @Override including implementation of interface methods
- @Deprecated
- remove
- unused imports
- unnecessary $NON-NLS$ tags
- redundant type arguments
Also add default values for new settings that were introduced in recent
Eclipse versions up to Neon since we updated save rules the last time.
Change-Id: Idc90b249df044d0552f04edf01a5f607c4846f50
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
7922f31fa3
Prepare 4.8.1-SNAPSHOT builds
...
Change-Id: I7ca4186bbfe5ccc3fed4509a1fe4fc47bb2e8c50
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
03b8d1a202
JGit v4.8.0.201706111038-r
...
Change-Id: Ie33623a2191ffffc2ca5756fd078a7003c0c660f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
8afd9b1648
Prepare 4.7.2-SNAPSHOT builds
...
Change-Id: I7c127bd402cd84c68d8f33a32c6aad093a2264c8
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
1d14296975
JGit v4.7.1.201706071930-r
...
Change-Id: I28cd8fbe995d76c8a00e7db6ddf826e983d89043
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
df9ce4b981
Prepare 4.9.0-SNAPSHOT builds
...
Change-Id: I52a4153d573799e861ab104939f51fac1aceb9ee
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
3254672fcd
Prepare 4.8.0-SNAPSHOT builds
...
Change-Id: I27fc4e4969fafde0fcba26aeebe30d732770b68f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
b7d49e6d3c
JGit v4.8.0.201705170830-rc1
...
Change-Id: I60c0a40f2e38748641b25a25bcf10346e2950886
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
3db0f507ee
Prepare 4.5.3-SNAPSHOT builds
...
Change-Id: I69681b7a5687ca76bd0dd5d3e7ce2cff841d0e32
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
c1d3ecbeab
JGit v4.5.2.201704071617-r
...
Change-Id: I66402643d7c84c90bf5cefed4d2ec3aa68c94cfb
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
6a311a071f
Prepare 4.7.1-SNAPSHOT
...
Change-Id: I16a45035258276217446bccc0ad1b0991383aa0c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
9f4c10784b
JGit v4.7.0.201704051617-r
...
Change-Id: Ic2bd6aca0b7a7e0597ffc1f7cf647b49878f9950
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
aec22e74cf
Prepare 4.8.0-SNAPSHOT builds
...
Change-Id: Ifea6750e79d417a8a2a891b3b5f96d68c7200011
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
11a12ceb0b
Prepare 4.5.2-SNAPSHOT builds
...
Change-Id: I8485de1f3f63dc9ec445b8fb08093ca144aedc59
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
a9a84b7235
JGit v4.5.1.201703201650-r
...
Change-Id: I88de7c9f52abbc4921a82208ed74d22aa19fb3cd
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
79f85d1cf2
Prepare 4.6.2-SNAPSHOT builds
...
Change-Id: I8835f79145e6a989787d47322c3d8cb9baf0624a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
258dc5a715
JGit v4.6.1.201703071140-r
...
Change-Id: I842dc95313e5b47b0b7ec983c4a0a91915ed4183
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
9af93f43cc
Remove unused imported package in org.eclipse.jgit.ant.test
...
Change-Id: Id8e31a4d7cc25c3b953c67674797dc575b65f6c5
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
8 years ago
3b4448637f
Enable and fix warnings about redundant specification of type arguments
...
Since the introduction of generic type parameter inference in Java 7,
it's not necessary to explicitly specify the type of generic parameters.
Enable the warning in Eclipse, and fix all occurrences.
Change-Id: I9158caf1beca5e4980b6240ac401f3868520aad0
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
8 years ago
43eb8511f5
Fix hamcrest dependency in org.eclipse.jgit.ant.test
...
Change-Id: I3361dce600698048b73a70cd991ad1a6b093e1da
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
8 years ago
7ac182f4e4
Enable and fix 'Should be tagged with @Override' warning
...
Set missingOverrideAnnotation=warning in Eclipse compiler preferences
which enables the warning:
The method <method> of type <type> should be tagged with @Override
since it actually overrides a superclass method
Justification for this warning is described in:
http://stackoverflow.com/a/94411/381622
Enabling this causes in excess of 1000 warnings across the entire
code-base. They are very easy to fix automatically with Eclipse's
"Quick Fix" tool.
Fix all of them except 2 which cause compilation failure when the
project is built with mvn; add TODO comments on those for further
investigation.
Change-Id: I5772061041fd361fe93137fd8b0ad356e748a29c
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
8 years ago
5fee071f6a
Prepare 4.7.0-SNAPSHOT builds
...
Change-Id: I20754d13007e6591d36aae5766f3a9a82b24e120
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
3857c3168f
Prepare 4.6.1-SNAPSHOT builds
...
Change-Id: I6b05a6f6c3f92365c272e1bdaf76093ca01f2d58
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
73a4325149
JGit v4.6.0.201612231935-r
...
Change-Id: Iaa88fe1b195dfe6be99a7b4cb064684e75563715
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
cb617e7ffc
Prepare 4.5.1-SNAPSHOT builds
...
Change-Id: I3305e8a09a3fb06f25a316cff2bdbb551d3ade68
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
e7142a3937
JGit v4.5.0.201609210915-r
...
Change-Id: Idc02a1a1d74f84605d764c239803f0cfbad94eb7
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
ab79ce91c1
Change JGit minimum execution environment to JavaSE-1.8
...
Bug: 500059
Change-Id: I47f3f6749a67da52029f84e002d9b155ed56d2b7
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
9d4ffcc1ab
Prepare 4.6.0-SNAPSHOT builds
...
Change-Id: Id2eafc331ee32c332c2a9b867b05c260beb0d10f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
8 years ago
4528d5f56d
Ignore 'The value of exception parameter is not used' warning
...
Change-Id: I50407e4a33e35b718ca40503fdd436f1f9f70fba
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
9 years ago
df479df176
JGit v4.4.1.201607150455-r
...
Change-Id: I61dbc29a962c8185fb356fe1ca30a1e673166d47
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
0900dc08f5
Prepare 4.4.1-SNAPSHOT builds
...
Change-Id: I4fe1c84b1418126f5b245b8a4f72bb7e37f48eae
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
399d2929ee
JGit v4.4.0.201606070830-r
...
Change-Id: I5c771a62ac0420424a655a4025c62a4bc28dc44e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
75b3301939
Prepare 4.5.0-SNAPSHOT builds
...
Change-Id: I572fe9fea0e5ca0bec4648c916ae95a5b1ccf125
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
831c811f61
Prepare 4.4.0-SNAPSHOT builds
...
Change-Id: Ib41dfe4103f013ba87a1ce62ee24bc9e10300eff
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
f3b8653021
JGit v4.4.0.201606011500-rc2
...
Change-Id: Ifd7b7baba7d676a630e2f742d369c4186ea450a6
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
9720f9e249
Prepare 4.4.0-SNAPSHOT builds
...
Change-Id: Iba6e423294d3315465648d19087a674a73b5ef28
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
f2c58503d7
JGit v4.4.0.201605250940-rc1
...
Change-Id: Idd8e1664730b979cfbd9a2196081a48a1efa3330
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
4641c43a98
Prepare 4.3.2-SNAPSHOT builds
...
Change-Id: I71997a8be83841765111cb7b55506bd8edd8adad
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
41b194c718
JGit v4.3.1.201605051710-r
...
Change-Id: I25fb72cc17d7a27b0b69746d907dac9ccd4d7997
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
b4c6a41adc
Prepare 4.4.0-SNAPSHOT builds
...
Change-Id: Ib95be1300b1b95cc7e8153170d509282bdc4e328
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
1447159b92
JGit v4.4.0.201605041135-m1
...
Change-Id: Ic9b6d7dae293887c3ac3a11f92e153501abad1dc
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
ccf8363693
Prepare 4.4.0-SNAPSHOT builds
...
Change-Id: If3162f4cc4ae6319b9f1e3293549485b039cfe7f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
ac5d1bc37b
Prepare 4.3.1-SNAPSHOT versions
...
Change-Id: I985828fd379e4596ae7f1c30a87e55df06a7924e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
f2ee537d55
Prepare 4.3.1-SNAPSHOT versions
...
Change-Id: I52c98ba8fb3a303269a1f9380af114b6dd8c5009
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
4f0daa3bb2
JGit v4.3.0.201604071810-r
...
Change-Id: I902cdf1ff92ce8c6e9d80c4965d8d5bd8b9ac6c1
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
57e6274bcf
JGit v4.3.0.201604071045-r
...
Change-Id: Iafab78d6be34d31a13f979b7be67611135c0f8bd
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
46bef2bcb6
Prepare 4.3-SNAPSHOT builds
...
Change-Id: Ib831f8870938113bd5338763f90a07d5c108b1de
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
bf32c9102f
JGit v4.3.0.201603230630-rc1
...
Change-Id: I10835e5aa3618e5033424595942cc1649152cb24
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
9 years ago
Matthias Sohn
David Pursehouse