Matthias Sohn
d726f0c1e0
Use try-with-resource to close resources in CommitCommand
...
Change-Id: Ibbbc74acfd050f28e68f318970660b5959caf7e3
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
bb2ca576ff
Externalize error message used in CheckoutCommand
...
Change-Id: Ifbc469b07e63218107157ffbf23ae55c52a55ef4
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
7343c7a10f
Use try-with-resource to close resources in CheckoutCommand
...
Change-Id: Ia4d4f9bff03a03d116b80022d7691df67bf8b51b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Shawn Pearce
f4ded63880
Merge "Fix resource leak in ChangeIdUtil"
10 years ago
Shawn Pearce
2b2cd4ba53
Merge changes I11631afb,Iaa51a46a
...
* changes:
Externalize error messages used in DfsGarbageCollector
Use try-with-resource to close resources in DfsGarbageCollector
10 years ago
Shawn Pearce
297600f7c2
Merge changes I8c06635c,I62d6de7d
...
* changes:
Silence non-externalized string warning in CherryPickCommand
Use try-with-resource to close resources in CherryPickCommand
10 years ago
Shawn Pearce
ba8b275ac5
Merge "Silence non-externalized string warnings in CherryPickResult"
10 years ago
Shawn Pearce
b2bba1419f
Merge "Use try-with-resource to close resources in CloneCommand"
10 years ago
Shawn Pearce
881dfc0147
Merge "Replace call to deprecated RevWalk.release() in DescribeCommand"
10 years ago
Shawn Pearce
15a95e3911
Merge "Use try-with-resource to close resources in DiffCommand"
10 years ago
Shawn Pearce
e0477d3fe0
Merge "Fix resource leak in DiffFormatter"
10 years ago
Shawn Pearce
f3a44db491
Merge "Use try-with-resource to close resources in DirCache"
10 years ago
Matthias Sohn
842ae868cf
Externalize error messages used in DfsGarbageCollector
...
Change-Id: I11631afb33a2bb29d994551a0be8775bbe277300
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
13cfc83b2b
Use try-with-resource to close resources in DfsGarbageCollector
...
Change-Id: Iaa51a46a9dde13d6f5c0f9ff54a68cea0ef1fde3
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Shawn Pearce
429e96eab6
Merge "Reduce visibility of DirCacheCheckout.checkValidPath()"
10 years ago
Shawn Pearce
ad1aa922de
Merge "Use try-with-resource to close resources in FetchProcess"
10 years ago
Shawn Pearce
a80adfbf9c
Merge "Use try-with-resource to close resources in GC"
10 years ago
Shawn Pearce
66a95621a3
Merge "Replace deprecated release() methods by close() in Merger"
10 years ago
Shawn Pearce
6e1dc98672
Merge "Ensure that NameRevCommand.call() closes RevWalk"
10 years ago
Shawn Pearce
754b855f73
Merge "Replace deprecated release() methods by close() in NoteMapMerger"
10 years ago
Shawn Pearce
67568ee630
Merge "Use try-with-resource to close resources in ObjectDatabase"
10 years ago
Shawn Pearce
aa94e3f3ae
Merge changes Ia3908555,I3bc26847
...
* changes:
Silence false null pointer access warnings in PackFile
Externalize error messages used in ObjectDirectoryInserter
10 years ago
Shawn Pearce
96a5ec43fa
Merge "Silence non-externalized string warning in PackIndexV2"
10 years ago
Shawn Pearce
9bea73693e
Merge changes I1a4181fc,Ic2db0511
...
* changes:
Silence non-externalized string warning in PackParser
Replace call to deprecated release() by close() in PackParser
10 years ago
Matthias Sohn
8d41c783c0
Silence non-externalized string warning in PackParser
...
Change-Id: I1a4181fc292c42157c69479f71c7674b2e00d2ce
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
e5a6290ac9
Replace call to deprecated release() by close() in PackParser
...
Change-Id: Ic2db051130059cce89486f55ecca32a7ce6715fd
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
6feb7bc9dd
Silence non-externalized string warning in PackIndexV2
...
Change-Id: I8c94811972c593c898f6375178f250a2123d01c6
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
4dd4d7e12a
Silence false null pointer access warnings in PackFile
...
Change-Id: Ia39085557b38840dfaa9b4995e6f6c40e19042cb
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
fc2d723dd9
Externalize error messages used in ObjectDirectoryInserter
...
Change-Id: I3bc26847071fbc31267a4a4cf5a10b428bcf229d
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
1728d1d760
Use try-with-resource to close resources in ObjectDatabase
...
Change-Id: Ib410bf0d3c300c25b615bb6a51488b3d88aeb3bd
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
f777ed1d24
Replace deprecated release() methods by close() in NoteMapMerger
...
Change-Id: Iaa76f0e853bb82cd7f231fd2f462a319f4196d8c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
f434f29fd9
Ensure that NameRevCommand.call() closes RevWalk
...
Change-Id: Icc35a81081759d664fe9e2b05e962ff3cd9aad92
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
8e332f1057
Replace deprecated release() methods by close() in Merger
...
Change-Id: I80ce98511a6e9048f1eea93288d6960dcbf3326f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
ed42bad1c6
Use try-with-resource to close resources in GC
...
Change-Id: I62a755a4ce839a252a5e80abf3f0d21243862376
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
2693d6075d
Use try-with-resource to close resources in FetchProcess
...
Change-Id: If489d530ca39ae279c8da848f870b561c38eac3c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Hector Oswaldo Caballero
cbb617603a
Clearer error message when service is not enabled
...
When a user tried to use a service not enabled in the remote server
a misleading error message was given:
fatal: remote error: Git access forbidden
This patch modifies the error message to make the cause clearer
to the user. Now, when the user tries to use a not enabled service,
the message error clearly states it:
fatal: remote error: Service not enabled
Change-Id: If096c4ddd17c5aae0e99e3ea6eea4b69bd3c5466
Signed-off-by: Hector Oswaldo Caballero <hector.caballero@ericsson.com>
10 years ago
Matthias Sohn
787ca168a9
Reduce visibility of DirCacheCheckout.checkValidPath()
...
This was deprecated and should only be used by DirCacheCheckout and
friends. Other classes should use SystemReader.checkPath() instead.
Change-Id: I37cf753b1f081602dee9f0f47979eff39d735f92
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
b84623ac64
Use try-with-resource to close resources in DirCache
...
Change-Id: I7dd3fd38784689816a1a8e9d8ccb499ae2138a8a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
ff0a7b719e
Fix resource leak in DiffFormatter
...
- close RevWalk allocated in scan()
- replace use of deprecated ObjectReader.release() method
Change-Id: I41b2b10a1a44270a6ceaa1741e996c0921439852
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
b8658e486c
Use try-with-resource to close resources in DiffCommand
...
Change-Id: I13d7c8bd0eb049aa69effd8b74384746226414cb
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
5f8308bdb9
Replace call to deprecated RevWalk.release() in DescribeCommand
...
Change-Id: Ie4bfdeb37d345d6ff1525a737f3b7653b2f8e23e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
4bae608e84
Use try-with-resource to close resources in CloneCommand
...
Change-Id: I9536bc208a5f3ec34f0a82fb565b4253be38e074
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
b53e2a99b3
Silence non-externalized string warnings in CherryPickResult
...
Change-Id: I515abbcb4319b744c5074de5a0c56caed13c2fb5
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
588965c6da
Silence non-externalized string warning in CherryPickCommand
...
Change-Id: I8c06635ce655470b5b650fa5c0c546e64445420c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
58c2c52219
Use try-with-resource to close resources in CherryPickCommand
...
Change-Id: I62d6de7d67c7de2460f4cbe918ad2bb8109650b9
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
3f79182081
Fix resource leak in ChangeIdUtil
...
Change-Id: I5cb3e9c7e167248697932933eef925c446514683
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
81c84c088f
Use try-with-resources to close walks in ArchiveCommand
...
Change-Id: I77120d77a12f1bab5c918a23b0e3eac90e320b2b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Shawn Pearce
d94ce9c754
Buffer overflow output stream
...
Most callers/users of TemporaryBuffer are sizing the in-memory
portion large enough that most outputs fit into RAM. With this
assumption they don't pay close attention to the size of IOs
being written, as it "should" just be a copy from one byte array
to another.
Overflow sets up a local file handle, which is costly to write to
for small IO units. Wrap the local file in a BufferedOutputStream
to combine small writes together. Larger writes can still bypass the
buffer as BOS automatically avoids copying for larger writes.
Change-Id: I09f4136dd65c48830cfda86d9101bc647581018a
10 years ago
Shawn Pearce
e4433e5e37
Fix overflow stream leak during merge conflicts
...
When reading back from an overflowed TemporaryBuffer the InputStream
must be closed to close the FileInputStream that is reading from
the backing file.
Change-Id: Id83d8f16f5b2c2618a9f841ec3508508455a6ae1
10 years ago
Shawn Pearce
6884ea24cd
Use local GIT_DIR for overflow during merge conflicts
...
By writing the temporary overflow merge result to $GIT_DIR JGit
can ensure the same filesystem permissions apply to protect the
file contents.
If no directory is available from the repository (e.g. DfsRepository)
null will be passed and the system temporary directory will be used
instead.
Change-Id: I95532aa092676d18f1dc1e3fdbe6dcb1f91b782e
10 years ago