Matthias Sohn
ffdacc2bbb
Delete deprecated class IgnoreRule
...
Was replaced by FastIgnoreRule in 3.6
Change-Id: Ia9c3d1231a5d97f3f5bddc81113954c9f9d8ee1e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
5362e1d41c
Delete deprecated checkoutEntry() methods in DirCacheCheckout
...
Change-Id: I7fcf6534e6092ba87360ccd68a7dd7466c5c8911
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Shawn Pearce
6e5c71b358
Remove validate support when reusing cached pack
...
Cached packs are only used when writing over the network or to
a bundle file and reuse validation is always disabled in these
two contexts. The client/consumer of the stream will be SHA-1
checksumming every object.
Reuse validation is most critical during local GC to avoid silently
ignoring corruption by stopping as soon as a problem is found and
leaving everything alone for the end-user to debug and salvage.
Cached packs are not supported during local GC as the bitmap rebuild
logic does not support including a cached pack in the result.
Strip out the validation and force PackWriter to always disable the
cached pack feature if reuseValidation is enabled.
Change-Id: If0d7baf2ae1bf1f7e71bf773151302c9f7887039
10 years ago
Shawn Pearce
a3476ced1f
Rename copyThroughCache to shouldCopyThroughCache
...
Sensible suggestion from Terry Parker as a late comment on
commit f2efcdc6f769d59722b17e9274932d585035cfb6.
Change-Id: I225775bfb6d3d91ae066ff00f9d80a9c02a422c2
10 years ago
Shawn Pearce
1553a6ff55
Add readAheadBuffer hint to ReadableChannel
...
This hint allows an underlying implementation to read more bytes when
possible and buffer them locally for future read calls to consume.
Change-Id: Ia986a1bb8640eecb91cfbd515c61fa1ff1574a6f
10 years ago
Shawn Pearce
c761c8bb5c
Avoid storing large packs in block cache during reuse
...
When a large pack (> 30% of the block cache) is being reused by
copying it pollutes the block cache with noise by storing blocks
that are never referenced again.
Avoid this by streaming the file directly from its channel onto
the output stream.
Change-Id: I2e53de27f3dcfb93de68b1fad45f75ab23e79fe7
10 years ago
David Pletcher
12e38d7275
Expose public getDepth method
...
The clone or fetch depth is a valuable bit of information
for access logging. Create a public getter to faciliate access.
A precondition check prevents unintentional misuse when the
data isn't valid yet.
Change-Id: I4603d5fd3bd4a767e3e2419b0f2da3664cfbd7f8
Signed-off-by: David Pletcher <dpletcher@google.com>
10 years ago
Matthias Sohn
41c4f9cb2a
Fix error message to include cause if ResetCommand fails
...
Bug: 464048
Change-Id: I6e7d9262b94cb168c84faef1dea22c1e082fe5ad
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Christian Halstrick
510aed1493
Revert "ResolveMerge only needs to visit differing TreeEntries"
...
This reverts commit bda5e76420
. This reduces
performance at least for non-bare repositories.
Change-Id: Ib26cf8372f210798e104112edf14e91bfeaf23ec
10 years ago
Matthias Sohn
017032c465
Fix IllegalArgumentException in AmazonS3
...
JGit hit IllegalArgumentException: invalid content length
when pushing large packs to S3.
Bug: 463015
Change-Id: Iddf50d90c7e3ccb15b9ff71233338c6b204b3648
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
d726f0c1e0
Use try-with-resource to close resources in CommitCommand
...
Change-Id: Ibbbc74acfd050f28e68f318970660b5959caf7e3
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
bb2ca576ff
Externalize error message used in CheckoutCommand
...
Change-Id: Ifbc469b07e63218107157ffbf23ae55c52a55ef4
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
7343c7a10f
Use try-with-resource to close resources in CheckoutCommand
...
Change-Id: Ia4d4f9bff03a03d116b80022d7691df67bf8b51b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
842ae868cf
Externalize error messages used in DfsGarbageCollector
...
Change-Id: I11631afb33a2bb29d994551a0be8775bbe277300
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
13cfc83b2b
Use try-with-resource to close resources in DfsGarbageCollector
...
Change-Id: Iaa51a46a9dde13d6f5c0f9ff54a68cea0ef1fde3
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
8d41c783c0
Silence non-externalized string warning in PackParser
...
Change-Id: I1a4181fc292c42157c69479f71c7674b2e00d2ce
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
e5a6290ac9
Replace call to deprecated release() by close() in PackParser
...
Change-Id: Ic2db051130059cce89486f55ecca32a7ce6715fd
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
6feb7bc9dd
Silence non-externalized string warning in PackIndexV2
...
Change-Id: I8c94811972c593c898f6375178f250a2123d01c6
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
4dd4d7e12a
Silence false null pointer access warnings in PackFile
...
Change-Id: Ia39085557b38840dfaa9b4995e6f6c40e19042cb
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
fc2d723dd9
Externalize error messages used in ObjectDirectoryInserter
...
Change-Id: I3bc26847071fbc31267a4a4cf5a10b428bcf229d
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
1728d1d760
Use try-with-resource to close resources in ObjectDatabase
...
Change-Id: Ib410bf0d3c300c25b615bb6a51488b3d88aeb3bd
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
f777ed1d24
Replace deprecated release() methods by close() in NoteMapMerger
...
Change-Id: Iaa76f0e853bb82cd7f231fd2f462a319f4196d8c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
f434f29fd9
Ensure that NameRevCommand.call() closes RevWalk
...
Change-Id: Icc35a81081759d664fe9e2b05e962ff3cd9aad92
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
8e332f1057
Replace deprecated release() methods by close() in Merger
...
Change-Id: I80ce98511a6e9048f1eea93288d6960dcbf3326f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
ed42bad1c6
Use try-with-resource to close resources in GC
...
Change-Id: I62a755a4ce839a252a5e80abf3f0d21243862376
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
2693d6075d
Use try-with-resource to close resources in FetchProcess
...
Change-Id: If489d530ca39ae279c8da848f870b561c38eac3c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
787ca168a9
Reduce visibility of DirCacheCheckout.checkValidPath()
...
This was deprecated and should only be used by DirCacheCheckout and
friends. Other classes should use SystemReader.checkPath() instead.
Change-Id: I37cf753b1f081602dee9f0f47979eff39d735f92
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
b84623ac64
Use try-with-resource to close resources in DirCache
...
Change-Id: I7dd3fd38784689816a1a8e9d8ccb499ae2138a8a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
ff0a7b719e
Fix resource leak in DiffFormatter
...
- close RevWalk allocated in scan()
- replace use of deprecated ObjectReader.release() method
Change-Id: I41b2b10a1a44270a6ceaa1741e996c0921439852
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
b8658e486c
Use try-with-resource to close resources in DiffCommand
...
Change-Id: I13d7c8bd0eb049aa69effd8b74384746226414cb
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
5f8308bdb9
Replace call to deprecated RevWalk.release() in DescribeCommand
...
Change-Id: Ie4bfdeb37d345d6ff1525a737f3b7653b2f8e23e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
4bae608e84
Use try-with-resource to close resources in CloneCommand
...
Change-Id: I9536bc208a5f3ec34f0a82fb565b4253be38e074
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
b53e2a99b3
Silence non-externalized string warnings in CherryPickResult
...
Change-Id: I515abbcb4319b744c5074de5a0c56caed13c2fb5
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
588965c6da
Silence non-externalized string warning in CherryPickCommand
...
Change-Id: I8c06635ce655470b5b650fa5c0c546e64445420c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
58c2c52219
Use try-with-resource to close resources in CherryPickCommand
...
Change-Id: I62d6de7d67c7de2460f4cbe918ad2bb8109650b9
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
3f79182081
Fix resource leak in ChangeIdUtil
...
Change-Id: I5cb3e9c7e167248697932933eef925c446514683
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
d4380a9c81
Use try-with-resource to close resources in BundleWriter
...
Change-Id: I5341973737f6d21c04982bcbefc2ed672ac9bcff
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
9e37f6d144
Use try-with-resource to close resources in BundleFetchConnection
...
Change-Id: Id79c01133b835e278d5b494b5bc5972d7aeed9a9
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
d6692d54a9
Use try-with-resource to close resources in BlobBasedConfig
...
Change-Id: Idb890788a88049d07326cd48e7c5534148f18e32
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
48622e0ec2
Replace use of deprecated release() method in BlameResult
...
Change-Id: Ic555e6e0443337aed694bc6445a60abe08e07ad2
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
e03b6c5cf8
Use try-with-resource to close BlameGenerator
...
Change-Id: Id4cb9a236dddfc674b55e9e7037329a885455288
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
21eee62f7d
Remove unnecessary $NON-NLS comment in BaseReceivePack
...
Change-Id: I184945ee29fb9a6b1f30aec88958375e7b5239b3
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
c1edc1a07e
Use try-with-resources to close resources in BaseReceivePack
...
Change-Id: Iacaad1a7e0719541e5616d231422ea6fd4c95161
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
6691c20bc2
Replace use of deprecated release() in BasePackPushConnection
...
Change-Id: I28a5c7e222daf35e3d1a1a6fda8ed6ef9b960f78
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
b61be2cf3e
Replace use of deprecated release() in BasePackFetchConnection
...
Change-Id: If90a6cca9a2ae80474f5ad023cb2a0a8905010be
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
81c84c088f
Use try-with-resources to close walks in ArchiveCommand
...
Change-Id: I77120d77a12f1bab5c918a23b0e3eac90e320b2b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
114dee6770
Silence warning for non-translatable String in AddNoteCommand
...
Change-Id: Iad4d41271eff4e8744efece5bc777c1cb06dead7
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
3206f37cc3
Use try-with-resources to fix warnings in AddNoteCommand
...
Replaces use of deprecated release() methods.
Change-Id: I0211bcf0a76a2fccc2c85fa74778e20c256984ba
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
e5b81e49e8
Use try-with-resources to fix warnings in AddCommand
...
- replaces use of deprecated ObjectInserter.release()
- auto-close TreeWalk
Change-Id: I540ee711b8c3430a71fdff07add506b7d9c039dc
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago
Matthias Sohn
5d22a7b108
Remove obsolete API warning filters to silence warnings
...
Change-Id: I958d540a6afb1462a3fbb3d76c8f51f386ac068e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
10 years ago