c18c768678
Fix error handling in FileLfsServlet
...
Check in #sendError method if the response was committed already.
If yes we cannot set response status or send an error message, last
resort is to close the outputstream.
If the response wasn't yet committed first reset the response before
using writer to send the error message to the client since mixing STREAM
and WRITE mode (mixing asynchronous and blocking I/O) is illegal in
servlet 3.1.
see the following bugs in the gerrit and jetty issue trackers
https://bugs.chromium.org/p/gerrit/issues/detail?id=9667
https://bugs.chromium.org/p/gerrit/issues/detail?id=9721
https://github.com/eclipse/jetty.project/issues/2911
Change-Id: Ie35563c2e0ac1c5e918185a746622589a880dc7f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
5c134f4d42
ObjectDownloadListener#onWritePossible: Make code spec compatible
...
Current code violates the ServletOutputStream contract. For every
out.isReady() == true either write or close of that ServletOutputStream
should be called.
See also this issue upstream for more context: [1].
[1] https://github.com/eclipse/jetty.project/issues/2911
Change-Id: Ied575f3603a6be0d2dafc6c3329d685fc212c7a3
Signed-off-by: David Ostrovsky <david@ostrovsky.org>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
f8e514c74a
ObjectDownloadListener: Return from onWritePossible when data is written
...
When buffer was written not only call AsyncContext#complete() but also
return from the ObjectDownloadListener#onWritePossible(). This avoids
endless loop after upgrading from Jetty 9.3.x to 9.4.x lines.
In Jetty example implementation:[1] the return statemnt is also used:
// If we are at EOF then complete
if (len < 0)
{
async.complete();
return;
}
See also this issue upstream: [2].
[1] https://webtide.com/servlet-3-1-async-io-and-jetty
[2] https://github.com/eclipse/jetty.project/issues/2911
Change-Id: Iac73fb25e67d40228a378a8e34103f1d28b72a76
Signed-off-by: David Ostrovsky <david@ostrovsky.org>
6 years ago
a44d95c814
Prepare 5.1.1-SNAPSHOT builds
...
Change-Id: Ie220dd95fae18f894e2a04a5ae6d29a1e5a6d76b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
47956bcc68
JGit v5.1.0.201809111528-r
...
Change-Id: I583bf7d60bccc876156be1f605bfda32b89cd08b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
34618a4f86
Prepare 4.11.3-SNAPSHOT builds
...
Change-Id: I4f5dda6da3f6ecd9b99c1d9a220844c5402f1988
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
ae21714768
JGit v4.11.2.201809100523-r
...
Change-Id: I85dab173a94b3036ccf669c20b9dffb4af0922b4
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
0b11e31a4c
Prepare 5.0.4-SNAPSHOT builds
...
Change-Id: Ib9042662c3f2a1544d597d476c5952c61767687b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
faf1ae230e
JGit v5.0.3.201809091024-r
...
Change-Id: I9e8e74a10dbb235b08c6a5e1b169c5cae440f129
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
de0a687948
Prepare 4.9.5-SNAPSHOT builds
...
Change-Id: Ie8d2b60be1803399027e1a3e9734625278a63861
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
6657f93adb
JGit v4.9.4.201809090327-r
...
Change-Id: I13488a915fe0ba871c5f37c6e9efc6f436083171
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
6fe4505b2a
Prepare 4.7.4-SNAPSHOT builds
...
Change-Id: Ie4d17e1604270946606e75145012c5b7fa1283eb
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
9796e86165
JGit v4.7.3.201809090215-r
...
Change-Id: I1ded7a2b61235509c5a6ba95e7329e288bbfddb1
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
2fae326aa9
Prepare 5.2.0-SNAPSHOT builds
...
Change-Id: If8e8ca20e745901a5e0239c16cb4acc7934b4ec8
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
4c8a4eb8fd
Prepare 5.1.0-SNAPSHOT builds
...
Change-Id: I3d06c5237edae54b09f465f415f5a308b5e7ceff
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
e4281f1d5f
JGit v5.1.0.201809051400-rc1
...
Change-Id: I0b53f95ee51d94da8b029c9bb10eb854ff9dd4f6
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
30c6c75421
Deprecate Constants.CHARSET in favor of StandardCharsets.UTF_8
...
Change-Id: I3b748620f067582afef20f144feebe40d0332be2
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
6 years ago
c64de36a06
Adjust severity of missing execution environment for LFS
...
All other JGit bundles use severity warning for missing execution
environment definition. Use the same configuration for LFS bundles.
Bug: 488123
Change-Id: I575d6d61418f5c4e39303fb8a9cd69e6539f6b5e
Signed-off-by: Markus Duft <markus.duft@ssi-schaefer.com>
6 years ago
a6d641a03b
Prepare 5.1.0-SNAPSHOT builds
...
Change-Id: If57fcce14f5ba3ef2a2602515e2f89b8f22a742b
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
a7ad89e974
JGit v5.1.0.201808281540-m3
...
Change-Id: Ie86c46a828b55a2235056b9a5bc2c6c450b95ed0
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
2f7bf6b536
Prepare 5.0.3-SNAPSHOT builds
...
Change-Id: Iae9d763a65481b09af6e19b33e41375f27038357
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
40813388e7
JGit v5.0.2.201807311906-r
...
Change-Id: Iccb98c03a069fee85a52325e1ed22cba8b76bcd8
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
a8c7c42ff1
Prepare 4.11.2-SNAPSHOT builds
...
Change-Id: I02630900ab131478b30abe68b2133d2c8a5a67ab
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
e51d2fcda8
JGit v4.11.1.201807311124-r
...
Change-Id: Ic58a916d7e2c380b84690afa5e3517c6c178af8c
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
6a813c64ff
Prepare 4.9.4-SNAPSHOT builds
...
Change-Id: Ibb2ee9d00d5d049f681e1abbb449656105e553a7
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
56b435a61c
JGit v4.9.3.201807311005-r
...
Change-Id: I3f4f437649736c6a27e78d536344c7b31c8a0f65
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
29118ed117
Prepare 4.7.3-SNAPSHOT builds
...
Change-Id: I5c437f45d5bc469e3c32bef1180c127d96d24d23
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
01787756aa
JGit v4.7.2.201807261330-r
...
Change-Id: I0d8c7ca756e6236e315c91da000fe8103ce83d05
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
ff15df05c3
Prepare 5.0.2-SNAPSHOT builds
...
Change-Id: I65e83f39a4082278c4cb809dbb08d44a119cebe0
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
a7e38fb0b0
JGit v5.0.1.201806211838-r
...
Change-Id: I594cd85d46698953c27da3687e4ec40aeb73b445
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
6 years ago
0dbaf9d951
Prepare 5.0.1-SNAPSHOT builds
...
Change-Id: Iadf12dbdd63ef17c3f712c0fc18495304aa35016
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
e729a83bd2
JGit v5.0.0.201806131550-r
...
Change-Id: Ia2d548676217250593c3f0c383aec19e12e5e4a4
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
94a585e6e8
JGit v5.0.0.201806131210-r
...
Change-Id: Iedccfcaf57c11822f1faf5d5195357de42b2a14e
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
cb0abf787e
Prepare 5.0.0-SNAPSHOT builds
...
Change-Id: I9acca328146aa7100fbc1b457fcb1f8fd87cf52a
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
ca57743a45
JGit v5.0.0.201806050710-rc3
...
Change-Id: Ic7a6a87dd3a21351e60fbf6cd330456adf1f6800
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
c473bbf802
Prepare 5.0.0-SNAPSHOT builds
...
Change-Id: I9c4a0465f8e85041d24da97f4b4c7ad5f5eed3e4
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
dbf091a7ee
JGit v5.0.0.201805301535-rc2
...
Change-Id: Ifad678794525c01838b03e52bada66e1c089c5ae
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
2f1b4ffcd2
Prepare 5.1.0-SNAPSHOT builds
...
Change-Id: I8523a993ae1f7b62573d7547273bc1356bf64fa7
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
9ad7031381
Prepare 5.0.0-SNAPSHOT builds
...
Change-Id: Ie343ccf37f46168041046500a2e19acc80814cfe
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
812abefd58
JGit v5.0.0.201805221745-rc1
...
Change-Id: Ie2c35fab87f294b00f9754b07b60a848bf256b10
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
5797105754
Prepare 5.0.0-SNAPSHOT builds
...
Change-Id: I65d7d74c6124507aa9cb2856c74db6a1a6935bab
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
a8aabc3d15
JGit v5.0.0.201805151920-m7
...
Change-Id: I42eb046c8ac8537672010aabe21459293cb23838
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
6d370d837c
Remove 'final' in parameter lists
...
Change-Id: Id924f79c8b2c720297ebc49bf9c5d4ddd6d52547
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
7 years ago
f07b60239c
Consistently use Constants.CHARSET rather than StandardCharsets.UTF_8
...
Change-Id: I6714fc3666e1bced22abba94ceb700477349586e
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
7 years ago
b7651da4e8
Remove deprecated LfsProtocolServlet#getLargeFileRepository
...
Use LfsProtocolServlet##getLargeFileRepository(LfsRequest, String,
String) instead.
Change-Id: If68d06f2e6edbf843dc9d3b4e3b99c33b0fab766
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
d0f1f5eef6
Prepare 5.0.0-SNAPSHOT builds
...
Change-Id: I2d2f50ed8a12f310e7cac68eed5536bd460c403f
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
f389e18a28
Prepare 4.11.1-SNAPSHOT builds
...
Change-Id: Id9aa6b7e8f56de5183b6cd57ef0e790ec9debd4d
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
f944063517
JGit v4.11.0.201803080745-r
...
Change-Id: Ie24a33bc8a24c30db06fe7b175f405efb95776ec
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
7 years ago
03536cc2d0
FileLfsServlet: Open PrintWriter in try-with-resource
...
Change-Id: I6fa225e541c6d5c3dbf3d852a502f4e9c4f7d77e
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
7 years ago
a573dfc658
Enable warning for resources not managed by try-with-resource
...
Change-Id: Iefe97de6bdb62af558f1b0e77c9205a9186f9b4c
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
7 years ago
Matthias Sohn
David Ostrovsky
David Pursehouse
Markus Duft
Han-Wen Nienhuys