Browse Source
* GC.tooManyLooseObjects() always responded true since the loop missed to advance the iterator so it always incremented until the threshold was exceeded. * Also fix loop exit criterion which was off by 1. * Add some tests. Change-Id: I70976dfaa026efbcf3c46bd45941f37277a18e04 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>stable-4.6
Matthias Sohn
8 years ago
4 changed files with 147 additions and 7 deletions
@ -0,0 +1,87 @@
|
||||
/* |
||||
* Copyright (C) 2016, Matthias Sohn <matthias.sohn@sap.com> |
||||
* and other copyright owners as documented in the project's IP log. |
||||
* |
||||
* This program and the accompanying materials are made available |
||||
* under the terms of the Eclipse Distribution License v1.0 which |
||||
* accompanies this distribution, is reproduced below, and is |
||||
* available at http://www.eclipse.org/org/documents/edl-v10.php
|
||||
* |
||||
* All rights reserved. |
||||
* |
||||
* Redistribution and use in source and binary forms, with or |
||||
* without modification, are permitted provided that the following |
||||
* conditions are met: |
||||
* |
||||
* - Redistributions of source code must retain the above copyright |
||||
* notice, this list of conditions and the following disclaimer. |
||||
* |
||||
* - Redistributions in binary form must reproduce the above |
||||
* copyright notice, this list of conditions and the following |
||||
* disclaimer in the documentation and/or other materials provided |
||||
* with the distribution. |
||||
* |
||||
* - Neither the name of the Eclipse Foundation, Inc. nor the |
||||
* names of its contributors may be used to endorse or promote |
||||
* products derived from this software without specific prior |
||||
* written permission. |
||||
* |
||||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND |
||||
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, |
||||
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES |
||||
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE |
||||
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR |
||||
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
||||
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT |
||||
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; |
||||
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER |
||||
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, |
||||
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) |
||||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF |
||||
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
||||
*/ |
||||
package org.eclipse.jgit.internal.storage.file; |
||||
|
||||
import static org.junit.Assert.assertFalse; |
||||
import static org.junit.Assert.assertTrue; |
||||
|
||||
import org.eclipse.jgit.lib.ConfigConstants; |
||||
import org.eclipse.jgit.storage.file.FileBasedConfig; |
||||
import org.eclipse.jgit.test.resources.SampleDataRepositoryTestCase; |
||||
import org.junit.Test; |
||||
|
||||
public class AutoGcTest extends GcTestCase { |
||||
|
||||
@Test |
||||
public void testNotTooManyLooseObjects() { |
||||
assertFalse("should not find too many loose objects", |
||||
gc.tooManyLooseObjects()); |
||||
} |
||||
|
||||
@Test |
||||
public void testTooManyLooseObjects() throws Exception { |
||||
FileBasedConfig c = repo.getConfig(); |
||||
c.setInt(ConfigConstants.CONFIG_GC_SECTION, null, |
||||
ConfigConstants.CONFIG_KEY_AUTO, 255); |
||||
c.save(); |
||||
commitChain(10, 50); |
||||
assertTrue("should find too many loose objects", |
||||
gc.tooManyLooseObjects()); |
||||
} |
||||
|
||||
@Test |
||||
public void testNotTooManyPacks() { |
||||
assertFalse("should not find too many packs", gc.tooManyPacks()); |
||||
} |
||||
|
||||
@Test |
||||
public void testTooManyPacks() throws Exception { |
||||
FileBasedConfig c = repo.getConfig(); |
||||
c.setInt(ConfigConstants.CONFIG_GC_SECTION, null, |
||||
ConfigConstants.CONFIG_KEY_AUTOPACKLIMIT, 1); |
||||
c.save(); |
||||
SampleDataRepositoryTestCase.copyCGitTestPacks(repo); |
||||
|
||||
assertTrue("should find too many packs", gc.tooManyPacks()); |
||||
} |
||||
} |
Loading…
Reference in new issue