Browse Source

AmazonS3: Open InputStream/FileInputStream in try-with-resource

Change-Id: I71606e14d2b3cf085b8d1343c3858e7a729a173e
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
stable-4.11
David Pursehouse 7 years ago
parent
commit
f6dbc7d472
  1. 10
      org.eclipse.jgit/src/org/eclipse/jgit/transport/AmazonS3.java

10
org.eclipse.jgit/src/org/eclipse/jgit/transport/AmazonS3.java

@ -650,11 +650,8 @@ public class AmazonS3 {
static Properties properties(final File authFile)
throws FileNotFoundException, IOException {
final Properties p = new Properties();
final FileInputStream in = new FileInputStream(authFile);
try {
try (FileInputStream in = new FileInputStream(authFile)) {
p.load(in);
} finally {
in.close();
}
return p;
}
@ -697,16 +694,13 @@ public class AmazonS3 {
throw new IOException(JGitText.get().noXMLParserAvailable);
}
xr.setContentHandler(this);
final InputStream in = c.getInputStream();
try {
try (InputStream in = c.getInputStream()) {
xr.parse(new InputSource(in));
} catch (SAXException parsingError) {
throw new IOException(
MessageFormat.format(
JGitText.get().errorListing, prefix),
parsingError);
} finally {
in.close();
}
return;

Loading…
Cancel
Save