From f08fde3eebc2689210292d78db785f6ec52dc8ef Mon Sep 17 00:00:00 2001 From: Shawn Pearce Date: Fri, 14 Feb 2014 09:48:50 -0800 Subject: [PATCH] Remove dead isBinary method from DiffFormatter This method always returns false and is private so it cannot be overridden at runtime by a subclass. Drop the method and the branch that can never be taken. Change-Id: I4d3edbf469c6739dca191e62ea580bdb534b67a4 --- .../src/org/eclipse/jgit/diff/DiffFormatter.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java b/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java index 9e26c3747..4cd931912 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java @@ -971,9 +971,6 @@ public class DiffFormatter { if (entry.getMode(side).getObjectType() != Constants.OBJ_BLOB) return EMPTY; - if (isBinary()) - return BINARY; - AbbreviatedObjectId id = entry.getId(side); if (!id.isComplete()) { Collection ids = reader.resolve(id); @@ -1012,10 +1009,6 @@ public class DiffFormatter { } } - private boolean isBinary() { - return false; - } - /** * Output the first header line *