From e0d1cfb5ad8d8504327458fca39ee9856755c14b Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 22 Sep 2016 11:26:28 +0200 Subject: [PATCH] Upgrade buck to 7b7817c48f30687781040b2b82ac9218d5c4eaa4 Upgrade to match the version used on Gerrit's master branch. Requires a couple of modifications to make the tests work: - Remove source_under_test parameters from java_test calls. - Add vm_args with explicit setting of tmpdir location for http tests. This is needed due to upstream changes in temporary directory handling [1]. [1] https://github.com/facebook/buck/issues/946 Change-Id: I5d5dd5edc335d44b118e8587f69ba89b83fc7fbb Signed-off-by: David Pursehouse --- .buckversion | 2 +- org.eclipse.jgit.http.test/BUCK | 2 +- org.eclipse.jgit.lfs.server.test/BUCK | 1 - org.eclipse.jgit.lfs.test/BUCK | 1 - org.eclipse.jgit.pgm.test/BUCK | 1 - org.eclipse.jgit.test/BUCK | 1 - 6 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.buckversion b/.buckversion index f5fe01697..af38772e5 100644 --- a/.buckversion +++ b/.buckversion @@ -1 +1 @@ -e64a2e2ada022f81e42be750b774024469551398 +7b7817c48f30687781040b2b82ac9218d5c4eaa4 diff --git a/org.eclipse.jgit.http.test/BUCK b/org.eclipse.jgit.http.test/BUCK index d65cdadfc..f5cd10e58 100644 --- a/org.eclipse.jgit.http.test/BUCK +++ b/org.eclipse.jgit.http.test/BUCK @@ -25,7 +25,7 @@ for t in TESTS: '//lib/jetty:util', '//lib:commons-logging', ], - source_under_test = ['//org.eclipse.jgit.http.server:jgit-servlet'], + vm_args = ['-Djava.io.tmpdir=buck-out'], ) java_library( diff --git a/org.eclipse.jgit.lfs.server.test/BUCK b/org.eclipse.jgit.lfs.server.test/BUCK index 9d6e72fcf..25e9f09c1 100644 --- a/org.eclipse.jgit.lfs.server.test/BUCK +++ b/org.eclipse.jgit.lfs.server.test/BUCK @@ -30,6 +30,5 @@ for t in TESTS: '//lib:servlet-api', '//lib:commons-logging', ], - source_under_test = ['//org.eclipse.jgit.lfs.server:jgit-lfs-server'], vm_args = ['-Xmx256m', '-Dfile.encoding=UTF-8'], ) diff --git a/org.eclipse.jgit.lfs.test/BUCK b/org.eclipse.jgit.lfs.test/BUCK index d0fb96f9c..1298e166c 100644 --- a/org.eclipse.jgit.lfs.test/BUCK +++ b/org.eclipse.jgit.lfs.test/BUCK @@ -15,7 +15,6 @@ for t in TESTS: '//lib:hamcrest-library', '//lib:junit', ], - source_under_test = ['//org.eclipse.jgit.lfs:jgit-lfs'], ) java_library( diff --git a/org.eclipse.jgit.pgm.test/BUCK b/org.eclipse.jgit.pgm.test/BUCK index a3859c9b4..cd1551079 100644 --- a/org.eclipse.jgit.pgm.test/BUCK +++ b/org.eclipse.jgit.pgm.test/BUCK @@ -21,7 +21,6 @@ for t in TESTS: '//lib:commons-compress', '//lib:tukaani-xz', ], - source_under_test = ['//org.eclipse.jgit.pgm:pgm'], vm_args = ['-Xmx256m', '-Dfile.encoding=UTF-8'], ) diff --git a/org.eclipse.jgit.test/BUCK b/org.eclipse.jgit.test/BUCK index e4cd47c66..5b7be89b1 100644 --- a/org.eclipse.jgit.test/BUCK +++ b/org.eclipse.jgit.test/BUCK @@ -68,7 +68,6 @@ for src in TESTS: '//lib:slf4j-api', '//lib:slf4j-simple', ] + DEPS.get(src, []), - source_under_test = ['//org.eclipse.jgit:jgit'], vm_args = ['-Xmx256m', '-Dfile.encoding=UTF-8'], )