From d69a829bdb6a79824804d4d56c4ac97ebe78bb30 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Fri, 27 Jan 2017 11:32:18 +0900 Subject: [PATCH] LocalDiskRepositoryTestCase: Prevent duplicates in list of repos to close Change the "toClose" list to a set, which will not allow duplicate entries. This reduces the number of false positive logs about corrupt use count due to the same repository being closed more than once during teardown. Change-Id: I5ab0ff8b56e7f2b2c7aab5274d957708d26f42c5 Signed-off-by: David Pursehouse --- .../org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java b/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java index dc2e8bfb7..0a6defc3e 100644 --- a/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java +++ b/org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java @@ -53,8 +53,10 @@ import java.io.IOException; import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; +import java.util.HashSet; import java.util.List; import java.util.Map; +import java.util.Set; import java.util.TreeSet; import org.eclipse.jgit.dircache.DirCache; @@ -106,7 +108,7 @@ public abstract class LocalDiskRepositoryTestCase { */ protected MockSystemReader mockSystemReader; - private final List toClose = new ArrayList(); + private final Set toClose = new HashSet<>(); private File tmp; @Before