From ce3997344ecb564f2af95fd366303e2c9d70143d Mon Sep 17 00:00:00 2001 From: Shawn Pearce Date: Mon, 9 Mar 2015 17:30:08 -0700 Subject: [PATCH] PushCertificateParser: Fix check for blank line after header Reference equality (!= or ==) cannot be used to check for String equality. String objects are not necessarily interned to the same instance. Use .isEmpty() since the function only cares about an empty string and does not need to test a specific string value. Change-Id: If530cb59666a8196d57d2348c893706a517ea541 --- .../src/org/eclipse/jgit/transport/PushCertificateParser.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java index d4b11a5d4..4bb3d6bf8 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateParser.java @@ -158,7 +158,7 @@ public class PushCertificateParser extends PushCertificate { pushee = parseNextLine(pckIn, PUSHEE); receivedNonce = parseNextLine(pckIn, NONCE); // an empty line - if (pckIn.readString() != "") { //$NON-NLS-1$ + if (!pckIn.readString().isEmpty()) { throw new IOException(MessageFormat.format( JGitText.get().errorInvalidPushCert, "expected empty line after header")); //$NON-NLS-1$