Browse Source

Merge "Correct CommitBuilder, TagBuilder method to be build()"

stable-0.10
Matthias Sohn 14 years ago committed by Code Review
parent
commit
c474813b0a
  1. 2
      org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/RevCommitParseTest.java
  2. 2
      org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/RevTagParseTest.java
  3. 6
      org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitBuilder.java
  4. 4
      org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectInserter.java
  5. 6
      org.eclipse.jgit/src/org/eclipse/jgit/lib/TagBuilder.java

2
org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/RevCommitParseTest.java

@ -338,7 +338,7 @@ public class RevCommitParseTest extends RepositoryTestCase {
src.setCommitter(committer); src.setCommitter(committer);
src.setMessage("Test commit\n\nThis is a test.\n"); src.setMessage("Test commit\n\nThis is a test.\n");
RevCommit p = RevCommit.parse(src.format()); RevCommit p = RevCommit.parse(src.build());
assertEquals(src.getTreeId(), p.getTree()); assertEquals(src.getTreeId(), p.getTree());
assertEquals(0, p.getParentCount()); assertEquals(0, p.getParentCount());
assertEquals(author, p.getAuthorIdent()); assertEquals(author, p.getAuthorIdent());

2
org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/RevTagParseTest.java

@ -407,7 +407,7 @@ public class RevTagParseTest extends RepositoryTestCase {
src.setTag("a.test"); src.setTag("a.test");
src.setMessage("Test tag\n\nThis is a test.\n"); src.setMessage("Test tag\n\nThis is a test.\n");
RevTag p = RevTag.parse(src.format()); RevTag p = RevTag.parse(src.build());
assertEquals(src.getObjectId(), p.getObject()); assertEquals(src.getObjectId(), p.getObject());
assertEquals(committer, p.getTaggerIdent()); assertEquals(committer, p.getTaggerIdent());
assertEquals("a.test", p.getTagName()); assertEquals("a.test", p.getTagName());

6
org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitBuilder.java

@ -288,8 +288,8 @@ public class CommitBuilder {
* the encoding specified by {@link #getEncoding()} is not * the encoding specified by {@link #getEncoding()} is not
* supported by this Java runtime. * supported by this Java runtime.
*/ */
public byte[] format() throws UnsupportedEncodingException { public byte[] build() throws UnsupportedEncodingException {
return format(new ObjectInserter.Formatter()); return build(new ObjectInserter.Formatter());
} }
/** /**
@ -308,7 +308,7 @@ public class CommitBuilder {
* the encoding specified by {@link #getEncoding()} is not * the encoding specified by {@link #getEncoding()} is not
* supported by this Java runtime. * supported by this Java runtime.
*/ */
public byte[] format(ObjectInserter oi) throws UnsupportedEncodingException { public byte[] build(ObjectInserter oi) throws UnsupportedEncodingException {
ByteArrayOutputStream os = new ByteArrayOutputStream(); ByteArrayOutputStream os = new ByteArrayOutputStream();
OutputStreamWriter w = new OutputStreamWriter(os, getEncoding()); OutputStreamWriter w = new OutputStreamWriter(os, getEncoding());
try { try {

4
org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectInserter.java

@ -189,7 +189,7 @@ public abstract class ObjectInserter {
* the object could not be stored. * the object could not be stored.
*/ */
public final ObjectId insert(CommitBuilder builder) throws IOException { public final ObjectId insert(CommitBuilder builder) throws IOException {
return insert(Constants.OBJ_COMMIT, builder.format(this)); return insert(Constants.OBJ_COMMIT, builder.build(this));
} }
/** /**
@ -205,7 +205,7 @@ public abstract class ObjectInserter {
* the object could not be stored. * the object could not be stored.
*/ */
public final ObjectId insert(TagBuilder builder) throws IOException { public final ObjectId insert(TagBuilder builder) throws IOException {
return insert(Constants.OBJ_TAG, builder.format(this)); return insert(Constants.OBJ_TAG, builder.build(this));
} }
/** /**

6
org.eclipse.jgit/src/org/eclipse/jgit/lib/TagBuilder.java

@ -182,8 +182,8 @@ public class TagBuilder {
* @return this object in the canonical annotated tag format, suitable for * @return this object in the canonical annotated tag format, suitable for
* storage in a repository. * storage in a repository.
*/ */
public byte[] format() { public byte[] build() {
return format(new ObjectInserter.Formatter()); return build(new ObjectInserter.Formatter());
} }
/** /**
@ -199,7 +199,7 @@ public class TagBuilder {
* @return this object in the canonical annotated tag format, suitable for * @return this object in the canonical annotated tag format, suitable for
* storage in a repository. * storage in a repository.
*/ */
public byte[] format(ObjectInserter oi) { public byte[] build(ObjectInserter oi) {
ByteArrayOutputStream os = new ByteArrayOutputStream(); ByteArrayOutputStream os = new ByteArrayOutputStream();
OutputStreamWriter w = new OutputStreamWriter(os, Constants.CHARSET); OutputStreamWriter w = new OutputStreamWriter(os, Constants.CHARSET);
try { try {

Loading…
Cancel
Save