From bfa62d88d47157b72abaf2f1a8fb8af07da75050 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Fri, 15 Jul 2011 16:28:26 -0700 Subject: [PATCH] Don't close ObjectDatabase after parsing pack The cached object databases should not require a close to release their cached resources. Most object databases just return their own reference for newCachedDatabase(), so a close() here kills the real database's internal caches, and possibly underlying files, resulting in poor performance for the callers of PackParser like ReceivePack or FetchProcess trying to then go look up objects that were just parsed, or that current references point to. Change-Id: Ia4a239093866e5b9faf82744f729fb73f4373f1a Signed-off-by: Shawn O. Pearce --- org.eclipse.jgit/src/org/eclipse/jgit/transport/PackParser.java | 1 - 1 file changed, 1 deletion(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PackParser.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PackParser.java index 4bbe3a004..03370034b 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PackParser.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PackParser.java @@ -511,7 +511,6 @@ public abstract class PackParser { inflater.release(); } finally { inflater = null; - objectDatabase.close(); } } return null; // By default there is no locking.