Browse Source

Unconditionally close repository in unregisterAndCloseRepository

Repository.close() method is used when reference counting and expiration
needs to be honored. The RepositoryCache.unregisterAndCloseRepository
method should close the repository unconditionally. This is also indicated
from its javadoc.

Change-Id: I19392d1eaa17f27ae44b55eea49dcff05a52f298
stable-4.5
Saša Živkov 8 years ago
parent
commit
b7df7d1fd3
  1. 8
      org.eclipse.jgit/src/org/eclipse/jgit/lib/RepositoryCache.java

8
org.eclipse.jgit/src/org/eclipse/jgit/lib/RepositoryCache.java

@ -305,11 +305,9 @@ public class RepositoryCache {
private void unregisterAndCloseRepository(final Key location,
Repository db) {
synchronized (lockFor(location)) {
if (isExpired(db)) {
Repository oldDb = unregisterRepository(location);
if (oldDb != null) {
oldDb.close();
}
Repository oldDb = unregisterRepository(location);
if (oldDb != null) {
oldDb.doClose();
}
}
}

Loading…
Cancel
Save