Browse Source

PackOutputStream: Suppress Error Prone's ShortCircuitBoolean warning

The usage of non-short-circuit logic is intentional, per the inline
comment added in change Ib4b35e357 as a follow-up to Ie3761ffb4 which
was a previously rejected attempt to "fix" a similar warning that had
been raised by FindBugs.

Change-Id: I3f6729f954d45d30ce697356d2ab3cc877d3ad54
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
stable-5.2
David Pursehouse 6 years ago committed by Matthias Sohn
parent
commit
b3adaf7741
  1. 1
      org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

1
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/PackOutputStream.java

@ -187,6 +187,7 @@ public final class PackOutputStream extends OutputStream {
* @throws java.io.IOException
* the underlying stream refused to accept the header.
*/
@SuppressWarnings("ShortCircuitBoolean")
public final void writeHeader(ObjectToPack otp, long rawLength)
throws IOException {
ObjectToPack b = otp.getDeltaBase();

Loading…
Cancel
Save