From 08a9682e3264cb3457c63696f0a13efbd6a5dfdc Mon Sep 17 00:00:00 2001
From: "Shawn O. Pearce" <spearce@spearce.org>
Date: Mon, 8 Nov 2010 15:34:47 -0800
Subject: [PATCH] Revert "[findBugs] Silence DM_STRING_CTOR on PacketLineIn"

This reverts commit 1e510ec20e0391010419b17e9a9095ad54941d3c.

Instead work around the warning by defining our constant by
constructing it through a StringBuilder.

Change-Id: If139509e769d649609c62eff359ebaea5dd286b2
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
CC: Matthias Sohn <matthias.sohn@sap.com>
CC: Chris Aniszczyk <caniszczyk@gmail.com>
---
 org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml       | 8 --------
 .../src/org/eclipse/jgit/transport/PacketLineIn.java      | 3 ++-
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml b/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml
index f93c8f302..948308e77 100644
--- a/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml
+++ b/org.eclipse.jgit/findBugs/FindBugsExcludeFilter.xml
@@ -38,12 +38,4 @@
        <Class name="org.eclipse.jgit.util.TemporaryBuffer$BlockInputStream" />
        <Bug pattern="UR_UNINIT_READ" />
      </Match>
-
-	<!-- Silence invoke inefficient String constructor, we do not want to pool
-		here -->
-     <Match>
-       <Class name="org.eclipse.jgit.transport.PacketLineIn" />
-       <Method name="&lt;clinit&gt;" />
-       <Bug pattern="DM_STRING_CTOR" />
-     </Match>
 </FindBugsFilter>
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PacketLineIn.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PacketLineIn.java
index 3821d696e..d3264d5f2 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/PacketLineIn.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/PacketLineIn.java
@@ -57,7 +57,8 @@ import org.eclipse.jgit.util.IO;
 import org.eclipse.jgit.util.RawParseUtils;
 
 class PacketLineIn {
-	static final String END = new String("") /* must not string pool */;
+	/* must not string pool */
+	static final String END = new StringBuilder(0).toString();
 
 	static enum AckNackResult {
 		/** NAK */