Merge branch 'stable-5.4' into stable-5.5

* stable-5.4:
  Prepare 5.4.4-SNAPSHOT builds
  JGit v5.4.3.201909031940-r
  Prepare 5.3.6-SNAPSHOT builds
  JGit v5.3.5.201909031855-r
  Prepare 5.1.12-SNAPSHOT builds
  JGit v5.1.11.201909031202-r
  Prepare 4.11.10-SNAPSHOT builds
  JGit v4.11.9.201909030838-r
  Bazel: Update bazlets to the latest master revision
  Bazel: Remove FileTreeIteratorWithTimeControl from BUILD file
  BatchRefUpdate: repro racy atomic update, and fix it
  Delete unused FileTreeIteratorWithTimeControl
  Fix RacyGitTests#testRacyGitDetection
  Change RacyGitTests to create a racy git situation in a stable way
  Silence API warnings

Change-Id: Icd6630db6458971f840c3ab4553e00f6c775ede0
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

WORKSPACE

@@ -15,7 +15,7 @@ versions.check(minimum_bazel_version = "0.26.1")
 
 load("//tools:bazlets.bzl", "load_bazlets")
 
-load_bazlets(commit = "8528a0df69dadf6311d8d3f81c1b693afda8bcf1")
+load_bazlets(commit = "09a035e98077dce549d5f6a7472d06c4b8f792d2")
 
 load(
     "@com_googlesource_gerrit_bazlets//tools:maven_jar.bzl",

org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/BatchRefUpdateTest.java

@@ -43,6 +43,7 @@
 
 package org.eclipse.jgit.internal.storage.file;
 
+import static java.nio.charset.StandardCharsets.UTF_8;
 import static java.util.concurrent.TimeUnit.NANOSECONDS;
 import static java.util.concurrent.TimeUnit.SECONDS;
 import static org.eclipse.jgit.internal.storage.file.BatchRefUpdateTest.Result.LOCK_FAILURE;
@@ -64,6 +65,7 @@ import static org.junit.Assume.assumeTrue;
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.file.Files;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
@@ -161,6 +163,33 @@ public class BatchRefUpdateTest extends LocalDiskRepositoryTestCase {
 		refsChangedEvents = 0;
 	}
 
+	@Test
+	public void packedRefsFileIsSorted() throws IOException {
+		assumeTrue(atomic);
+
+		for (int i = 0; i < 2; i++) {
+			BatchRefUpdate bu = diskRepo.getRefDatabase().newBatchUpdate();
+			String b1  = String.format("refs/heads/a%d",i);
+			String b2  = String.format("refs/heads/b%d",i);
+			bu.setAtomic(atomic);
+			ReceiveCommand c1 = new ReceiveCommand(ObjectId.zeroId(), A, b1);
+			ReceiveCommand c2 = new ReceiveCommand(ObjectId.zeroId(), B, b2);
+			bu.addCommand(c1, c2);
+			try (RevWalk rw = new RevWalk(diskRepo)) {
+				bu.execute(rw, NullProgressMonitor.INSTANCE);
+			}
+			assertEquals(c1.getResult(), ReceiveCommand.Result.OK);
+			assertEquals(c2.getResult(), ReceiveCommand.Result.OK);
+		}
+
+		File packed = new File(diskRepo.getDirectory(), "packed-refs");
+		String packedStr = new String(Files.readAllBytes(packed.toPath()), UTF_8);
+
+		int a2 = packedStr.indexOf("refs/heads/a1");
+		int b1 = packedStr.indexOf("refs/heads/b0");
+		assertTrue(a2 <  b1);
+	}
+
 	@Test
 	public void simpleNoForce() throws IOException {
 		writeLooseRef("refs/heads/master", A);

org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/PackedBatchRefUpdate.java

@@ -51,10 +51,10 @@ import static org.eclipse.jgit.transport.ReceiveCommand.Result.REJECTED_OTHER_RE
 
 import java.io.IOException;
 import java.text.MessageFormat;
-import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
 import java.util.HashMap;
 import java.util.HashSet;
-import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -364,65 +364,72 @@ class PackedBatchRefUpdate extends BatchRefUpdate {
 
 	private static RefList<Ref> applyUpdates(RevWalk walk, RefList<Ref> refs,
 			List<ReceiveCommand> commands) throws IOException {
-		int nDeletes = 0;
+		// Construct a new RefList by merging the old list with the updates.
-		List<ReceiveCommand> adds = new ArrayList<>(commands.size());
+		// This assumes that each ref occurs at most once as a ReceiveCommand.
+		Collections.sort(commands, new Comparator<ReceiveCommand>() {
+			@Override
+			public int compare(ReceiveCommand a, ReceiveCommand b) {
+				return a.getRefName().compareTo(b.getRefName());
+			}
+		});
+
+		int delta = 0;
 		for (ReceiveCommand c : commands) {
-			if (c.getType() == ReceiveCommand.Type.CREATE) {
+			switch (c.getType()) {
-				adds.add(c);
+			case DELETE:
-			} else if (c.getType() == ReceiveCommand.Type.DELETE) {
+				delta--;
-				nDeletes++;
+				break;
+			case CREATE:
+				delta++;
+				break;
+			default:
 			}
 		}
-		int addIdx = 0;
+
-
+		RefList.Builder<Ref> b = new RefList.Builder<>(refs.size() + delta);
-		// Construct a new RefList by linearly scanning the old list, and merging in
+		int refIdx = 0;
-		// any updates.
+		int cmdIdx = 0;
-		Map<String, ReceiveCommand> byName = byName(commands);
+		while (refIdx < refs.size() || cmdIdx < commands.size()) {
-		RefList.Builder<Ref> b =
+			Ref ref = (refIdx < refs.size()) ? refs.get(refIdx) : null;
-				new RefList.Builder<>(refs.size() - nDeletes + adds.size());
+			ReceiveCommand cmd = (cmdIdx < commands.size())
-		for (Ref ref : refs) {
+					? commands.get(cmdIdx)
-			String name = ref.getName();
+					: null;
-			ReceiveCommand cmd = byName.remove(name);
+			int cmp = 0;
-			if (cmd == null) {
+			if (ref != null && cmd != null) {
-				b.add(ref);
+				cmp = ref.getName().compareTo(cmd.getRefName());
-				continue;
+			} else if (ref == null) {
-			}
+				cmp = 1;
-			if (!cmd.getOldId().equals(ref.getObjectId())) {
+			} else if (cmd == null) {
-				lockFailure(cmd, commands);
+				cmp = -1;
-				return null;
 			}
 
-			// Consume any adds between the last and current ref.
+			if (cmp < 0) {
-			while (addIdx < adds.size()) {
+				b.add(ref);
-				ReceiveCommand currAdd = adds.get(addIdx);
+				refIdx++;
-				if (currAdd.getRefName().compareTo(name) < 0) {
+			} else if (cmp > 0) {
-					b.add(peeledRef(walk, currAdd));
+				assert cmd != null;
-					byName.remove(currAdd.getRefName());
+				if (cmd.getType() != ReceiveCommand.Type.CREATE) {
-				} else {
+					lockFailure(cmd, commands);
-					break;
+					return null;
 				}
-				addIdx++;
-			}
 
-			if (cmd.getType() != ReceiveCommand.Type.DELETE) {
 				b.add(peeledRef(walk, cmd));
-			}
+				cmdIdx++;
-		}
+			} else {
-
+				assert cmd != null;
-		// All remaining adds are valid, since the refs didn't exist.
+				assert ref != null;
-		while (addIdx < adds.size()) {
+				if (!cmd.getOldId().equals(ref.getObjectId())) {
-			ReceiveCommand cmd = adds.get(addIdx++);
+					lockFailure(cmd, commands);
-			byName.remove(cmd.getRefName());
+					return null;
-			b.add(peeledRef(walk, cmd));
+				}
-		}
 
-		// Any remaining updates/deletes do not correspond to any existing refs, so
+				if (cmd.getType() != ReceiveCommand.Type.DELETE) {
-		// they are lock failures.
+					b.add(peeledRef(walk, cmd));
-		if (!byName.isEmpty()) {
+				}
-			lockFailure(byName.values().iterator().next(), commands);
+				cmdIdx++;
-			return null;
+				refIdx++;
+			}
 		}
-
 		return b.toRefList();
 	}
 
@@ -501,15 +508,6 @@ class PackedBatchRefUpdate extends BatchRefUpdate {
 		}
 	}
 
-	private static Map<String, ReceiveCommand> byName(
-			List<ReceiveCommand> commands) {
-		Map<String, ReceiveCommand> ret = new LinkedHashMap<>();
-		for (ReceiveCommand cmd : commands) {
-			ret.put(cmd.getRefName(), cmd);
-		}
-		return ret;
-	}
-
 	private static Ref peeledRef(RevWalk walk, ReceiveCommand cmd)
 			throws IOException {
 		ObjectId newId = cmd.getNewId().copy();