Browse Source

Remove redundant @since tags in new signed push classes

Change-Id: I9f57318a59f668906b80f67230d36ba6439fc7b4
stable-4.1
Dave Borowitz 10 years ago
parent
commit
856db79b1d
  1. 16
      org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateIdent.java
  2. 24
      org.eclipse.jgit/src/org/eclipse/jgit/transport/SignedPushConfig.java

16
org.eclipse.jgit/src/org/eclipse/jgit/transport/PushCertificateIdent.java

@ -92,7 +92,6 @@ public class PushCertificateIdent {
* @param str * @param str
* string to parse. * string to parse.
* @return identity, never null. * @return identity, never null.
* @since 4.1
*/ */
public static PushCertificateIdent parse(String str) { public static PushCertificateIdent parse(String str) {
MutableInteger p = new MutableInteger(); MutableInteger p = new MutableInteger();
@ -178,16 +177,12 @@ public class PushCertificateIdent {
* must be encoded as UTF-8. * must be encoded as UTF-8.
* *
* @return the raw string. * @return the raw string.
* @since 4.1
*/ */
public String getRaw() { public String getRaw() {
return raw; return raw;
} }
/** /** @return the OpenPGP User ID, which may be any string. */
* @return the OpenPGP User ID, which may be any string.
* @since 4.1
*/
public String getUserId() { public String getUserId() {
return userId; return userId;
} }
@ -196,7 +191,6 @@ public class PushCertificateIdent {
* @return the name portion of the User ID. If no email address would be * @return the name portion of the User ID. If no email address would be
* parsed by {@link #getEmailAddress()}, returns the full User ID with * parsed by {@link #getEmailAddress()}, returns the full User ID with
* spaces trimmed. * spaces trimmed.
* @since 4.1
*/ */
public String getName() { public String getName() {
int nameEnd = userId.indexOf('<'); int nameEnd = userId.indexOf('<');
@ -217,7 +211,6 @@ public class PushCertificateIdent {
/** /**
* @return the email portion of the User ID, if one was successfully parsed * @return the email portion of the User ID, if one was successfully parsed
* from {@link #getUserId()}, or null. * from {@link #getUserId()}, or null.
* @since 4.1
*/ */
public String getEmailAddress() { public String getEmailAddress() {
int emailBegin = userId.indexOf('<'); int emailBegin = userId.indexOf('<');
@ -231,17 +224,13 @@ public class PushCertificateIdent {
return userId.substring(emailBegin + 1, emailEnd); return userId.substring(emailBegin + 1, emailEnd);
} }
/** /** @return the timestamp of the identity. */
* @return the timestamp of the identity.
* @since 4.1
*/
public Date getWhen() { public Date getWhen() {
return new Date(when); return new Date(when);
} }
/** /**
* @return this person's declared time zone; null if the timezone is unknown. * @return this person's declared time zone; null if the timezone is unknown.
* @since 4.1
*/ */
public TimeZone getTimeZone() { public TimeZone getTimeZone() {
return PersonIdent.getTimeZone(tzOffset); return PersonIdent.getTimeZone(tzOffset);
@ -250,7 +239,6 @@ public class PushCertificateIdent {
/** /**
* @return this person's declared time zone as minutes east of UTC. If the * @return this person's declared time zone as minutes east of UTC. If the
* timezone is to the west of UTC it is negative. * timezone is to the west of UTC it is negative.
* @since 4.1
*/ */
public int getTimeZoneOffset() { public int getTimeZoneOffset() {
return tzOffset; return tzOffset;

24
org.eclipse.jgit/src/org/eclipse/jgit/transport/SignedPushConfig.java

@ -52,11 +52,7 @@ import org.eclipse.jgit.lib.Config.SectionParser;
* @since 4.1 * @since 4.1
*/ */
public class SignedPushConfig { public class SignedPushConfig {
/** /** Key for {@link Config#get(SectionParser)}. */
* Key for {@link Config#get(SectionParser)}.
*
* @since 4.1
*/
public static final SectionParser<SignedPushConfig> KEY = public static final SectionParser<SignedPushConfig> KEY =
new SectionParser<SignedPushConfig>() { new SectionParser<SignedPushConfig>() {
public SignedPushConfig parse(Config cfg) { public SignedPushConfig parse(Config cfg) {
@ -67,11 +63,7 @@ public class SignedPushConfig {
String certNonceSeed; String certNonceSeed;
int certNonceSlopLimit; int certNonceSlopLimit;
/** /** Create a new config with default values disabling push verification. */
* Create a new config with default values disabling push verification.
*
* @since 4.1
*/
public SignedPushConfig() { public SignedPushConfig() {
} }
@ -87,16 +79,12 @@ public class SignedPushConfig {
* *
* @param seed * @param seed
* new seed value. * new seed value.
* @since 4.1
*/ */
public void setCertNonceSeed(String seed) { public void setCertNonceSeed(String seed) {
certNonceSeed = seed; certNonceSeed = seed;
} }
/** /** @return the configured seed used by the nonce verifier. */
* @return the configured seed used by the nonce verifier.
* @since 4.1
*/
public String getCertNonceSeed() { public String getCertNonceSeed() {
return certNonceSeed; return certNonceSeed;
} }
@ -108,16 +96,12 @@ public class SignedPushConfig {
* *
* @param limit * @param limit
* new limit in seconds. * new limit in seconds.
* @since 4.1
*/ */
public void setCertNonceSlopLimit(int limit) { public void setCertNonceSlopLimit(int limit) {
certNonceSlopLimit = limit; certNonceSlopLimit = limit;
} }
/** /** @return the configured nonce slop limit. */
* @return the configured nonce slop limit.
* @since 4.1
*/
public int getCertNonceSlopLimit() { public int getCertNonceSlopLimit() {
return certNonceSlopLimit; return certNonceSlopLimit;
} }

Loading…
Cancel
Save