From 9b2f8ced9018dad519fefdc19d3940104b95434a Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Sat, 18 Apr 2020 00:00:32 +0200 Subject: [PATCH] Bazel: Disable SecurityManagerMissingPermissionsTest test In Id5376f09f0d a test with dependency on log4j library was added, but the library was missed to be added to the Bazel build tool chain. Given that Bazel test runner doesn't suport custom security manager the test wouldn't pass even if the missing dependency would be added. The only solution we have for now is to exclude that test from Bazel tool chain. Filed a feature request for bazel to support such tests at https://github.com/bazelbuild/bazel/issues/11146 Bug: 562274 Change-Id: I873a0e09addc583455b68122f66cd3952e485f0e Signed-off-by: David Ostrovsky Signed-off-by: Matthias Sohn --- org.eclipse.jgit.test/BUILD | 1 + org.eclipse.jgit.test/tests.bzl | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/org.eclipse.jgit.test/BUILD b/org.eclipse.jgit.test/BUILD index b34ef2a79..3c4c61bfb 100644 --- a/org.eclipse.jgit.test/BUILD +++ b/org.eclipse.jgit.test/BUILD @@ -40,6 +40,7 @@ DATA = [ EXCLUDED = [ PKG + "api/SecurityManagerTest.java", + PKG + "api/SecurityManagerMissingPermissionsTest.java", ] RESOURCES = glob(["resources/**"]) diff --git a/org.eclipse.jgit.test/tests.bzl b/org.eclipse.jgit.test/tests.bzl index f27efccc2..d03031645 100644 --- a/org.eclipse.jgit.test/tests.bzl +++ b/org.eclipse.jgit.test/tests.bzl @@ -42,6 +42,10 @@ def tests(tests): additional_deps = [ "//lib:jsch", ] + if src.endswith("SecurityManagerMissingPermissionsTest.java"): + additional_deps = [ + "//lib:log4j", + ] if src.endswith("JSchSshTest.java"): additional_deps = [ "//lib:jsch",