Merge "Create all test data in trash folder"

org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/LocalDiskRepositoryTestCase.java

@@ -293,17 +293,31 @@ public abstract class LocalDiskRepositoryTestCase {
 	 *             the repository could not be created in the temporary area
 	 */
 	private FileRepository createRepository(boolean bare) throws IOException {
-		String uniqueId = System.currentTimeMillis() + "_" + (testCount++);
+		File gitdir = createUniqueTestGitDir(bare);
-		String gitdirName = "test" + uniqueId + (bare ? "" : "/") + Constants.DOT_GIT;
-		File gitdir = new File(trash, gitdirName).getCanonicalFile();
 		FileRepository db = new FileRepository(gitdir);
-
 		assertFalse(gitdir.exists());
 		db.create();
 		toClose.add(db);
 		return db;
 	}
 
+	/**
+	 * Creates a new unique directory for a test repository
+	 *
+	 * @param bare
+	 *            true for a bare repository; false for a repository with a
+	 *            working directory
+	 * @return a unique directory for a test repository
+	 * @throws IOException
+	 */
+	protected File createUniqueTestGitDir(boolean bare) throws IOException {
+		String uniqueId = System.currentTimeMillis() + "_" + (testCount++);
+		String gitdirName = "test" + uniqueId + (bare ? "" : "/")
+				+ Constants.DOT_GIT;
+		File gitdir = new File(trash, gitdirName).getCanonicalFile();
+		return gitdir;
+	}
+
 	/**
 	 * Run a hook script in the repository, returning the exit status.
 	 *

org.eclipse.jgit.test/tst/org/eclipse/jgit/api/GitConstructionTest.java

@@ -68,7 +68,8 @@ public class GitConstructionTest extends RepositoryTestCase {
 		git.commit().setMessage("Initial commit").call();
 
 		bareRepo = Git.cloneRepository().setBare(true)
-				.setURI(db.getDirectory().toURI().toString()).call()
+				.setURI(db.getDirectory().toURI().toString())
+				.setDirectory(createUniqueTestGitDir(true)).call()
 				.getRepository();
 	}