From 6f4cf8daec4e4450706727fff1084f9c62423d26 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg Date: Sun, 13 Jun 2010 03:19:47 +0200 Subject: [PATCH] Make inner classes static in http code Static classes are preferrable to keep unwanted dependencies away, and they have one less member field. Signed-off-by: Robin Rosenberg --- .../tst/org/eclipse/jgit/http/test/AsIsServiceTest.java | 2 +- .../eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java | 2 +- .../eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java index ea937481d..2650db2fa 100644 --- a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java +++ b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/AsIsServiceTest.java @@ -112,7 +112,7 @@ public class AsIsServiceTest extends LocalDiskRepositoryTestCase { service.access(new R("bob", "1.2.3.4"), db); } - private final class R extends HttpServletRequestWrapper { + private static final class R extends HttpServletRequestWrapper { private final String user; private final String host; diff --git a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java index 5338caaa4..4d05a085c 100644 --- a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java +++ b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultReceivePackFactoryTest.java @@ -174,7 +174,7 @@ public class DefaultReceivePackFactoryTest extends LocalDiskRepositoryTestCase { assertNotNull("have ReceivePack", rp); } - private final class R extends HttpServletRequestWrapper { + private static final class R extends HttpServletRequestWrapper { private final String user; private final String host; diff --git a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java index 8f57d40af..423361e06 100644 --- a/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java +++ b/org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/DefaultUploadPackFactoryTest.java @@ -136,7 +136,7 @@ public class DefaultUploadPackFactoryTest extends LocalDiskRepositoryTestCase { assertSame(db, up.getRepository()); } - private final class R extends HttpServletRequestWrapper { + private static final class R extends HttpServletRequestWrapper { private final String user; private final String host;