From 6cbc99d3ee1e7221f0b72f20012347c181902cfa Mon Sep 17 00:00:00 2001 From: Matthias Sohn Date: Mon, 19 Dec 2016 00:02:43 +0100 Subject: [PATCH] [infer] Fix resource leaks in DfsInserter Bug: 509385 Change-Id: Id5dc40bb3fb9da97ea0795cca1f2bcdcde347767 Signed-off-by: Matthias Sohn --- .../org/eclipse/jgit/internal/storage/dfs/DfsInserter.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsInserter.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsInserter.java index a5e920a75..c179e7778 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsInserter.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsInserter.java @@ -312,8 +312,7 @@ public class DfsInserter extends ObjectInserter { } DfsOutputStream os = db.writeFile(pack, INDEX); - try { - CountingOutputStream cnt = new CountingOutputStream(os); + try (CountingOutputStream cnt = new CountingOutputStream(os)) { if (buf != null) buf.writeTo(cnt, null); else @@ -321,7 +320,9 @@ public class DfsInserter extends ObjectInserter { pack.addFileExt(INDEX); pack.setFileSize(INDEX, cnt.getCount()); } finally { - os.close(); + if (buf != null) { + buf.close(); + } } return packIndex; }