From 57853e494972e7a9a6248648fd9f8479844c5348 Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Thu, 9 Jun 2011 17:55:52 -0700 Subject: [PATCH] DHT: Always have at least one recent chunk in DhtReader The RecentChunks cache assumes there is always at least one recent chunk in the maxSize that it receives from the DhtReaderOptions. Ensure that is true by requiring the size to be at least 1. Running with 0 recent chunk cache is very a bad idea, often during commit walking the parents of a commit will be found on the same chunk as the commit that was just accessed. In these cases its a good idea to keep that last chunk around so the parents can be quickly accessed. Change-Id: I33b65286e8a4cbf6ef4ced28c547837f173e065d Signed-off-by: Shawn O. Pearce --- .../src/org/eclipse/jgit/storage/dht/DhtReaderOptions.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jgit.storage.dht/src/org/eclipse/jgit/storage/dht/DhtReaderOptions.java b/org.eclipse.jgit.storage.dht/src/org/eclipse/jgit/storage/dht/DhtReaderOptions.java index 0890e39ad..8376e2b6b 100644 --- a/org.eclipse.jgit.storage.dht/src/org/eclipse/jgit/storage/dht/DhtReaderOptions.java +++ b/org.eclipse.jgit.storage.dht/src/org/eclipse/jgit/storage/dht/DhtReaderOptions.java @@ -240,7 +240,7 @@ public class DhtReaderOptions { * @return {@code this} */ public DhtReaderOptions setRecentChunkCacheSize(int chunkCnt) { - recentChunkCacheSize = Math.max(0, chunkCnt); + recentChunkCacheSize = Math.max(1, chunkCnt); return this; }