Browse Source

Speed up PathFilterGroup.include for large set of paths

This requires that we internally sort all paths so content of
directories follow the directory immediately.

Bug: 397185
Change-Id: I3e9735c7bdd99437929da8f9c9d4960a1273054b
stable-2.3
Robin Rosenberg 12 years ago
parent
commit
576e5acdd0
  1. 70
      org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/PathFilterGroup.java

70
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/PathFilterGroup.java

@ -177,33 +177,73 @@ public class PathFilterGroup {
} }
static class Group extends TreeFilter { static class Group extends TreeFilter {
private static final Comparator<PathFilter> PATH_SORT = new Comparator<PathFilter>() { private static int pathPrefixSortCompare(byte[] p1, byte[] p2,
boolean justMatch) {
int ci = 0;
while (ci < p1.length && ci < p2.length) {
int c1 = p1[ci];
int c2 = p2[ci];
if (c1 == '/')
c1 = 0;
if (c2 == '/')
c2 = 0;
int cmp = c1 - c2;
if (cmp != 0)
return cmp;
++ci;
}
if (ci < p1.length) {
int c1 = p1[ci];
if (c1 == '/')
if (justMatch)
return 0;
return 1;
}
if (ci < p2.length) {
int c2 = p2[ci];
if (c2 == '/')
return 0;
return -1;
}
return 0;
}
private static final Comparator<PathFilter> PATH_PREFIX_SORT = new Comparator<PathFilter>() {
public int compare(final PathFilter o1, final PathFilter o2) { public int compare(final PathFilter o1, final PathFilter o2) {
return o1.pathStr.compareTo(o2.pathStr); return pathPrefixSortCompare(o1.pathRaw, o2.pathRaw, false);
} }
}; };
private final PathFilter[] paths; private final PathFilter[] paths;
private Group(final PathFilter[] p) { private Group(final PathFilter[] p) {
paths = p; paths = p;
Arrays.sort(paths, PATH_SORT); Arrays.sort(paths, PATH_PREFIX_SORT);
} }
@Override @Override
public boolean include(final TreeWalk walker) { public boolean include(final TreeWalk walker) {
final int n = paths.length; final byte[] rawPath = walker.getRawPath();
for (int i = 0;;) { Comparator comparator = new Comparator<Object>() {
final byte[] r = paths[i].pathRaw; public int compare(Object pf, Object raw) {
final int cmp = walker.isPathPrefix(r, r.length); PathFilter pathFilter = (PathFilter) pf;
if (cmp == 0) int ret = -pathPrefixSortCompare(walker.getRawPath(),
return true; pathFilter.pathRaw, true);
if (++i < n) return ret;
continue; }
if (cmp > 0) };
throw StopWalkException.INSTANCE;
return false; Object[] pathsObject = paths;
} Object rawObject = rawPath;
@SuppressWarnings("unchecked")
int position = Arrays.binarySearch(pathsObject, rawObject,
comparator);
if (position >= 0)
return true;
if (position == -paths.length - 1)
throw StopWalkException.INSTANCE;
return false;
} }
@Override @Override

Loading…
Cancel
Save