From 4e5944fbf8579fddc8b81ae11484b392cc6fc527 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg Date: Wed, 6 Jun 2012 02:26:53 +0200 Subject: [PATCH] Removed unused parameters from private methods Change-Id: I60bc03b9550ccd2350918e6328276ec9839748d5 Signed-off-by: Matthias Sohn --- .../src/org/eclipse/jgit/diff/DiffFormatter.java | 4 ++-- .../src/org/eclipse/jgit/transport/URIish.java | 11 +++++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java b/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java index ceb4cb0c0..4258f7409 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java @@ -963,7 +963,7 @@ public class DiffFormatter { if (entry.getMode(side).getObjectType() != Constants.OBJ_BLOB) return EMPTY; - if (isBinary(entry.getPath(side))) + if (isBinary()) return BINARY; AbbreviatedObjectId id = entry.getId(side); @@ -1004,7 +1004,7 @@ public class DiffFormatter { } } - private boolean isBinary(String path) { + private boolean isBinary() { return false; } diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java index 9b061329f..f2d3c8c23 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java @@ -591,15 +591,14 @@ public class URIish implements Serializable { * @return the URI, including its password field, if any. */ public String toPrivateString() { - return format(true, false, false); + return format(true, false); } public String toString() { - return format(false, false, false); + return format(false, false); } - private String format(final boolean includePassword, boolean escape, - boolean escapeNonAscii) { + private String format(final boolean includePassword, boolean escapeNonAscii) { final StringBuilder r = new StringBuilder(); if (getScheme() != null) { r.append(getScheme()); @@ -646,7 +645,7 @@ public class URIish implements Serializable { * @return the URI as an ASCII string. Password is not included. */ public String toASCIIString() { - return format(false, true, true); + return format(false, true); } /** @@ -654,7 +653,7 @@ public class URIish implements Serializable { * such that it will be valid for use over the network. */ public String toPrivateASCIIString() { - return format(true, true, true); + return format(true, true); } /**