Browse Source

pgm: Handle exceptions in Branch command

This avoids we show a stacktrace on the console by default when one of
the expected exceptions is thrown during the run method is executed.

Change-Id: Ib07cc8dd26b45b62de1d77739380eb36833082f1
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
stable-5.4
Matthias Sohn 6 years ago
parent
commit
4d4fe5230e
  1. 25
      org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Branch.java

25
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Branch.java

@ -54,6 +54,7 @@ import java.util.Map.Entry;
import org.eclipse.jgit.api.Git; import org.eclipse.jgit.api.Git;
import org.eclipse.jgit.api.ListBranchCommand; import org.eclipse.jgit.api.ListBranchCommand;
import org.eclipse.jgit.api.ListBranchCommand.ListMode; import org.eclipse.jgit.api.ListBranchCommand.ListMode;
import org.eclipse.jgit.api.errors.GitAPIException;
import org.eclipse.jgit.lib.Constants; import org.eclipse.jgit.lib.Constants;
import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.lib.ObjectId;
import org.eclipse.jgit.lib.ObjectReader; import org.eclipse.jgit.lib.ObjectReader;
@ -182,15 +183,17 @@ class Branch extends TextBuiltin {
/** {@inheritDoc} */ /** {@inheritDoc} */
@Override @Override
protected void run() throws Exception { protected void run() {
if (delete != null || deleteForce != null) { try {
if (delete != null) { if (delete != null || deleteForce != null) {
delete(delete, false); if (delete != null) {
} delete(delete, false);
if (deleteForce != null) { }
delete(deleteForce, true); if (deleteForce != null) {
delete(deleteForce, true);
}
return;
} }
} else {
if (rename) { if (rename) {
String src, dst; String src, dst;
if (otherBranch == null) { if (otherBranch == null) {
@ -264,10 +267,12 @@ class Branch extends TextBuiltin {
} }
list(); list();
} }
} catch (IOException | GitAPIException e) {
throw die(e.getMessage(), e);
} }
} }
private void list() throws Exception { private void list() throws IOException, GitAPIException {
Ref head = db.exactRef(Constants.HEAD); Ref head = db.exactRef(Constants.HEAD);
// This can happen if HEAD is stillborn // This can happen if HEAD is stillborn
if (head != null) { if (head != null) {
@ -316,7 +321,7 @@ class Branch extends TextBuiltin {
} }
private void printHead(final ObjectReader reader, final String ref, private void printHead(final ObjectReader reader, final String ref,
final boolean isCurrent, final Ref refObj) throws Exception { final boolean isCurrent, final Ref refObj) throws IOException {
outw.print(isCurrent ? '*' : ' '); outw.print(isCurrent ? '*' : ' ');
outw.print(' '); outw.print(' ');
outw.print(ref); outw.print(ref);

Loading…
Cancel
Save