From 3fc5791778bbd1d33da34698d0054619f4cad56c Mon Sep 17 00:00:00 2001 From: Shawn Pearce Date: Fri, 14 Feb 2014 09:46:52 -0800 Subject: [PATCH] Add missing static qualifier in DiffFormatter These methods do not touch instance members and can avoid the implicit "this" argument. Change-Id: I01c30bb22266eed1c9db18bdf9f90c1c1590e3ec Signed-off-by: Matthias Sohn --- org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java b/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java index f660d6bbd..9e26c3747 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java @@ -633,7 +633,7 @@ public class DiffFormatter { format(res.header, res.a, res.b); } - private void writeGitLinkDiffText(OutputStream o, DiffEntry ent) + private static void writeGitLinkDiffText(OutputStream o, DiffEntry ent) throws IOException { if (ent.getOldMode() == GITLINK) { o.write(encodeASCII("-Subproject commit " + ent.getOldId().name() //$NON-NLS-1$ @@ -757,7 +757,7 @@ public class DiffFormatter { writeLine(' ', text, line); } - private boolean isEndOfLineMissing(final RawText text, final int line) { + private static boolean isEndOfLineMissing(final RawText text, final int line) { return line + 1 == text.size() && text.isMissingNewlineAtEnd(); }