s/StringBuffer/StringBuilder as appropriate where no concurrency is needed

org.eclipse.jgit/src/org/eclipse/jgit/lib/Config.java

@@ -118,7 +118,7 @@ public class Config {
 	private static String escapeValue(final String x) {
 		boolean inquote = false;
 		int lineStart = 0;
-		final StringBuffer r = new StringBuffer(x.length());
+		final StringBuilder r = new StringBuilder(x.length());
 		for (int k = 0; k < x.length(); k++) {
 			final char c = x.charAt(k);
 			switch (c) {
@@ -897,7 +897,7 @@ public class Config {
 
 	private static String readKeyName(final StringReader in)
 			throws ConfigInvalidException {
-		final StringBuffer name = new StringBuffer();
+		final StringBuilder name = new StringBuilder();
 		for (;;) {
 			int c = in.read();
 			if (c < 0)
@@ -944,7 +944,7 @@ public class Config {
 
 	private static String readValue(final StringReader in, boolean quote,
 			final int eol) throws ConfigInvalidException {
-		final StringBuffer value = new StringBuffer();
+		final StringBuilder value = new StringBuilder();
 		boolean space = false;
 		for (;;) {
 			int c = in.read();

org.eclipse.jgit/src/org/eclipse/jgit/lib/FileTreeEntry.java

@@ -106,7 +106,7 @@ public class FileTreeEntry extends TreeEntry {
 	}
 
 	public String toString() {
-		final StringBuffer r = new StringBuffer();
+		final StringBuilder r = new StringBuilder();
 		r.append(ObjectId.toString(getId()));
 		r.append(' ');
 		r.append(isExecutable() ? 'X' : 'F');

org.eclipse.jgit/src/org/eclipse/jgit/lib/GitlinkTreeEntry.java

@@ -83,7 +83,7 @@ public class GitlinkTreeEntry extends TreeEntry {
 
 	@Override
 	public String toString() {
-		final StringBuffer r = new StringBuffer();
+		final StringBuilder r = new StringBuilder();
 		r.append(ObjectId.toString(getId()));
 		r.append(" G ");
 		r.append(getFullName());

org.eclipse.jgit/src/org/eclipse/jgit/lib/PersonIdent.java

@@ -251,7 +251,7 @@ public class PersonIdent {
 	 * @return this person's declared time zone; null if time zone is unknown.
 	 */
 	public TimeZone getTimeZone() {
-		StringBuffer tzId = new StringBuffer(8);
+		StringBuilder tzId = new StringBuilder(8);
 		tzId.append("GMT");
 		appendTimezone(tzId);
 		return TimeZone.getTimeZone(tzId.toString());
@@ -285,7 +285,7 @@ public class PersonIdent {
 	 * @return a string in the git author format
 	 */
 	public String toExternalString() {
-		final StringBuffer r = new StringBuffer();
+		final StringBuilder r = new StringBuilder();
 		r.append(getName());
 		r.append(" <");
 		r.append(getEmailAddress());
@@ -296,7 +296,7 @@ public class PersonIdent {
 		return r.toString();
 	}
 
-	private void appendTimezone(final StringBuffer r) {
+	private void appendTimezone(final StringBuilder r) {
 		int offset = tzOffset;
 		final char sign;
 		final int offsetHours;
@@ -324,7 +324,7 @@ public class PersonIdent {
 	}
 
 	public String toString() {
-		final StringBuffer r = new StringBuffer();
+		final StringBuilder r = new StringBuilder();
 		final SimpleDateFormat dtfmt;
 		dtfmt = new SimpleDateFormat("EEE MMM d HH:mm:ss yyyy Z", Locale.US);
 		dtfmt.setTimeZone(getTimeZone());

org.eclipse.jgit/src/org/eclipse/jgit/lib/SymlinkTreeEntry.java

@@ -81,7 +81,7 @@ public class SymlinkTreeEntry extends TreeEntry {
 	}
 
 	public String toString() {
-		final StringBuffer r = new StringBuffer();
+		final StringBuilder r = new StringBuilder();
 		r.append(ObjectId.toString(getId()));
 		r.append(" S ");
 		r.append(getFullName());

org.eclipse.jgit/src/org/eclipse/jgit/lib/Tag.java

@@ -163,7 +163,7 @@ public class Tag {
 						throw new CorruptObjectException(tagId, "no tagger/bad header");
 
 				// Message should start with an empty line, but
-				StringBuffer tempMessage = new StringBuffer();
+				StringBuilder tempMessage = new StringBuilder();
 				char[] readBuf = new char[2048];
 				int readLen;
 				while ((readLen = br.read(readBuf)) > 0) {

org.eclipse.jgit/src/org/eclipse/jgit/lib/Tree.java

@@ -598,7 +598,7 @@ public class Tree extends TreeEntry implements Treeish {
 	}
 
 	public String toString() {
-		final StringBuffer r = new StringBuffer();
+		final StringBuilder r = new StringBuilder();
 		r.append(ObjectId.toString(getId()));
 		r.append(" T ");
 		r.append(getFullName());

org.eclipse.jgit/src/org/eclipse/jgit/lib/TreeEntry.java

@@ -210,7 +210,7 @@ public abstract class TreeEntry implements Comparable {
 	 * @return repository relative name of this entry
 	 */
 	public String getFullName() {
-		final StringBuffer r = new StringBuffer();
+		final StringBuilder r = new StringBuilder();
 		appendFullName(r);
 		return r.toString();
 	}
@@ -285,7 +285,7 @@ public abstract class TreeEntry implements Comparable {
 	 */
 	public abstract FileMode getMode();
 
-	private void appendFullName(final StringBuffer r) {
+	private void appendFullName(final StringBuilder r) {
 		final TreeEntry p = getParent();
 		final String n = getName();
 		if (p != null) {

org.eclipse.jgit/src/org/eclipse/jgit/revwalk/filter/AndRevFilter.java

@@ -170,7 +170,7 @@ public abstract class AndRevFilter extends RevFilter {
 
 		@Override
 		public String toString() {
-			final StringBuffer r = new StringBuffer();
+			final StringBuilder r = new StringBuilder();
 			r.append("(");
 			for (int i = 0; i < subfilters.length; i++) {
 				if (i > 0)

org.eclipse.jgit/src/org/eclipse/jgit/revwalk/filter/OrRevFilter.java

@@ -168,7 +168,7 @@ public abstract class OrRevFilter extends RevFilter {
 
 		@Override
 		public String toString() {
-			final StringBuffer r = new StringBuffer();
+			final StringBuilder r = new StringBuilder();
 			r.append("(");
 			for (int i = 0; i < subfilters.length; i++) {
 				if (i > 0)

org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/AndTreeFilter.java

@@ -182,7 +182,7 @@ public abstract class AndTreeFilter extends TreeFilter {
 
 		@Override
 		public String toString() {
-			final StringBuffer r = new StringBuffer();
+			final StringBuilder r = new StringBuilder();
 			r.append("(");
 			for (int i = 0; i < subfilters.length; i++) {
 				if (i > 0)

org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/OrTreeFilter.java

@@ -180,7 +180,7 @@ public abstract class OrTreeFilter extends TreeFilter {
 
 		@Override
 		public String toString() {
-			final StringBuffer r = new StringBuffer();
+			final StringBuilder r = new StringBuilder();
 			r.append("(");
 			for (int i = 0; i < subfilters.length; i++) {
 				if (i > 0)

org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/PathFilterGroup.java

@@ -192,7 +192,7 @@ public class PathFilterGroup {
 		}
 
 		public String toString() {
-			final StringBuffer r = new StringBuffer();
+			final StringBuilder r = new StringBuilder();
 			r.append("FAST(");
 			for (int i = 0; i < paths.length; i++) {
 				if (i > 0)