Browse Source

Merge "InternalPushConnection: don't swallow RuntimeException"

stable-5.2
Dave Borowitz 6 years ago committed by Gerrit Code Review @ Eclipse.org
parent
commit
0e5cc09afe
  1. 12
      org.eclipse.jgit/src/org/eclipse/jgit/transport/InternalPushConnection.java

12
org.eclipse.jgit/src/org/eclipse/jgit/transport/InternalPushConnection.java

@ -46,6 +46,7 @@ package org.eclipse.jgit.transport;
import java.io.IOException; import java.io.IOException;
import java.io.PipedInputStream; import java.io.PipedInputStream;
import java.io.PipedOutputStream; import java.io.PipedOutputStream;
import java.io.UncheckedIOException;
import org.eclipse.jgit.errors.TransportException; import org.eclipse.jgit.errors.TransportException;
import org.eclipse.jgit.internal.JGitText; import org.eclipse.jgit.internal.JGitText;
@ -103,10 +104,13 @@ class InternalPushConnection<C> extends BasePackPushConnection {
// Ignored. Client cannot use this repository. // Ignored. Client cannot use this repository.
} catch (ServiceNotAuthorizedException e) { } catch (ServiceNotAuthorizedException e) {
// Ignored. Client cannot use this repository. // Ignored. Client cannot use this repository.
} catch (IOException err) { } catch (IOException e) {
// Client side of the pipes should report the problem. // Since the InternalPushConnection
} catch (RuntimeException err) { // is used in tests, we want to avoid hiding exceptions
// Clients side will notice we went away, and report. // because they can point to programming errors on the server
// side. By rethrowing, the default handler will dump it
// to stderr.
throw new UncheckedIOException(e);
} finally { } finally {
try { try {
out_r.close(); out_r.close();

Loading…
Cancel
Save