From 05896dabfc28b57d3c254b055be9e9bd9f1e32a0 Mon Sep 17 00:00:00 2001 From: Robin Rosenberg Date: Tue, 15 Jul 2014 11:37:10 +0200 Subject: [PATCH] Drop warnings about unchecked casts in a few stable select places Change-Id: Ie163a4940f0d13bbdefd8c4643c0944c71800544 --- .../src/org/eclipse/jgit/nls/GlobalBundleCache.java | 1 + .../src/org/eclipse/jgit/revplot/AbstractPlotRenderer.java | 3 +-- org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommit.java | 1 + .../src/org/eclipse/jgit/revplot/PlotCommitList.java | 3 +++ .../src/org/eclipse/jgit/revwalk/RevCommitList.java | 2 ++ .../src/org/eclipse/jgit/revwalk/RevObjectList.java | 2 ++ org.eclipse.jgit/src/org/eclipse/jgit/transport/Daemon.java | 1 + 7 files changed, 11 insertions(+), 2 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/nls/GlobalBundleCache.java b/org.eclipse.jgit/src/org/eclipse/jgit/nls/GlobalBundleCache.java index c95689ccb..d880d9b61 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/nls/GlobalBundleCache.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/nls/GlobalBundleCache.java @@ -82,6 +82,7 @@ class GlobalBundleCache { * @exception TranslationBundleLoadingException see {@link TranslationBundle#load(Locale)} * @exception TranslationStringMissingException see {@link TranslationBundle#load(Locale)} */ + @SuppressWarnings("unchecked") static synchronized T lookupBundle(Locale locale, Class type) { try { Map bundles = cachedBundles.get(locale); diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revplot/AbstractPlotRenderer.java b/org.eclipse.jgit/src/org/eclipse/jgit/revplot/AbstractPlotRenderer.java index 0fac3af9b..6ba0dfed0 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/revplot/AbstractPlotRenderer.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/revplot/AbstractPlotRenderer.java @@ -91,6 +91,7 @@ public abstract class AbstractPlotRenderer { * @param h * total height (in pixels) of this cell. */ + @SuppressWarnings("unchecked") protected void paintCommit(final PlotCommit commit, final int h) { final int dotSize = computeDotSize(h); final TLane myLane = commit.getLane(); @@ -114,7 +115,6 @@ public abstract class AbstractPlotRenderer { LINE_WIDTH); for (int i = 0; i < commit.mergingLanes.length; i++) { - @SuppressWarnings("unchecked") final TLane pLane = (TLane) commit.mergingLanes[i]; final TColor pColor = laneColor(pLane); final int cx = laneC(pLane); @@ -138,7 +138,6 @@ public abstract class AbstractPlotRenderer { if (commit.getChildCount() > 0) { for (int i = 0; i < commit.forkingOffLanes.length; i++) { - @SuppressWarnings("unchecked") final TLane childLane = (TLane) commit.forkingOffLanes[i]; final TColor cColor = laneColor(childLane); final int cx = laneC(childLane); diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommit.java b/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommit.java index dba68465c..2e8aab885 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommit.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommit.java @@ -198,6 +198,7 @@ public class PlotCommit extends RevCommit { * * @return the assigned lane for this commit. */ + @SuppressWarnings("unchecked") public final L getLane() { return (L) lane; } diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommitList.java b/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommitList.java index 3444c8df1..6102a8148 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommitList.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommitList.java @@ -115,6 +115,7 @@ public class PlotCommitList extends * @param result * collection to add the passing lanes into. */ + @SuppressWarnings("unchecked") public void findPassingThrough(final PlotCommit currCommit, final Collection result) { for (final PlotLane p : currCommit.passingLanes) @@ -343,6 +344,7 @@ public class PlotCommitList extends } } + @SuppressWarnings("unchecked") private void closeLane(PlotLane lane) { if (activeLanes.remove(lane)) { recycleLane((L) lane); @@ -395,6 +397,7 @@ public class PlotCommitList extends /** * @return a new Lane appropriate for this particular PlotList. */ + @SuppressWarnings("unchecked") protected L createLane() { return (L) new PlotLane(); } diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommitList.java b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommitList.java index 835e0ce22..64f99bbd2 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommitList.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommitList.java @@ -297,6 +297,7 @@ public class RevCommitList extends RevObjectList { * @throws MissingObjectException * see {@link RevWalk#next()} */ + @SuppressWarnings("unchecked") public void fillTo(final int highMark) throws MissingObjectException, IncorrectObjectTypeException, IOException { if (walker == null || size > highMark) @@ -361,6 +362,7 @@ public class RevCommitList extends RevObjectList { * @throws MissingObjectException * see {@link RevWalk#next()} */ + @SuppressWarnings("unchecked") public void fillTo(final RevCommit commitToLoad, int highMark) throws MissingObjectException, IncorrectObjectTypeException, IOException { diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevObjectList.java b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevObjectList.java index a05cc9046..5052a4dea 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevObjectList.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevObjectList.java @@ -87,6 +87,7 @@ public class RevObjectList extends AbstractList { size++; } + @SuppressWarnings("unchecked") public E set(int index, E element) { Block s = contents; while (index >> s.shift >= BLOCK_SIZE) { @@ -106,6 +107,7 @@ public class RevObjectList extends AbstractList { return (E) old; } + @SuppressWarnings("unchecked") public E get(int index) { Block s = contents; if (index >> s.shift >= 1024) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/Daemon.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/Daemon.java index 89f0764a5..03f7c7283 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/Daemon.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/Daemon.java @@ -103,6 +103,7 @@ public class Daemon { * address to listen for connections on. If null, any available * port will be chosen on all network interfaces. */ + @SuppressWarnings("unchecked") public Daemon(final InetSocketAddress addr) { myAddress = addr; processors = new ThreadGroup("Git-Daemon"); //$NON-NLS-1$