compose-jb

1994 Commits

244 Branches

378 Tags

388 MiB

Tree: be21564689

Commit Graph

Author	SHA1	Message	Date
Igor Demin	a785048e62	Fix Failed to apply plugin class ‘org.gradle.toolchains.foojay.FoojayToolchainsPlugin’. (#3677 ) https://teamcity.jetbrains.com/buildConfiguration/JetBrainsPublicProjects_Compose_PublishFast_4ValidateTemplatesTutorials/4312787?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildProblemsSection=true	1 year ago
Igor Demin	021b099e1c	Add org.gradle.toolchains.foojay-resolver-convention to the examples (#3666 ) According to https://developer.android.com/build/jdks we should: 1. [use JDK 17 for API 34](https://developer.android.com/build/jdks#compileSdk) 2. [use toolchain](https://developer.android.com/build/jdks#toolchain): ``` We recommend that you always specify the Java toolchain, and either ensure that the specified JDK is installed, or add a toolchain resolver to your build. ``` As we don't want to force people to have JDK 17 on their machine, we apply toolchain resolver that is recommended by Gradle: ``` id("org.gradle.toolchains.foojay-resolver-convention") version("0.4.0") ``` ## Test 1. Remove JDK 17 from the computer, remove `jvmToolchain(17)` 2. Run `./gradlew assembleDebug` 3. It should fail with: ``` > Could not create task ':androidApp:compileDebugJavaWithJavac'. > Failed to calculate the value of task ':androidApp:compileDebugJavaWithJavac' property 'javaCompiler'. > No matching toolchains found for requested specification: {languageVersion=17, vendor=any, implementation=vendor-specific} for WINDOWS on x86_64. > No locally installed toolchains match and toolchain download repositories have not been configured. ``` 4. restore `jvmToolchain(17)` 5. Run `./gradlew assembleDebug` again 6. It should succeed ## Issues Fixes https://github.com/JetBrains/compose-multiplatform/issues/3615	1 year ago
Igor Demin	d44114d8b9	Compose Multiplatform 1.4.0 docs (#3044 )	2 years ago

Author

SHA1

Message

Date

Igor Demin

a785048e62

Fix Failed to apply plugin class ‘org.gradle.toolchains.foojay.FoojayToolchainsPlugin’. (#3677 )

https://teamcity.jetbrains.com/buildConfiguration/JetBrainsPublicProjects_Compose_PublishFast_4ValidateTemplatesTutorials/4312787?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildProblemsSection=true

1 year ago

Igor Demin

021b099e1c

Add org.gradle.toolchains.foojay-resolver-convention to the examples (#3666 )

According to https://developer.android.com/build/jdks we should:

1. [use JDK 17 for API 34](https://developer.android.com/build/jdks#compileSdk)
2. [use toolchain](https://developer.android.com/build/jdks#toolchain):
```
We recommend that you always specify the Java toolchain, and either ensure that the specified JDK is installed, or add a toolchain resolver to your build.
```

As we don't want to force people to have JDK 17 on their machine, we apply toolchain resolver that is recommended by Gradle:
```
id("org.gradle.toolchains.foojay-resolver-convention") version("0.4.0")
```

## Test
1. Remove JDK 17 from the computer, remove `jvmToolchain(17)`
2. Run `./gradlew assembleDebug`
3. It should fail with:
```
> Could not create task ':androidApp:compileDebugJavaWithJavac'.
   > Failed to calculate the value of task ':androidApp:compileDebugJavaWithJavac' property 'javaCompiler'.
      > No matching toolchains found for requested specification: {languageVersion=17, vendor=any, implementation=vendor-specific} for WINDOWS on x86_64.
         > No locally installed toolchains match and toolchain download repositories have not been configured.
```
4. restore `jvmToolchain(17)`
5. Run `./gradlew assembleDebug` again
6. It should succeed

## Issues
Fixes https://github.com/JetBrains/compose-multiplatform/issues/3615

1 year ago

Igor Demin

d44114d8b9

Compose Multiplatform 1.4.0 docs (#3044 )

2 years ago

3 Commits (be21564689f1bf154f6febaa154f46599a2c034c)