compose-jb

Commit Graph

Author	SHA1	Message	Date
Andrei Salavei	9e25001e9e	Fixed a crash when selecting empty rows in codeviewer example (#3854 ) Due to [known problem](https://partnerissuetracker.corp.google.com/issues/199919707), the application crashes when selecting lines with empty text. The fix does 2 things: - Prevents `SelectionContainer` from crashing - Improves format of copied text by separating it into lines	1 year ago
Andrei Salavei	3f4a85491e	COMPOSE-356 Support light theme for codeviewer example (#3853 ) https://youtrack.jetbrains.com/issue/COMPOSE-356/Add-Dark-theme-to-codeviewer-examples The MR does the following: - Enables dark theme for iOS, Android and Desktop platforms - Expands compose view to fullscreen and uses window padding to adjust content location - Adjusts toolbar clock style to application theme on mobile platforms	1 year ago
Igor Demin	021b099e1c	Add org.gradle.toolchains.foojay-resolver-convention to the examples (#3666 ) According to https://developer.android.com/build/jdks we should: 1. [use JDK 17 for API 34](https://developer.android.com/build/jdks#compileSdk) 2. [use toolchain](https://developer.android.com/build/jdks#toolchain): ``` We recommend that you always specify the Java toolchain, and either ensure that the specified JDK is installed, or add a toolchain resolver to your build. ``` As we don't want to force people to have JDK 17 on their machine, we apply toolchain resolver that is recommended by Gradle: ``` id("org.gradle.toolchains.foojay-resolver-convention") version("0.4.0") ``` ## Test 1. Remove JDK 17 from the computer, remove `jvmToolchain(17)` 2. Run `./gradlew assembleDebug` 3. It should fail with: ``` > Could not create task ':androidApp:compileDebugJavaWithJavac'. > Failed to calculate the value of task ':androidApp:compileDebugJavaWithJavac' property 'javaCompiler'. > No matching toolchains found for requested specification: {languageVersion=17, vendor=any, implementation=vendor-specific} for WINDOWS on x86_64. > No locally installed toolchains match and toolchain download repositories have not been configured. ``` 4. restore `jvmToolchain(17)` 5. Run `./gradlew assembleDebug` again 6. It should succeed ## Issues Fixes https://github.com/JetBrains/compose-multiplatform/issues/3615	1 year ago
Igor Demin	45079fb31b	Fix crash in Codeviewer on Android (#3567 ) It crashes on Android, because it doesn't have slice method yet (only starting from API 34): ``` java.lang.NoSuchMethodError: No virtual method slice(II)Ljava/nio/MappedByteBuffer; in class Ljava/nio/MappedByteBuffer; or its super classes (declaration of 'java.nio.MappedByteBuffer' appears in /apex/com.android.art/javalib/core-oj.jar) at org.jetbrains.codeviewer.platform.JvmFileKt$toProjectFile$1$readLines$2.get(JvmFile.kt:68) at org.jetbrains.codeviewer.ui.editor.EditorKt$Editor$1.invoke$content(Editor.kt:47) at org.jetbrains.codeviewer.ui.editor.EditorKt$Editor$1.access$invoke$content(Editor.kt:37) at org.jetbrains.codeviewer.ui.editor.EditorKt$Editor$1$1.get(Editor.kt:57) at org.jetbrains.codeviewer.ui.editor.EditorViewKt$Lines$1$1$1$1.invoke(EditorView.kt:84) at org.jetbrains.codeviewer.ui.editor.EditorViewKt$Lines$1$1$1$1.invoke(EditorView.kt:82) at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:138) at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35) at androidx.compose.foundation.lazy.LazyListItemProviderImpl$Item$1.invoke(LazyListItemProvider.kt:79) at androidx.compose.foundation.lazy.LazyListItemProviderImpl$Item$1.invoke(LazyListItemProvider.kt:77) at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108) at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35) at androidx.compose.runtime.CompositionLocalKt.CompositionLocalProvider(CompositionLocal.kt:228) at androidx.compose.foundation.lazy.layout.LazyLayoutPinnableItemKt.LazyLayoutPinnableItem(LazyLayoutPinnableItem.kt:54) at androidx.compose.foundation.lazy.LazyListItemProviderImpl.Item(LazyListItemProvider.kt:77) at androidx.compose.foundation.lazy.layout.LazyLayoutItemContentFactoryKt$SkippableItem$1.invoke(LazyLayoutItemContentFactory.kt:135) at androidx.compose.foundation.lazy.layout.LazyLayoutItemContentFactoryKt$SkippableItem$1.invoke(LazyLayoutItemContentFactory.kt:134) at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:108) at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.jvm.kt:35) ``` The regression was introduced in Update experimental Codeviewer with changes from non-experimental one (#2975). Replacing with code that is available for Android	1 year ago
Igor Demin	0215dd9551	Update Android projects (#3566 ) - Update Gradle to 8.2.1 (for non-Android project as well) - Update AGP to 8.0.2 - add jvmToolchain for Android projects (it is required now) - removed targetSdk from shared modules (it is deprecated for com.android.library projects) - move "package" from manifset to "namespace " in Gradle (required by AGP) - rename android to androidTarget (android is deprecated in latest Kotlin) - update Android dependencies versions I checked - Android/iOS/web still work. HTML/IDE projects also work after updating Gradle. Works in the latest stable IDEA and Android Studio updated templates: https://github.com/JetBrains/compose-multiplatform-ios-android-template/pull/21 https://github.com/JetBrains/compose-multiplatform-template/pull/19 https://github.com/JetBrains/compose-multiplatform-desktop-template/pull/8 https://github.com/JetBrains/compose-multiplatform-html-library-template/pull/3	1 year ago
Igor Demin	53e3674118	1.5.0 Changelog and updated examples (#3556 ) The changelog is merged from the prerelease versions: https://github.com/JetBrains/compose-multiplatform/releases/tag/v1.5.0-beta01 https://github.com/JetBrains/compose-multiplatform/releases/tag/v1.5.0-beta02 I will change versions to 1.5.0 in a separate PR later	1 year ago
Alexey Tsvetkov	f60497a95b	Convert examples from cocoapods to regular frameworks (#3529 )	1 year ago
Alexey Tsvetkov	fa2df40e11	Replace warnings with errors (#3496 )	1 year ago
Sebastian Aigner	fc15726b62	Make codeviewer example more photogenic (top bar color and bottom margins) (#3174 )	2 years ago
Nikita Lipsky	1d955a2e6d	Remove internal from common public @Composable as it is not required for 1.4.0-rc03 (#3008 )	2 years ago
Nikita Lipsky	a8003a0f5d	Move experimental/examples to examples (#2976 ) * Move experimental/examples to examples * Change version to 1.4.0-rc01	2 years ago

12 Commits (ab34030a8782f66fb61ea6aa01b95e93186c8e1f)