compose-jb

Commit Graph

Author	SHA1	Message	Date
Igor Demin	021b099e1c	Add org.gradle.toolchains.foojay-resolver-convention to the examples (#3666 ) According to https://developer.android.com/build/jdks we should: 1. [use JDK 17 for API 34](https://developer.android.com/build/jdks#compileSdk) 2. [use toolchain](https://developer.android.com/build/jdks#toolchain): ``` We recommend that you always specify the Java toolchain, and either ensure that the specified JDK is installed, or add a toolchain resolver to your build. ``` As we don't want to force people to have JDK 17 on their machine, we apply toolchain resolver that is recommended by Gradle: ``` id("org.gradle.toolchains.foojay-resolver-convention") version("0.4.0") ``` ## Test 1. Remove JDK 17 from the computer, remove `jvmToolchain(17)` 2. Run `./gradlew assembleDebug` 3. It should fail with: ``` > Could not create task ':androidApp:compileDebugJavaWithJavac'. > Failed to calculate the value of task ':androidApp:compileDebugJavaWithJavac' property 'javaCompiler'. > No matching toolchains found for requested specification: {languageVersion=17, vendor=any, implementation=vendor-specific} for WINDOWS on x86_64. > No locally installed toolchains match and toolchain download repositories have not been configured. ``` 4. restore `jvmToolchain(17)` 5. Run `./gradlew assembleDebug` again 6. It should succeed ## Issues Fixes https://github.com/JetBrains/compose-multiplatform/issues/3615	1 year ago
Igor Demin	dbd0a21949	Modify replace.sh for replacing Compose version (#1511 ) Remove: ``` __LATEST_COMPOSE_RELEASE_VERSION__ __KOTLIN_COMPOSE_VERSION__ System.getenv("COMPOSE_TEMPLATE_COMPOSE_VERSION") ``` They pollute templates/examples. Now, all paths where we need to change the version are hardcoded in the script. Usage: ``` ./replace.sh 1.0.0-rc6 ``` This script is planned to run on CI In the future I will add support for changing Kotlin version	3 years ago
Igor Demin	3b13944daf	Fix multiplatform projects in IDEA / Android Studio Fixes: - https://github.com/JetBrains/compose-jb/issues/21 We need to move buildscript from settings.gradle.kts to build.gradle.kts See also https://youtrack.jetbrains.com/issue/KT-36331 - https://github.com/JetBrains/compose-jb/issues/22 kotlin("jvm") plugin doesn't work well with MPP modules. To fix this issue we need to use kotlin("multiplatform") even if we targeting single platform. See also https://youtrack.jetbrains.com/issue/KT-42823	4 years ago
Nikolay Igotti	c0c31e9506	Move to dev97	4 years ago
Nikolay Igotti	11543c4618	Move to dev87.	4 years ago
Nikolay Igotti	08ce747217	Move to dev85.	4 years ago
Nikolay Igotti	e2afc407c8	Move examples to piublic repo deps.	4 years ago
Nikolay Igotti	dfa22f0a01	Move sampels to build58	4 years ago
Nikolay Igotti	a61dbff798	Move to unmerged30.	4 years ago
Nikolay Igotti	6417d6c5ea	Move to build53.	4 years ago
Nikolay Igotti	4dc4f597d5	Add issues.	4 years ago

11 Commits (877fbcc2b04d38c4ffa151a64bc2e35d2dbba6b6)