compose-jb

1986 Commits

244 Branches

378 Tags

388 MiB

Tree: 1be81af584

Commit Graph

Author	SHA1	Message	Date
Igor Demin	021b099e1c	Add org.gradle.toolchains.foojay-resolver-convention to the examples (#3666 ) According to https://developer.android.com/build/jdks we should: 1. [use JDK 17 for API 34](https://developer.android.com/build/jdks#compileSdk) 2. [use toolchain](https://developer.android.com/build/jdks#toolchain): ``` We recommend that you always specify the Java toolchain, and either ensure that the specified JDK is installed, or add a toolchain resolver to your build. ``` As we don't want to force people to have JDK 17 on their machine, we apply toolchain resolver that is recommended by Gradle: ``` id("org.gradle.toolchains.foojay-resolver-convention") version("0.4.0") ``` ## Test 1. Remove JDK 17 from the computer, remove `jvmToolchain(17)` 2. Run `./gradlew assembleDebug` 3. It should fail with: ``` > Could not create task ':androidApp:compileDebugJavaWithJavac'. > Failed to calculate the value of task ':androidApp:compileDebugJavaWithJavac' property 'javaCompiler'. > No matching toolchains found for requested specification: {languageVersion=17, vendor=any, implementation=vendor-specific} for WINDOWS on x86_64. > No locally installed toolchains match and toolchain download repositories have not been configured. ``` 4. restore `jvmToolchain(17)` 5. Run `./gradlew assembleDebug` again 6. It should succeed ## Issues Fixes https://github.com/JetBrains/compose-multiplatform/issues/3615	1 year ago
Igor Demin	0215dd9551	Update Android projects (#3566 ) - Update Gradle to 8.2.1 (for non-Android project as well) - Update AGP to 8.0.2 - add jvmToolchain for Android projects (it is required now) - removed targetSdk from shared modules (it is deprecated for com.android.library projects) - move "package" from manifset to "namespace " in Gradle (required by AGP) - rename android to androidTarget (android is deprecated in latest Kotlin) - update Android dependencies versions I checked - Android/iOS/web still work. HTML/IDE projects also work after updating Gradle. Works in the latest stable IDEA and Android Studio updated templates: https://github.com/JetBrains/compose-multiplatform-ios-android-template/pull/21 https://github.com/JetBrains/compose-multiplatform-template/pull/19 https://github.com/JetBrains/compose-multiplatform-desktop-template/pull/8 https://github.com/JetBrains/compose-multiplatform-html-library-template/pull/3	1 year ago
Alexey Tsvetkov	3e40cdab44	Add example with cocoapods (#3541 ) * Add example with cocoapods * README for cocoapods example (#3548) --------- Co-authored-by: dima.avdeev <dima.avdeev@jetbrains.com>	1 year ago

Author

SHA1

Message

Date

Igor Demin

021b099e1c

Add org.gradle.toolchains.foojay-resolver-convention to the examples (#3666 )

According to https://developer.android.com/build/jdks we should:

1. [use JDK 17 for API 34](https://developer.android.com/build/jdks#compileSdk)
2. [use toolchain](https://developer.android.com/build/jdks#toolchain):
```
We recommend that you always specify the Java toolchain, and either ensure that the specified JDK is installed, or add a toolchain resolver to your build.
```

As we don't want to force people to have JDK 17 on their machine, we apply toolchain resolver that is recommended by Gradle:
```
id("org.gradle.toolchains.foojay-resolver-convention") version("0.4.0")
```

## Test
1. Remove JDK 17 from the computer, remove `jvmToolchain(17)`
2. Run `./gradlew assembleDebug`
3. It should fail with:
```
> Could not create task ':androidApp:compileDebugJavaWithJavac'.
   > Failed to calculate the value of task ':androidApp:compileDebugJavaWithJavac' property 'javaCompiler'.
      > No matching toolchains found for requested specification: {languageVersion=17, vendor=any, implementation=vendor-specific} for WINDOWS on x86_64.
         > No locally installed toolchains match and toolchain download repositories have not been configured.
```
4. restore `jvmToolchain(17)`
5. Run `./gradlew assembleDebug` again
6. It should succeed

## Issues
Fixes https://github.com/JetBrains/compose-multiplatform/issues/3615

1 year ago

Igor Demin

0215dd9551

Update Android projects (#3566 )

- Update Gradle to 8.2.1 (for non-Android project as well)
- Update AGP to 8.0.2
  - add jvmToolchain for Android projects (it is required now)
  - removed targetSdk from shared modules (it is deprecated for com.android.library projects)
  - move "package" from manifset to "namespace " in Gradle (required by AGP)
- rename android to androidTarget (android is deprecated in latest Kotlin)
- update Android dependencies versions

I checked - Android/iOS/web still work. HTML/IDE projects also work after updating Gradle.

Works in the latest stable IDEA and Android Studio

updated templates:
https://github.com/JetBrains/compose-multiplatform-ios-android-template/pull/21
https://github.com/JetBrains/compose-multiplatform-template/pull/19
https://github.com/JetBrains/compose-multiplatform-desktop-template/pull/8
https://github.com/JetBrains/compose-multiplatform-html-library-template/pull/3

1 year ago

Alexey Tsvetkov

3e40cdab44

Add example with cocoapods (#3541 )

* Add example with cocoapods

* README for cocoapods example (#3548)

---------

Co-authored-by: dima.avdeev <dima.avdeev@jetbrains.com>

1 year ago

3 Commits (1be81af58438b2d7c01aa37aaf76f6986f4a8d88)