From c105e3a8eb6ac771b4e415ba1229a14cd5d0bfd4 Mon Sep 17 00:00:00 2001 From: Alexey Tsvetkov Date: Thu, 12 Nov 2020 13:15:56 +0300 Subject: [PATCH] Change marker comment for Compose version The verb `update` in `__UPDATE_COMPOSE_VERSION_MARKER__` could be read as an instruction to update the plugin, which might be confusing for users. I suggest renaming the marker to more neutral `__LATEST_COMPOSE_RELEASE_VERSION__` --- benchmarks/build.gradle.kts | 2 +- examples/codeviewer/build.gradle.kts | 2 +- examples/imageviewer/build.gradle.kts | 2 +- examples/todoapp/buildSrc/buildSrc/src/main/kotlin/Deps.kt | 2 +- templates/desktop-template/build.gradle.kts | 2 +- templates/multiplatform-template/build.gradle.kts | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/benchmarks/build.gradle.kts b/benchmarks/build.gradle.kts index 6e6e82aa54..a3c2c288d1 100644 --- a/benchmarks/build.gradle.kts +++ b/benchmarks/build.gradle.kts @@ -4,7 +4,7 @@ import org.jetbrains.kotlin.allopen.gradle.* plugins { kotlin("jvm") version "1.4.0" - // __UPDATE_COMPOSE_VERSION_MARKER__ + // __LATEST_COMPOSE_RELEASE_VERSION__ id("org.jetbrains.compose") version "0.1.0-build113" kotlin("plugin.allopen") version "1.4.0" id("kotlinx.benchmark") version "0.2.0-dev-20" diff --git a/examples/codeviewer/build.gradle.kts b/examples/codeviewer/build.gradle.kts index 26e6a3133d..907708a042 100644 --- a/examples/codeviewer/build.gradle.kts +++ b/examples/codeviewer/build.gradle.kts @@ -8,7 +8,7 @@ buildscript { } dependencies { - // __UPDATE_COMPOSE_VERSION_MARKER__ + // __LATEST_COMPOSE_RELEASE_VERSION__ classpath("org.jetbrains.compose:compose-gradle-plugin:0.1.0-build113") classpath("com.android.tools.build:gradle:4.0.1") classpath(kotlin("gradle-plugin", version = "1.4.0")) diff --git a/examples/imageviewer/build.gradle.kts b/examples/imageviewer/build.gradle.kts index f2aa2d33b1..a17a5db3d9 100755 --- a/examples/imageviewer/build.gradle.kts +++ b/examples/imageviewer/build.gradle.kts @@ -10,7 +10,7 @@ buildscript { } dependencies { - // __UPDATE_COMPOSE_VERSION_MARKER__ + // __LATEST_COMPOSE_RELEASE_VERSION__ classpath("org.jetbrains.compose:compose-gradle-plugin:0.1.0-build113") classpath("com.android.tools.build:gradle:4.0.1") classpath(kotlin("gradle-plugin", version = "1.4.0")) diff --git a/examples/todoapp/buildSrc/buildSrc/src/main/kotlin/Deps.kt b/examples/todoapp/buildSrc/buildSrc/src/main/kotlin/Deps.kt index 9a06e3bd40..dcb821dcef 100644 --- a/examples/todoapp/buildSrc/buildSrc/src/main/kotlin/Deps.kt +++ b/examples/todoapp/buildSrc/buildSrc/src/main/kotlin/Deps.kt @@ -10,7 +10,7 @@ object Deps { } object Compose { - // __UPDATE_COMPOSE_VERSION_MARKER__ + // __LATEST_COMPOSE_RELEASE_VERSION__ private const val VERSION = "0.1.0-build113" const val gradlePlugin = "org.jetbrains.compose:compose-gradle-plugin:$VERSION" } diff --git a/templates/desktop-template/build.gradle.kts b/templates/desktop-template/build.gradle.kts index b4d597e3e7..86f608cbbf 100644 --- a/templates/desktop-template/build.gradle.kts +++ b/templates/desktop-template/build.gradle.kts @@ -3,7 +3,7 @@ import org.jetbrains.compose.desktop.application.dsl.TargetFormat plugins { kotlin("jvm") version "1.4.0" - // __UPDATE_COMPOSE_VERSION_MARKER__ + // __LATEST_COMPOSE_RELEASE_VERSION__ id("org.jetbrains.compose") version (System.getenv("COMPOSE_TEMPLATE_COMPOSE_VERSION") ?: "0.1.0-build113") } diff --git a/templates/multiplatform-template/build.gradle.kts b/templates/multiplatform-template/build.gradle.kts index 4685c47c6d..beb2848381 100644 --- a/templates/multiplatform-template/build.gradle.kts +++ b/templates/multiplatform-template/build.gradle.kts @@ -1,5 +1,5 @@ buildscript { - // __UPDATE_COMPOSE_VERSION_MARKER__ + // __LATEST_COMPOSE_RELEASE_VERSION__ val composeVersion = System.getenv("COMPOSE_TEMPLATE_COMPOSE_VERSION") ?: "0.1.0-build113" repositories {