mirror of https://github.com/boa-dev/boa.git
Tree:
fc30061453
add-vhs-ci
benchmarks
control-flow-graph
expect-lints
feature/node_span
feature/snapshot
features
gh-readonly-queue/main/pr-2877-b0ddf5eed00a53281d67fc7d846233fc0d99ce9c
gh-readonly-queue/main/pr-3144-8e48cec73fae708420b9af88813d4870243c491a
main
nan-boxing
optimization/static-shapes
real_conformance
reduce-environment-allocations
refactor/interner
refactor/register-vm
releases/0.17
releases/0.19
semver_checks
tco
utility-crate
wasm-debugger
nightly
v0.10
v0.11
v0.12
v0.13
v0.14
v0.15
v0.16
v0.17
v0.17.1
v0.17.2
v0.17.3
v0.18
v0.19
v0.19.1
v0.2.0
v0.2.1
v0.3.0
v0.4.0
v0.5.0
v0.5.1
v0.6.0
v0.7.0
v0.8.0
v0.9.0
${ noResults }
1713 Commits (fc30061453556449ed9e6a6db8b904bc54642f16)
| Author | SHA1 | Message | Date |
|---|---|---|---|
dependabot[bot]
|
40e35f101b |
Bump test262 from `f7fb969` to `0bccacd` (#1928)
Bumps [test262](https://github.com/tc39/test262) from `f7fb969` to `0bccacd`. <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
dependabot[bot]
|
48f23b3c77 |
Bump monaco-editor from 0.32.1 to 0.33.0 (#1927)
Bumps [monaco-editor](https://github.com/microsoft/monaco-editor) from 0.32.1 to 0.33.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md">monaco-editor's changelog</a>.</em></p> <blockquote> <h2>[0.33.0]</h2> <h3>Breaking Changes</h3> <ul> <li><code>InlayHintKind.Other</code> is removed.</li> </ul> <h3>Thank you</h3> <p>Contributions to <code>monaco-editor</code>:</p> <ul> <li><a href="https://github.com/Dan1ve"><code>@Dan1ve (Daniel Veihelmann)</code></a>: Make Vite sample code Firefox compatible [PR <a href="https://github-redirect.dependabot.com/microsoft/monaco-editor/issues/2991">#2991</a>](<a href="https://github-redirect.dependabot.com/microsoft/monaco-editor/pull/2991">microsoft/monaco-editor#2991</a>)</li> <li><a href="https://github.com/philipturner"><code>@philipturner (Philip Turner)</code></a>: Add <code>@noDerivative</code> modifier to Swift [PR <a href="https://github-redirect.dependabot.com/microsoft/monaco-editor/issues/2957">#2957</a>](<a href="https://github-redirect.dependabot.com/microsoft/monaco-editor/pull/2957">microsoft/monaco-editor#2957</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/microsoft/monaco-editor/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> |
3 years ago |
raskad
|
23711a638b |
Refresh vm docs and fix bytecode trace output (#1921)
It changes the following: - Refreshes the vm and debugging docs to represent the current state - Fix some bytecode trace output - Rename a field in the `CodeBlock` |
3 years ago |
Nikodem Rabuliński
|
9eb6a78abc |
Implement Array.from (#1831)
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes/closes #1784. There're still a few tests failing, notably: - `iter-set-elem-prop-non-writable` - we don't have generator functions implemented - `calling-from-valid-1-noStrict`, `iter-map-fn-this-non-strict` - `thisArg` in non-strict mode, when undefined, should be inherited (that's what I'm guessing, I haven't confirmed this, but strict counterparts do pass with `thisArg` being `undefined`) - `source-array-boundary`, `elements-deleted-after` - ~~Not sure yet, still investigating, but they also include thisArg, so perhaps function calling has an underlying issue?~~ Failing because `this` on the top level evaluates to an empty object instead of containing everything from the top scope Co-authored-by: HalidOdat <halidodat@gmail.com> |
3 years ago |
Iban Eguia
|
128f836680 |
Added funding information to the repository (#1871)
This will add the "Sponsor" button to the repository, which will redirect to the OpenCollective platform. |
3 years ago |
|
dependabot[bot]
|
09bfabb0b0 |
Bump git2 from 0.14.1 to 0.14.2 (#1919)
Bumps [git2](https://github.com/rust-lang/git2-rs) from 0.14.1 to 0.14.2. <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
raskad
|
0027f26d21 |
Use function name from identifiers in assignment expressions (#1908)
Use function name from identifiers in assignment expressions, when a function expressions does not contain a name. |
3 years ago |
jedel1043
|
51f75d8ccb |
Update `yarn.lock` and add `build:prod` command (#1910)
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request makes it easier to build the Boa playground in production mode, with a new `build:prod` command. |
3 years ago |
|
raskad
|
a44be7073b |
Fix postfix increment and decrement return values (#1913)
This fixes a bug with the postfix increment and decrement. Before those operators would return the left-hand-side value, but the spec specifies they should return ToNumeric(left-had-side value). |
3 years ago |
|
dependabot[bot]
|
51ae856c83 |
Bump css-loader from 6.7.0 to 6.7.1 (#1914)
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 6.7.0 to 6.7.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack-contrib/css-loader/releases">css-loader's releases</a>.</em></p> <blockquote> <h2>v6.7.1</h2> <h3><a href="https://github.com/webpack-contrib/css-loader/compare/v6.7.0...v6.7.1">6.7.1</a> (2022-03-08)</h3> <h3>Bug Fixes</h3> <ul> <li>defaultGetLocalIdent export (<a href="https://github-redirect.dependabot.com/webpack-contrib/css-loader/issues/1427">#1427</a>) (<a href=" |
3 years ago |
|
dependabot[bot]
|
f7920cdca8 |
Bump regex from 1.5.4 to 1.5.5 (#1915)
Bumps [regex](https://github.com/rust-lang/regex) from 1.5.4 to 1.5.5. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/regex/blob/master/CHANGELOG.md">regex's changelog</a>.</em></p> <blockquote> <h1>1.5.5 (2022-03-08)</h1> <p>This releases fixes a security bug in the regex compiler. This bug permits a vector for a denial-of-service attack in cases where the regex being compiled is untrusted. There are no known problems where the regex is itself trusted, including in cases of untrusted haystacks.</p> <ul> <li><a href="https://github.com/rust-lang/regex/security/advisories/GHSA-m5pq-gvj9-9vr8">SECURITY #GHSA-m5pq-gvj9-9vr8</a>: Fixes a bug in the regex compiler where empty sub-expressions subverted the existing mitigations in place to enforce a size limit on compiled regexes. The Rust Security Response WG published an advisory about this: <a href="https://groups.google.com/g/rustlang-security-announcements/c/NcNNL1Jq7Yw">https://groups.google.com/g/rustlang-security-announcements/c/NcNNL1Jq7Yw</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
Addison Crump
|
92dbba6c5d |
Prevent breaks without loop or switch from causing panics (#1860)
This PR changes the following: - Replaces a panic with a syntax error when a break is used outside of a loop or switch - Adds a test for that |
3 years ago |
|
raskad
|
7f90829f88 |
Compile StatementList after parse passes on negative tests (#1906)
This fixes an issue with 262 negative tests, that should produce a syntax errors. Currently we only parse the test code is such cases. If the parsing does not return an error, we do not compile the code further. This caused some panics. Most of them are fixed by now, the last ones will be fixed with #1860. |
3 years ago |
Jason Williams
|
44b5617d8d |
Added boa examples (#1161)
Added boa examples as per issue #446 Overtaken https://github.com/boa-dev/boa/pull/634 Somehow screwed that branch up by rebasing it and losing access pings @elasmojs This Pull Request fixes/closes #446 . Co-authored-by: Jason Williams <jase.williams@gmail.com> Co-authored-by: Iban Eguia (Razican) <razican@protonmail.ch> Co-authored-by: jasonwilliams <jase.williams@gmail.com> Co-authored-by: jedel1043 <jedel0124@gmail.com> |
3 years ago |
|
raskad
|
6ff36fb2a3 |
Implement destructing assignments for assignment expressions (#1895)
It changes the following: - Implement destructing assignments for assignment expressions |
3 years ago |
|
jedel1043
|
9f9e36c910 |
Fix try/catch/finally related bugs and add tests (#1901)
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes some bugs related to try blocks: - Fixes a panic when a finally block contained variable declarations. (Thanks to @VTCAKAVSMoACE for the report!) - Fixes a bug where try blocks in the last position of a statement list didn't return its inner last value as the result of the evaluation. - Add tests for both cases and two other common cases. - Extract and cleanup some code. |
3 years ago |
|
jedel1043
|
2a6ea9dad6 |
Deny const declarations without initializer inside for loops (#1903)
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel neccesary. ---> This Pull Request fixes/closes #1897. It changes the following: - Rejects uninitialized const declarations inside the init value of a for loop statement. - Adds test for the case. |
3 years ago |
|
dependabot[bot]
|
a49b57beb7 |
Bump css-loader from 6.6.0 to 6.7.0 (#1904)
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 6.6.0 to 6.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack-contrib/css-loader/releases">css-loader's releases</a>.</em></p> <blockquote> <h2>v6.7.0</h2> <h2><a href="https://github.com/webpack-contrib/css-loader/compare/v6.6.0...v6.7.0">6.7.0</a> (2022-03-04)</h2> <h3>Features</h3> <ul> <li>re-export defaultGetLocalIdent (<a href="https://github-redirect.dependabot.com/webpack-contrib/css-loader/issues/1423">#1423</a>) (<a href=" |
3 years ago |
|
dependabot[bot]
|
6378204052 |
Bump test262 from `18ce639` to `f7fb969` (#1905)
Bumps [test262](https://github.com/tc39/test262) from `18ce639` to `f7fb969`. <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
Addison Crump
|
cc755db485 |
Continue panic fixes (#1896)
This PR changes the following: - Fixes the panics induced by incorrect continues. - Adds tests which demonstrate the various panics induced. - Actually rustfmts correctly? |
3 years ago |
|
Addison Crump
|
7fa37b50bc |
Fix unreachable panics in compile_access (#1861)
This PR changes the following: - More elegantly handles illegal access statements in compile_access - Adds a slew of previously unhandled illegal access test cases ### Caveats It is very, very likely that you will want to simply restrict unary and assignment operations in the AST. However, this prevents crashes in the meantime with a error that is just slightly less detailed than if it were implemented in AST. |
3 years ago |
|
jedel1043
|
3b53fec412 |
Extract `Intrinsics` struct from `Context` and cleanup names (#1890)
Building up to #186, this PR extracts an `Intrinsics` struct from `Context`, facilitating a lot the extraction of a `Realm` struct. Also, it adapts the `BuiltIn` trait to be useful for builtins that don't expose a global property on initialization (`Generator`, `TypedArray`, etc.) It changes the following: - Creates an `Intrinsics` struct and refactors `Context` to transfer its intrinsic related fields to `Intrinsics`. - Renames some methods and parameters to better describe their functionality. - Makes `BuiltIn::init` return `Option<JsValue>` to skip global property initialization if the builtin initialization returns `None` |
3 years ago |
Halid Odat
|
9c2b1114c4 |
Implement `Number.parseInt` and `Number.parseFloat` (#1894)
This PR add `Number.parseInt` and `Number.parseFloat` which according to spec are clones of the global objects `parseInt` and `parseFloat`.
It also fixes the last failing test of the `NativeError` feature with this we get 100% spec complaint `NativeError`s 🎉
It changes the following:
- Add `Number.parseInt()`
- Add `Number.parseFloat()`
- Fix length of `AggregateError`
- Fix length of `Reflect.setPrototypeOf`
|
3 years ago |
|
dependabot[bot]
|
3ec6f633db |
Bump webpack from 5.69.1 to 5.70.0 (#1892)
Bumps [webpack](https://github.com/webpack/webpack) from 5.69.1 to 5.70.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack/releases">webpack's releases</a>.</em></p> <blockquote> <h2>v5.70.0</h2> <h1>Features</h1> <ul> <li>update node.js version constraints for ESM support</li> <li>add <code>baseUri</code> to <code>entry</code> options to configure a static base uri (the base of <code>new URL()</code>)</li> <li>alphabetically sort exports in namespace objects when possible</li> <li>add <code>__webpack_exports_info__.name.canMangle</code></li> <li>add proxy support to <code>experiments.buildHttp</code></li> <li><code>import.meta.webpackContext</code> as ESM alternative to <code>require.context</code></li> <li>handle multiple alternative directories (e. g. due to resolve.alias or resolve.modules) when creating an context module</li> </ul> <h1>Bugfixes</h1> <ul> <li>fix problem when assigning <code>global</code> to a variable</li> <li>fix crash when using <code>experiments.outputModule</code> and <code>loaderContext.importModule</code> with multiple chunks</li> <li>avoid generating progress output before the compilation has started (ProgressPlugin)</li> <li>fix handling of non-static-ESM dependencies with using TLA and HMR in the same module</li> <li>include the asset module filename in hashing</li> <li><code>output.clean</code> will keep HMR assets for at least 10s to allow HMR to access them even when compilation is faster then the browser</li> </ul> <h1>Performance</h1> <ul> <li>fix asset caching when using the BannerPlugin</li> </ul> <h1>Developer Experience</h1> <ul> <li>improve typings</li> </ul> <h1>Contributing</h1> <ul> <li>capture caching errors when running the test suite</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
dependabot[bot]
|
60b74e1f51 |
Bump once_cell from 1.9.0 to 1.10.0 (#1893)
Bumps [once_cell](https://github.com/matklad/once_cell) from 1.9.0 to 1.10.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/matklad/once_cell/blob/master/CHANGELOG.md">once_cell's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>1.11</h2> <ul> <li>Add <code>OnceCell::with_value</code> to create initialized <code>OnceCell</code> at compile time.</li> <li>Improve <code>Clone</code> implementation for <code>OnceCell</code>.</li> </ul> <h2>1.10</h2> <ul> <li>upgrade <code>parking_lot</code> to <code>0.12.0</code> (note that this bumps MSRV with <code>parking_lot</code> feature enabled to <code>1.49.0</code>).</li> </ul> <h2>1.9</h2> <ul> <li>Added an <code>atomic-polyfill</code> optional dependency to compile <code>race</code> on platforms without atomics</li> </ul> <h2>1.8.0</h2> <ul> <li>Add <code>try_insert</code> API -- a version of <code>set</code> that returns a reference.</li> </ul> <h2>1.7.2</h2> <ul> <li>Improve code size when using parking_lot feature.</li> </ul> <h2>1.7.1</h2> <ul> <li>Fix <code>race::OnceBox<T></code> to also impl <code>Default</code> even if <code>T</code> doesn't impl <code>Default</code>.</li> </ul> <h2>1.7.0</h2> <ul> <li>Hide the <code>race</code> module behind (default) <code>race</code> feature. Turns out that adding <code>race</code> by default was a breaking change on some platforms without atomics. In this release, we make the module opt-out. Technically, this is a breaking change for those who use <code>race</code> with <code>no_default_features</code>. Given that the <code>race</code> module itself only several days old, the breakage is deemed acceptable.</li> </ul> <h2>1.6.0</h2> <ul> <li>Add <code>Lazy::into_value</code></li> <li>Stabilize <code>once_cell::race</code> module for "first one wins" no_std-compatible initialization flavor.</li> <li>Migrate from deprecated <code>compare_and_swap</code> to <code>compare_exchange</code>.</li> </ul> <h2>1.5.2</h2> <ul> <li><code>OnceBox</code> API uses <code>Box<T></code>. This a breaking change to unstable API.</li> </ul> <h2>1.5.1</h2> <ul> <li>MSRV is increased to <code>1.36.0</code>.</li> <li>document <code>once_cell::race</code> module.</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
Halid Odat
|
4c3058b6bf |
Implement `AggregateError` (#1888)
It changes the following: - Implement `AggregateError` global object |
3 years ago |
|
dependabot[bot]
|
fb8c5cfa34 |
Bump actions/checkout from 2.4.0 to 3 (#1885)
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <ul> <li>Update default runtime to node16</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>v2.3.1</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/284">Fix default branch resolution for .wiki and when using SSH</a></li> </ul> <h2>v2.3.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/278">Fallback to the default branch</a></li> </ul> <h2>v2.2.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/258">Fetch all history for all tags and branches when fetch-depth=0</a></li> </ul> <h2>v2.1.1</h2> <ul> <li>Changes to support GHES (<a href="https://github-redirect.dependabot.com/actions/checkout/pull/236">here</a> and <a href="https://github-redirect.dependabot.com/actions/checkout/pull/248">here</a>)</li> </ul> <h2>v2.1.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/191">Group output</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/199">Changes to support GHES alpha release</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/184">Persist core.sshCommand for submodules</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/163">Add support ssh</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/179">Convert submodule SSH URL to HTTPS, when not using SSH</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/157">Add submodule support</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/144">Follow proxy settings</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/141">Fix ref for pr closed event when a pr is merged</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/128">Fix issue checking detached when git less than 2.22</a></li> </ul> <h2>v2.0.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/108">Do not pass cred on command line</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/107">Add input persist-credentials</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/104">Fallback to REST API to download repo</a></li> </ul> <h2>v2 (beta)</h2> <ul> <li>Improved fetch performance <ul> <li>The default behavior now fetches only the SHA being checked-out</li> </ul> </li> <li>Script authenticated git commands <ul> <li>Persists <code>with.token</code> in the local git config</li> <li>Enables your scripts to run authenticated git commands</li> <li>Post-job cleanup removes the token</li> <li>Coming soon: Opt out by setting <code>with.persist-credentials</code> to <code>false</code></li> </ul> </li> <li>Creates a local branch <ul> <li>No longer detached HEAD when checking out a branch</li> <li>A local branch is created with the corresponding upstream branch set</li> </ul> </li> <li>Improved layout</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
Halid Odat
|
a9a82a7381 |
Make iterator spec complaint (#1889)
This PR is also related to #577 Changes: - Implements `IteratorValue` (`IteratorResult::value()`) - Implements `IteratorComplete` (`IteratorResult::complete()`) - Implements `IteratorStep` (`IteratorRecord::step()`) - Makes `IteratorNext` (`IteratorRecord::next()`) spec compliant - Deprecates/removes `JsValue::get_field()`. |
3 years ago |
|
jedel1043
|
00a19005e4 |
Remove `toInteger` and document the `string` builtin (#1884)
The ECMAScript 2022 specification removes the `toInteger` method, and replaces it with `toIntegerOrInfinity`, which is arguably better for us since the `JsValue::toInteger` returns an `f64`, which is pretty confusing at times. This pull request removes the `JsValue::to_integer` method, replaces all its calls by `JsValue::to_integer_or_infinity` or others per the spec and documents several methods from the `string` builtin. |
3 years ago |
|
Halid Odat
|
fd889fd5d0 |
Fix `PropertyKey` to `JsValue` conversion (#1886)
We store string `PropertyKey`s with two enums `String` and `Index` for performance reasons, but the spec does not differentiate between string and index property keys so before conversion to `JsValue` we have to convert to a string. This was failing tests like `Reflect.ownKeys([true, "", 1])` because it was returning (integer numbers) `[1, 2, 3]` instead of `['1', '2', '3']` |
3 years ago |
|
Halid Odat
|
7248ed1005 |
Make `StringToNumber` spec compliant (#1881)
This PR enables `StringToNumber()` to parse binary, octal and hexadecimal numbers. |
3 years ago |
|
Halid Odat
|
3c59905a1b |
`%NativeError%.[[prototype]]` should be `Error` constructor (#1883)
Before the `%NativeError%` objects (like `TypeError`, `ReferenceError`, etc) `[[prototype]]` field was set to `Function.prototype` but this is wrong it should be the `Error` constructor object itself. This makes the `%NativeError%`s 100% spec compliant :) (except `AggregateError` because its not implemented) |
3 years ago |
|
raskad
|
408e49e460 |
Cleanup vm stack on function return (#1880)
This cleans up the vm stack on a function return. This is needed because when errors are thrown, there may be still values on the stack that cannot be cleaned up via regular control flow. The change should have little performance impact, because the `Vec::truncate` function does not alter the capacity of the vector. |
3 years ago |
Jason Williams
|
b2d3720b29
|
Update release.yml
The casing needs updating on the Internal label |
3 years ago |
|
Halid Odat
|
6e3f93e632 |
Fix `Number.prototype.toString` when passing `undefined` as radix (#1877)
This PR fixes the bug when passing `undefined` as radix in `Number.prototype.toString()` which was throwing a range error, instead of setting the radix to `10` [spec](https://tc39.es/ecma262/#sec-number.prototype.tostring): > **Note** > > The optional radix should be an [integral Number](https://tc39.es/ecma262/#integral-number) value in the inclusive range 2𝔽 to 36𝔽. If radix is undefined then 10𝔽 is used as the value of radix. |
3 years ago |
|
Halid Odat
|
3fe7d09096 |
Make `Error` and `%NativeError%` spec compliant (#1879)
This PR makes `Error` and `%NativeError%` spec compliant. It changes the following: - Adds cause argument object. - Makes `message` non-enumerable. |
3 years ago |
|
dependabot[bot]
|
d7ed2fe5c9 |
Bump git2 from 0.14.0 to 0.14.1 (#1878)
Bumps [git2](https://github.com/rust-lang/git2-rs) from 0.14.0 to 0.14.1. <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
Halid Odat
|
4292c193fa |
Implement `Object.prototype.toLocaleString()` (#1875)
It changes the following: - Implement `Object.prototype.toLocaleString()` |
3 years ago |
|
Halid Odat
|
73bcd42640 |
Make `Object.getOwnPropertyDescriptors` spec compliant (#1876)
It changes the following: - Fix `Object.getOwnPropertyDescriptors()` to comply to spec |
3 years ago |
|
Iban Eguia
|
ec78e184f3 |
Removed reference counted pointers from `JsValue` variants (#1866)
This Pull Request fixes/closes #1864. It changes the following: - Removed `JsBigInt` from `Const` nodes, using a boxed `BigInt` instead. - Modifies the `JsObject` variant so that it has a similar structure to other variants, where the internal structure is private. The size of `JsValue` stays in 2 64-bit words (in a 64-bit system at least), and the size of `Const` also stays the same. I have noticed that we clone tokens too much in the parser, so I was thinking that we should implement a by-value getter for `kind()`. Something like `kind_unwrap()`. |
3 years ago |
|
Iban Eguia
|
1887b6aebb |
Removing the panic in favour of an error result (#1874)
This Pull Request is related to #1873. It changes the following: - Removes the panic in case a label is not found. I think this should be an early syntax error, but at least we shouldn't panic while we fix the issue with the labels. I think we should solve the issue with labeled statements for 0.15. |
3 years ago |
|
Halid Odat
|
ada4ca895f |
Feature arrays with empty elements (#1870)
This PR adds support for arrays with empty elements e.g. `["", false, , , ]`. Before we were filling the empty places with `undefined`, but this is wrong according to [spec](https://tc39.es/ecma262/#sec-runtime-semantics-arrayaccumulation) there shouldn't be undefined with a index at that place, instead only `length` is incremented. So `[,,,].length == 3` and operations like `[,,,,].indexOf(undefined) == -1`, `[,,,,].lastIndexOf(undefined) == -1` etc. |
3 years ago |
|
Halid Odat
|
6b2ca30946 |
Fix equality between objects and `undefined` or `null` (#1872)
This PR fixes equality between object and `null` or `undefined` (like `[] == null`), which was failing the test262 harness test [`compare-array-symbol.js`](
|
3 years ago |
|
raskad
|
60e2294706 |
Implement generator execution (#1790)
This Pull Request fixes/closes #1559. It changes the following: - Implement GeneratorFunction Objects - Implement Generator Objects - Implement generator execution in vm - Create `FormalParameterList` to remove duplicate checks on function parameters - Refactor `MethodDefinition` on object literals |
3 years ago |
|
dependabot[bot]
|
f7fab0744c |
Bump git2 from 0.13.25 to 0.14.0 (#1869)
Bumps [git2](https://github.com/rust-lang/git2-rs) from 0.13.25 to 0.14.0. <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
dependabot[bot]
|
7aa001ae8f |
Update git2 requirement from 0.13.25 to 0.14.0 in /boa_tester (#1868)
Updates the requirements on [git2](https://github.com/rust-lang/git2-rs) to permit the latest version. <details> <summary>Commits</summary> <ul> <li><a href=" |
3 years ago |
|
Halid Odat
|
b5678f0b0c |
Removing internal deprecated functions (#1854)
This Pull Request is related to #577 . It changes the following: - Remove `JsValue::set_field` - Remove `JsValue::set_property` - Remove almost all uses of `JsValue::get_field` - Use `.get_v()` instead of `get_field` according to spec in `serialize_json_property` - Remove `Array::new_array()` - Remove `Array::add_to_array_object()` |
3 years ago |
João Borges
|
6093a66899 |
Refactorings for Rust 1.59 (#1867)
This Pull Request fixes new lint errors and warnings introduced in rust 1.59 Each commit describes its changse. Co-authored-by: raskad <32105367+raskad@users.noreply.github.com> |
3 years ago |
|
Halid Odat
|
9dda8d3eae |
Toggleable `JsValue` internals displaying (#1865)
This PR makes `JsValue` (object) only display owned properties, cleans up object printing. This can be toggled with `value.display().internals(true)`
`>> ({x: 1, y: ""})`
_Before:_
<details>
<pre>
{
x: 1,
y: "",
__proto__: {
hasOwnProperty: {
length: 1,
name: "hasOwnProperty",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
propertyIsEnumerable: {
length: 1,
name: "propertyIsEnumerable",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
toString: {
length: 0,
name: "toString",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
valueOf: {
length: 0,
name: "valueOf",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
isPrototypeOf: {
length: 1,
name: "isPrototypeOf",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
constructor: {
create: {
length: 2,
name: "create",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
setPrototypeOf: {
length: 2,
name: "setPrototypeOf",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
getPrototypeOf: {
length: 1,
name: "getPrototypeOf",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
defineProperty: {
length: 3,
name: "defineProperty",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
defineProperties: {
length: 2,
name: "defineProperties",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
assign: {
length: 2,
name: "assign",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
is: {
length: 2,
name: "is",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
keys: {
length: 1,
name: "keys",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
values: {
length: 1,
name: "values",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
entries: {
length: 1,
name: "entries",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
seal: {
length: 1,
name: "seal",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
isSealed: {
length: 1,
name: "isSealed",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
freeze: {
length: 1,
name: "freeze",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
isFrozen: {
length: 1,
name: "isFrozen",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
preventExtensions: {
length: 1,
name: "preventExtensions",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
isExtensible: {
length: 1,
name: "isExtensible",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
getOwnPropertyDescriptor: {
length: 2,
name: "getOwnPropertyDescriptor",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
getOwnPropertyDescriptors: {
length: 1,
name: "getOwnPropertyDescriptors",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
getOwnPropertyNames: {
length: 1,
name: "getOwnPropertyNames",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
getOwnPropertySymbols: {
length: 1,
name: "getOwnPropertySymbols",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
hasOwn: {
length: 2,
name: "hasOwn",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
fromEntries: {
length: 1,
name: "fromEntries",
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
length: 1,
name: "Object",
prototype: [Cycle],
__proto__: {
name: "",
length: 0,
apply: {
length: 1,
name: "apply",
__proto__: [Cycle]
},
bind: {
length: 1,
name: "bind",
__proto__: [Cycle]
},
call: {
length: 1,
name: "call",
__proto__: [Cycle]
},
toString: {
length: 0,
name: "toString",
__proto__: [Cycle]
},
constructor: {
length: 1,
name: "Function",
prototype: [Cycle],
__proto__: [Cycle]
},
Symbol(Symbol.hasInstance): {
length: 1,
name: "[Symbol.iterator]",
__proto__: [Cycle]
},
__proto__: [Cycle]
}
},
__proto__: null
}
}
</pre>
</details>
_After:_
```text
{
x: 1,
y: ""
}
```
|
3 years ago |
|
Addison Crump
|
2c19c6a4b5 |
Correct pop_on_return behaviour (#1853)
This PR changes the following: - Updates the value of `pop_on_return` after a catch as to prevent VM stack corruption - Adds two test cases which demonstrate the issue and demonstrate that it has been fixed I am unsure if it is possible to abuse the patch provided; one would need to catch from within an array initialisation without calling into another frame (e.g., with a lambda), which I don't think is possible. |
3 years ago |