From f3a293b50bd795ac49b00e600622b9b02d30aa41 Mon Sep 17 00:00:00 2001 From: Halid Odat Date: Tue, 20 Oct 2020 19:53:03 +0200 Subject: [PATCH] Fix Accessors panics (#902) --- boa/src/object/internal_methods.rs | 6 ++++-- boa/src/value/mod.rs | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/boa/src/object/internal_methods.rs b/boa/src/object/internal_methods.rs index e30fd2ad88..eda1e4feb8 100644 --- a/boa/src/object/internal_methods.rs +++ b/boa/src/object/internal_methods.rs @@ -83,8 +83,9 @@ impl GcObject { parent.get_field(key.clone()) } Some(ref desc) => match desc { - PropertyDescriptor::Accessor(_) => todo!(), PropertyDescriptor::Data(desc) => desc.value(), + // TODO: Add accessors + PropertyDescriptor::Accessor(_) => Value::undefined(), }, } } @@ -118,7 +119,8 @@ impl GcObject { let desc = DataDescriptor::new(val, own_desc.attributes()).into(); self.define_own_property(key, desc) } - PropertyDescriptor::Accessor(_) => todo!(), + // TODO: Add accessors + PropertyDescriptor::Accessor(_) => false, } } diff --git a/boa/src/value/mod.rs b/boa/src/value/mod.rs index 9daa74fa22..b5e9832c6f 100644 --- a/boa/src/value/mod.rs +++ b/boa/src/value/mod.rs @@ -456,7 +456,8 @@ impl Value { let key = key.into(); match self.get_property(key) { Some(ref desc) => match desc { - PropertyDescriptor::Accessor(_) => todo!("property accessor descriptors"), + // TODO: Add accessors + PropertyDescriptor::Accessor(_) => Value::undefined(), PropertyDescriptor::Data(desc) => desc.value(), }, None => Value::undefined(),