From 226ba4dcf394b1bddf4cf8dcf57221b6d4d6f63a Mon Sep 17 00:00:00 2001 From: Jason Williams Date: Thu, 7 Mar 2019 22:13:35 +0000 Subject: [PATCH] no need for mutable in private_obj --- src/lib/js/value.rs | 10 +++++----- tests/js/test.js | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lib/js/value.rs b/src/lib/js/value.rs index a90b830795..bfc439e208 100644 --- a/src/lib/js/value.rs +++ b/src/lib/js/value.rs @@ -47,7 +47,7 @@ impl ValueData { /// Returns a new empty object pub fn new_obj(global: Option) -> Value { let mut obj: ObjectData = HashMap::new(); - let mut private_obj: ObjectData = HashMap::new(); + let private_obj: ObjectData = HashMap::new(); if global.is_some() { let obj_proto = global .unwrap() @@ -64,7 +64,7 @@ impl ValueData { /// Similar to `new_obj`, but you can pass a prototype to create from pub fn new_obj_from_prototype(proto: Value) -> Value { let mut obj: ObjectData = HashMap::new(); - let mut private_obj: ObjectData = HashMap::new(); + let private_obj: ObjectData = HashMap::new(); obj.insert(INSTANCE_PROTOTYPE.to_string(), Property::new(proto)); Gc::new(ValueData::Object( GcCell::new(obj), @@ -343,7 +343,7 @@ impl ValueData { JSONValue::Bool(v) => ValueData::Boolean(v), JSONValue::Array(vs) => { let mut i = 0; - let mut private_data: ObjectData = HashMap::new(); + let private_data: ObjectData = HashMap::new(); let mut data: ObjectData = FromIterator::from_iter(vs.iter().map(|json| { i += 1; ( @@ -358,7 +358,7 @@ impl ValueData { ValueData::Object(GcCell::new(data), GcCell::new(private_data)) } JSONValue::Object(obj) => { - let mut private_data: ObjectData = HashMap::new(); + let private_data: ObjectData = HashMap::new(); let data: ObjectData = FromIterator::from_iter( obj.iter() .map(|(key, json)| (key.clone(), Property::new(to_value(json.clone())))), @@ -651,7 +651,7 @@ impl FromValue for Vec { impl ToValue for ObjectData { fn to_value(&self) -> Value { - let mut private_obj: ObjectData = HashMap::new(); + let private_obj: ObjectData = HashMap::new(); Gc::new(ValueData::Object( GcCell::new(self.clone()), GcCell::new(private_obj), diff --git a/tests/js/test.js b/tests/js/test.js index 593d1c2e86..eaf7c65929 100644 --- a/tests/js/test.js +++ b/tests/js/test.js @@ -1,2 +1,2 @@ var a = new String("test"); -a.length; \ No newline at end of file +a.toString();