Browse Source

Update AbstractCommandExecutor.java

将inReader.readLine()和logBuffer 分开,改成两个线程来处理。
pull/3/MERGE
小清 3 years ago committed by GitHub
parent
commit
f30f4cb3d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 45
      dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java

45
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractCommandExecutor.java

@ -82,6 +82,8 @@ public abstract class AbstractCommandExecutor {
* log list * log list
*/ */
protected final List<String> logBuffer; protected final List<String> logBuffer;
protected boolean logOutputIsScuccess = false;
/** /**
* taskExecutionContext * taskExecutionContext
@ -336,34 +338,49 @@ public abstract class AbstractCommandExecutor {
*/ */
private void parseProcessOutput(Process process) { private void parseProcessOutput(Process process) {
String threadLoggerInfoName = String.format(LoggerUtils.TASK_LOGGER_THREAD_NAME + "-%s", taskExecutionContext.getTaskAppId()); String threadLoggerInfoName = String.format(LoggerUtils.TASK_LOGGER_THREAD_NAME + "-%s", taskExecutionContext.getTaskAppId());
ExecutorService parseProcessOutputExecutorService = ThreadUtils.newDaemonSingleThreadExecutor(threadLoggerInfoName); ExecutorService getOutputLogService = ThreadUtils.newDaemonSingleThreadExecutor(threadLoggerInfoName + "-" + "getOutputLogService");
parseProcessOutputExecutorService.submit(new Runnable() { getOutputLogService.submit(new Runnable() {
@Override @Override
public void run() { public void run() {
BufferedReader inReader = null; BufferedReader inReader = null;
try { try {
inReader = new BufferedReader(new InputStreamReader(process.getInputStream())); inReader = new BufferedReader(new InputStreamReader(process.getInputStream()));
String line = null; String line;
while ((line = inReader.readLine()) != null) {
if (line.startsWith("${setValue(")) {
varPool.append(line.substring("${setValue(".length(), line.length() - 2));
varPool.append("$VarPool$");
} else {
logBuffer.add(line);
}
}
} catch (Exception e) {
logger.error(e.getMessage(), e);
} finally {
logOutputIsScuccess = true;
close(inReader);
}
}
});
ExecutorService parseProcessOutputExecutorService = ThreadUtils.newDaemonSingleThreadExecutor(threadLoggerInfoName);
parseProcessOutputExecutorService.submit(new Runnable() {
@Override
public void run() {
try {
long lastFlushTime = System.currentTimeMillis(); long lastFlushTime = System.currentTimeMillis();
while (logBuffer.size() > 0 || (line = inReader.readLine()) != null) { while (logBuffer.size() > 0 || !logOutputIsScuccess) {
if (null != line) { if (logBuffer.size() > 0) {
if (line.startsWith("${setValue(")) { lastFlushTime = flush(lastFlushTime);
varPool.append(line.substring("${setValue(".length(), line.length() - 2)); } else {
varPool.append("$VarPool$"); Thread.sleep(Constants.DEFAULT_LOG_FLUSH_INTERVAL);
} else {
logBuffer.add(line);
}
line = null;
} }
lastFlushTime = flush(lastFlushTime);
} }
} catch (Exception e) { } catch (Exception e) {
logger.error(e.getMessage(), e); logger.error(e.getMessage(), e);
} finally { } finally {
clear(); clear();
close(inReader);
} }
} }
}); });

Loading…
Cancel
Save