From ee0a4391e7a21ef7773eba015fa783ff616ac4a6 Mon Sep 17 00:00:00 2001 From: kyoty Date: Wed, 30 Jun 2021 00:32:44 +0800 Subject: [PATCH] [Improvement] the automatically generated spi service name in alert-plugin is wrong (#5676) * bug fix the auto generated spi service can't be recongized * include a new method --- .../dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java index b5335139bf..c09bf71da2 100644 --- a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java +++ b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/plugin/DolphinPluginDiscovery.java @@ -105,7 +105,7 @@ final class DolphinPluginDiscovery { public FileVisitResult visitFile(Path file, BasicFileAttributes attributes) { if (file.getFileName().toString().endsWith(JAVA_CLASS_FILE_SUFFIX)) { String name = file.subpath(base.getNameCount(), file.getNameCount()).toString(); - list.add(javaName(name.substring(0, name.length() - JAVA_CLASS_FILE_SUFFIX.length()))); + list.add(convertClassName(name.substring(0, name.length() - JAVA_CLASS_FILE_SUFFIX.length()))); } return FileVisitResult.CONTINUE; } @@ -143,4 +143,8 @@ final class DolphinPluginDiscovery { private static String javaName(String binaryName) { return binaryName.replace('/', '.'); } + + private static String convertClassName(String pathName) { + return pathName.replace(File.separatorChar, '.'); + } }