From e2eed1f24f05a2d6fdfda36fad2afe31324d5a1f Mon Sep 17 00:00:00 2001
From: kyoty <echohlne@gmail.com>
Date: Mon, 21 Jun 2021 18:52:25 +0800
Subject: [PATCH] [Improvement] Fix a potential problem when editing an
 existing mysql data source

---
 .../api/service/impl/DataSourceServiceImpl.java                 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
index 382339a240..d8955763f0 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
@@ -158,7 +158,7 @@ public class DataSourceServiceImpl extends BaseServiceImpl implements DataSource
 
         Result<Object> isConnection = checkConnection(dataSource.getType(), connectionParam);
         if (Status.SUCCESS.getCode() != isConnection.getCode()) {
-            return result;
+            return isConnection;
         }
 
         Date now = new Date();