From bfa3a36c921f0401cea607941652f0a2b3aa1be7 Mon Sep 17 00:00:00 2001
From: khadgarmage <khadgar.mage@outlook.com>
Date: Sat, 14 Dec 2019 21:54:11 +0800
Subject: [PATCH] unit test graph (#1479)

---
 .../dolphinscheduler/common/graph/DAGTest.java     | 14 ++++++++++++++
 pom.xml                                            |  1 +
 2 files changed, 15 insertions(+)

diff --git a/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/graph/DAGTest.java b/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/graph/DAGTest.java
index 210fedd5a4..5d7e27bf8c 100644
--- a/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/graph/DAGTest.java
+++ b/dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/graph/DAGTest.java
@@ -125,6 +125,10 @@ public class DAGTest {
     assertTrue(graph.containsEdge(1, 2));
     assertEquals(graph.getEdgesCount(), 1);
 
+    int node = 3;
+    graph.addNode(node, "v(3)");
+    assertFalse(graph.addEdge(node, node));
+
   }
 
 
@@ -347,4 +351,14 @@ public class DAGTest {
 
   }
 
+  @Test
+  public void testTopologicalSort4() {
+    clear();
+    try {
+      graph.topologicalSort();
+    } catch (Exception e) {
+      assertTrue(e.getMessage().contains("serious error: graph has cycle"));
+    }
+  }
+
 }
diff --git a/pom.xml b/pom.xml
index 8e70400598..46f3726d86 100644
--- a/pom.xml
+++ b/pom.xml
@@ -612,6 +612,7 @@
 				<version>${maven-surefire-plugin.version}</version>
 				<configuration>
 					<includes>
+						<include>**/common/graph/*.java</include>
 						<include>**/*CollectionUtilsTest.java</include><!--run test classes-->
 					</includes>
 					<!-- <skip>true</skip> -->