Browse Source
* fix the bug #2923 (Hive JDBC connection parameter ignored) , the hive jdbc connection url ; * fix the bug index out of bound and add some test case * add the Licensed * fix the checkstyle and import StringBuilder * put HiveDataSourceTest.java to root pom maven-surefire-plugin to avoiding the sonar 0.0% Coverage. * Update HiveDataSource.java Co-authored-by: dailidong <dailidong66@gmail.com>pull/3/MERGE
LEI SHENG
5 years ago
committed by
GitHub
3 changed files with 139 additions and 0 deletions
@ -0,0 +1,85 @@
|
||||
/* |
||||
* Licensed to the Apache Software Foundation (ASF) under one or more |
||||
* contributor license agreements. See the NOTICE file distributed with |
||||
* this work for additional information regarding copyright ownership. |
||||
* The ASF licenses this file to You under the Apache License, Version 2.0 |
||||
* (the "License"); you may not use this file except in compliance with |
||||
* the License. You may obtain a copy of the License at |
||||
* |
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
* |
||||
* Unless required by applicable law or agreed to in writing, software |
||||
* distributed under the License is distributed on an "AS IS" BASIS, |
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
||||
* See the License for the specific language governing permissions and |
||||
* limitations under the License. |
||||
*/ |
||||
|
||||
package org.apache.dolphinscheduler.dao.datasource; |
||||
|
||||
import org.junit.Assert; |
||||
import org.junit.Test; |
||||
|
||||
/** |
||||
* test data source of hive |
||||
*/ |
||||
public class HiveDataSourceTest { |
||||
|
||||
@Test |
||||
public void testfilterOther() { |
||||
BaseDataSource hiveDataSource = new HiveDataSource(); |
||||
|
||||
// not contain hive_site_conf
|
||||
String other = hiveDataSource.filterOther("charset=UTF-8"); |
||||
Assert.assertEquals("charset=UTF-8", other); |
||||
|
||||
// not contain
|
||||
other = hiveDataSource.filterOther(""); |
||||
Assert.assertEquals("", other); |
||||
|
||||
// only contain hive_site_conf
|
||||
other = hiveDataSource.filterOther("hive.mapred.mode=strict"); |
||||
Assert.assertEquals("?hive.mapred.mode=strict", other); |
||||
|
||||
// contain hive_site_conf at the first
|
||||
other = hiveDataSource.filterOther("hive.mapred.mode=strict;charset=UTF-8"); |
||||
Assert.assertEquals("charset=UTF-8?hive.mapred.mode=strict", other); |
||||
|
||||
// contain hive_site_conf in the middle
|
||||
other = hiveDataSource.filterOther("charset=UTF-8;hive.mapred.mode=strict;foo=bar"); |
||||
Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict", other); |
||||
|
||||
// contain hive_site_conf at the end
|
||||
other = hiveDataSource.filterOther("charset=UTF-8;foo=bar;hive.mapred.mode=strict"); |
||||
Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict", other); |
||||
|
||||
// contain multi hive_site_conf
|
||||
other = hiveDataSource.filterOther("charset=UTF-8;foo=bar;hive.mapred.mode=strict;hive.exec.parallel=true"); |
||||
Assert.assertEquals("charset=UTF-8;foo=bar?hive.mapred.mode=strict;hive.exec.parallel=true", other); |
||||
} |
||||
|
||||
@Test |
||||
public void testGetHiveJdbcUrlOther() { |
||||
|
||||
BaseDataSource hiveDataSource = new HiveDataSource(); |
||||
hiveDataSource.setAddress("jdbc:hive2://127.0.0.1:10000"); |
||||
hiveDataSource.setDatabase("test"); |
||||
hiveDataSource.setPassword("123456"); |
||||
hiveDataSource.setUser("test"); |
||||
Assert.assertEquals("jdbc:hive2://127.0.0.1:10000/test", hiveDataSource.getJdbcUrl()); |
||||
|
||||
hiveDataSource.setOther("charset=UTF-8;hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2"); |
||||
|
||||
Assert.assertEquals( |
||||
"jdbc:hive2://127.0.0.1:10000/test;charset=UTF-8?hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2", |
||||
hiveDataSource.getJdbcUrl()); |
||||
|
||||
hiveDataSource.setOther("hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2"); |
||||
|
||||
Assert.assertEquals( |
||||
"jdbc:hive2://127.0.0.1:10000/test;?hive.mapred.mode=strict;hive.server2.thrift.http.path=hs2", |
||||
hiveDataSource.getJdbcUrl()); |
||||
|
||||
} |
||||
|
||||
} |
Loading…
Reference in new issue