From 94fa1adf9bd315d96fb5ab025511fd33ad4b09f4 Mon Sep 17 00:00:00 2001
From: Tboy <guo.jiwei@immomo.com>
Date: Mon, 6 Jan 2020 11:35:29 +0800
Subject: [PATCH] move version to parent pom (#1722)

---
 dolphinscheduler-api/pom.xml | 12 ------------
 pom.xml                      | 13 +++++++++++++
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/dolphinscheduler-api/pom.xml b/dolphinscheduler-api/pom.xml
index 014799b0b6..decfd7627e 100644
--- a/dolphinscheduler-api/pom.xml
+++ b/dolphinscheduler-api/pom.xml
@@ -27,11 +27,6 @@
   <name>${project.artifactId}</name>
   <packaging>jar</packaging>
 
-  <properties>
-    <jasper-runtime.version>5.5.23</jasper-runtime.version>
-    <servlet-api.version>2.5</servlet-api.version>
-  </properties>
-
   <dependencies>
       <dependency>
           <groupId>org.apache.dolphinscheduler</groupId>
@@ -157,11 +152,6 @@
       <artifactId>fastjson</artifactId>
     </dependency>
 
-    <dependency>
-      <groupId>commons-collections</groupId>
-      <artifactId>commons-collections</artifactId>
-    </dependency>
-
     <dependency>
       <groupId>org.quartz-scheduler</groupId>
       <artifactId>quartz</artifactId>
@@ -241,13 +231,11 @@
     <dependency>
       <groupId>tomcat</groupId>
       <artifactId>jasper-runtime</artifactId>
-      <version>${jasper-runtime.version}</version>
     </dependency>
 
     <dependency>
       <groupId>javax.servlet</groupId>
       <artifactId>servlet-api</artifactId>
-      <version>${servlet-api.version}</version>
     </dependency>
 
     <dependency>
diff --git a/pom.xml b/pom.xml
index 2f1727f3c1..b545ff05b1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -116,6 +116,8 @@
 		<cobertura-maven-plugin.version>2.7</cobertura-maven-plugin.version>
 		<mockito.version>2.21.0</mockito.version>
 		<powermock.version>2.0.2</powermock.version>
+		<jasper-runtime.version>5.5.23</jasper-runtime.version>
+		<servlet-api.version>2.5</servlet-api.version>
 	</properties>
 
 	<dependencyManagement>
@@ -516,6 +518,17 @@
 				<version>${jcip.version}</version>
 				<optional>true</optional>
 			</dependency>
+			<dependency>
+				<groupId>tomcat</groupId>
+				<artifactId>jasper-runtime</artifactId>
+				<version>${jasper-runtime.version}</version>
+			</dependency>
+
+			<dependency>
+				<groupId>javax.servlet</groupId>
+				<artifactId>servlet-api</artifactId>
+				<version>${servlet-api.version}</version>
+			</dependency>
 		</dependencies>
 	</dependencyManagement>