From 92e70b94cc5f81d0eb075095c40c86e415c55ee2 Mon Sep 17 00:00:00 2001
From: Zhou Zheng <1606079777@qq.comom>
Date: Fri, 28 Aug 2020 17:41:15 +0800
Subject: [PATCH] improvement

---
 .../api/controller/TaskInstanceController.java            | 8 ++++----
 .../api/controller/TaskInstanceControllerTest.java        | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
index ea0c3eeb76..03fd279072 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
@@ -118,16 +118,16 @@ public class TaskInstanceController extends BaseController {
     }
 
     /**
-     * change one single task instance's state from failure to forced success
+     * change one single task instance's state from FAILURE to FORCED_SUCCESS
      *
      * @param loginUser      login user
      * @param projectName    project name
      * @param taskInstanceId task instance id
      * @return the result code and msg
      */
-    @ApiOperation(value = "force-success", notes = "")
+    @ApiOperation(value = "force-success", notes = "FORCE_SINGLE_TASK_SUCCESS")
     @ApiImplicitParams({
-            @ApiImplicitParam(name = "taskInstanceId", value = "TASK_INTSTANCE_ID", required = true, dataType = "Int", example = "2")
+            @ApiImplicitParam(name = "taskInstanceId", value = "TASK_INSTANCE_ID", required = true, dataType = "Int", example = "12")
     })
     @PostMapping(value = "/force-success")
     @ResponseStatus(HttpStatus.OK)
@@ -136,7 +136,7 @@ public class TaskInstanceController extends BaseController {
                                          @ApiParam(name = "projectName", value = "PROJECT_NAME", required = true) @PathVariable String projectName,
                                          @RequestParam(value = "taskInstanceId") Integer taskInstanceId) {
         logger.info("force task success, login user: {}, project:{}, task instance id:{}",
-                loginUser.getUserName(), projectName.replaceAll("[\n|\r|\t]", "_"), taskInstanceId);
+                loginUser.getUserName(), projectName, taskInstanceId);
         Map<String, Object> result = taskInstanceService.forceSingleTaskSuccess(loginUser, projectName, taskInstanceId);
         return returnDataList(result);
     }
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/TaskInstanceControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/TaskInstanceControllerTest.java
index abaaa3ffd2..02f234b316 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/TaskInstanceControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/TaskInstanceControllerTest.java
@@ -81,7 +81,7 @@ public class TaskInstanceControllerTest extends AbstractControllerTest{
     }
 
     @Test
-    public void forceSingleTaskSuccess() throws Exception {
+    public void testForceSingleTaskSuccess() throws Exception {
         MultiValueMap<String, String> paramsMap = new LinkedMultiValueMap<>();
         paramsMap.add("taskInstanceId","104");