From 896dec21e7d01c6b03d88e0a6dd5daabd61d598d Mon Sep 17 00:00:00 2001 From: yimaixinchen Date: Mon, 7 Feb 2022 23:24:42 +0800 Subject: [PATCH] change to autowired annotation (#8240) --- .../worker/processor/HostUpdateProcessor.java | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/HostUpdateProcessor.java b/dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/HostUpdateProcessor.java index ddedaa8b96..37eb07bd7d 100644 --- a/dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/HostUpdateProcessor.java +++ b/dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/HostUpdateProcessor.java @@ -17,22 +17,19 @@ package org.apache.dolphinscheduler.server.worker.processor; +import com.google.common.base.Preconditions; +import io.netty.channel.Channel; import org.apache.dolphinscheduler.common.utils.JSONUtils; import org.apache.dolphinscheduler.remote.command.Command; import org.apache.dolphinscheduler.remote.command.CommandType; import org.apache.dolphinscheduler.remote.command.HostUpdateCommand; import org.apache.dolphinscheduler.remote.processor.NettyRemoteChannel; import org.apache.dolphinscheduler.remote.processor.NettyRequestProcessor; -import org.apache.dolphinscheduler.service.bean.SpringApplicationContext; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; -import com.google.common.base.Preconditions; - -import io.netty.channel.Channel; - /** * update process host * this used when master failover @@ -45,6 +42,7 @@ public class HostUpdateProcessor implements NettyRequestProcessor { /** * task callback service */ + @Autowired private TaskCallbackService taskCallbackService; @Override @@ -52,10 +50,6 @@ public class HostUpdateProcessor implements NettyRequestProcessor { Preconditions.checkArgument(CommandType.PROCESS_HOST_UPDATE_REQUEST == command.getType(), String.format("invalid command type : %s", command.getType())); HostUpdateCommand updateCommand = JSONUtils.parseObject(command.getBody(), HostUpdateCommand.class); logger.info("received host update command : {}", updateCommand); - - if (taskCallbackService == null) { - taskCallbackService = SpringApplicationContext.getBean(TaskCallbackService.class); - } taskCallbackService.changeRemoteChannel(updateCommand.getTaskInstanceId(), new NettyRemoteChannel(channel, command.getOpaque())); }